sasco\LibreDTE\Sii::request()

Complexity

Conditions	16
Paths	192

Size

Total Lines	58
Code Lines	44

Duplication

Lines	25
Ratio	43.1 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public static function request($wsdl, $request, $args = null, $retry = null)
    {
        if (is_numeric($args)) {
            $retry = (int)$args;
            $args = null;
        }
        if (!$retry)
            $retry = self::$retry;
        if ($args and !is_array($args))

Using logical operators such as and instead of && is generally not recommended.

            $args = [$args];
        if (!self::$verificar_ssl) {

This code seems to be duplicated across your project.

            if (self::getAmbiente()==self::PRODUCCION) {
                $msg = Estado::get(Estado::ENVIO_SSL_SIN_VERIFICAR);
                \sasco\LibreDTE\Log::write(Estado::ENVIO_SSL_SIN_VERIFICAR, $msg, LOG_WARNING);

$msg is of type integer|string, but the function expects a object<sasco\LibreDTE\Mensaje>|null.

LOG_WARNING is of type integer, but the function expects a object<sasco\LibreDTE\Gravedad>.

            }
            $options = ['stream_context' => stream_context_create([
                'ssl' => [
                    'verify_peer' => false,
                    'verify_peer_name' => false,
                    'allow_self_signed' => true
                ]
            ])];
        } else {
            $options = [];
        }
        try {
            $soap = new \SoapClient(self::wsdl($wsdl), $options);
        } catch (\Exception $e) {
            $msg = $e->getMessage();
            if (isset($e->getTrace()[0]['args'][1]) and is_string($e->getTrace()[0]['args'][1])) {

This code seems to be duplicated across your project.

Using logical operators such as and instead of && is generally not recommended.

                $msg .= ': '.$e->getTrace()[0]['args'][1];
            }
            \sasco\LibreDTE\Log::write(Estado::REQUEST_ERROR_SOAP, Estado::get(Estado::REQUEST_ERROR_SOAP, $msg));

\sasco\LibreDTE\Estado::get(\sasco\LibreDTE\Estado::REQUEST_ERROR_SOAP, $msg) is of type integer|string, but the function expects a object<sasco\LibreDTE\Mensaje>|null.

            return false;
        }
        for ($i=0; $i<$retry; $i++) {
            try {
                if ($args) {
                    $body = call_user_func_array([$soap, $request], $args);
                } else {
                    $body = $soap->$request();
                }
                break;
            } catch (\Exception $e) {
                $msg = $e->getMessage();
                if (isset($e->getTrace()[0]['args'][1]) and is_string($e->getTrace()[0]['args'][1])) {

This code seems to be duplicated across your project.

Using logical operators such as and instead of && is generally not recommended.

                    $msg .= ': '.$e->getTrace()[0]['args'][1];
                }
                \sasco\LibreDTE\Log::write(Estado::REQUEST_ERROR_SOAP, Estado::get(Estado::REQUEST_ERROR_SOAP, $msg));

\sasco\LibreDTE\Estado::get(\sasco\LibreDTE\Estado::REQUEST_ERROR_SOAP, $msg) is of type integer|string, but the function expects a object<sasco\LibreDTE\Mensaje>|null.

                $body = null;
            }
        }
        if ($body===null) {

The variable $body does not seem to be defined for all execution paths leading up to this point.

This code seems to be duplicated across your project.

            \sasco\LibreDTE\Log::write(Estado::REQUEST_ERROR_BODY, Estado::get(Estado::REQUEST_ERROR_BODY, $wsdl, $retry));

\sasco\LibreDTE\Estado::get(\sasco\LibreDTE\Estado::REQUEST_ERROR_BODY, $wsdl, $retry) is of type integer|string, but the function expects a object<sasco\LibreDTE\Mensaje>|null.

            return false;
        }
        return new \SimpleXMLElement($body, LIBXML_COMPACT);
    }