libredte /
libredte-lib-core
| Conditions | 18 |
| Paths | 1344 |
| Total Lines | 142 |
| Code Lines | 111 |
| Lines | 42 |
| Ratio | 29.58 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 287 | private function addNormalTable(array $headers, array $data, array $options = []) |
||
| 288 | { |
||
| 289 | // Colors, line width and bold font |
||
| 290 | $this->SetFillColor( |
||
| 291 | $options['headerbackground'][0], |
||
| 292 | $options['headerbackground'][1], |
||
| 293 | $options['headerbackground'][2] |
||
| 294 | ); |
||
| 295 | $this->SetTextColor( |
||
| 296 | $options['headercolor'][0], |
||
| 297 | $options['headercolor'][1], |
||
| 298 | $options['headercolor'][2] |
||
| 299 | ); |
||
| 300 | $this->SetDrawColor( |
||
| 301 | $options['bordercolor'][0], |
||
| 302 | $options['bordercolor'][1], |
||
| 303 | $options['bordercolor'][2] |
||
| 304 | ); |
||
| 305 | $this->SetLineWidth($options['borderwidth']); |
||
| 306 | $this->SetFont($this->defaultOptions['font']['family'], 'B', $options['fontsize']); |
||
| 307 | // corregir indices |
||
| 308 | $headers_keys = array_keys($headers); |
||
| 309 | if (is_array($options['width'])) { |
||
| 310 | $options['width'] = array_combine($headers_keys, $options['width']); |
||
| 311 | } else { |
||
| 312 | $options['width'] = $this->getTableCellWidth($options['width'], $headers_keys); |
||
| 313 | } |
||
| 314 | if (is_array($options['align'])) { |
||
| 315 | $options['align'] = array_combine($headers_keys, $options['align']); |
||
| 316 | foreach ($options['align'] as &$a) { |
||
| 317 | $a = strtoupper($a[0]); |
||
| 318 | } |
||
| 319 | } else if (is_string($options['align'])) { |
||
| 320 | $align = $options['align']; |
||
| 321 | $options['align'] = []; |
||
| 322 | foreach ($headers_keys as $key) { |
||
| 323 | $options['align'][$key] = $align; |
||
| 324 | } |
||
| 325 | } |
||
| 326 | // Header |
||
| 327 | $x = $this->GetX(); |
||
| 328 | View Code Duplication | foreach($headers as $i => $header) { |
|
| 329 | $this->Cell($options['width'][$i], $options['height'], $headers[$i], 1, 0, $options['align'][$i], 1); |
||
| 330 | } |
||
| 331 | $this->Ln(); |
||
| 332 | $y = $this->GetY(); |
||
| 333 | // Color and font restoration |
||
| 334 | $this->SetFillColor ( |
||
| 335 | $options['bodybackground'][0], |
||
| 336 | $options['bodybackground'][1], |
||
| 337 | $options['bodybackground'][2] |
||
| 338 | ); |
||
| 339 | $this->SetTextColor( |
||
| 340 | $options['bodycolor'][0], |
||
| 341 | $options['bodycolor'][1], |
||
| 342 | $options['bodycolor'][2] |
||
| 343 | ); |
||
| 344 | $this->SetDrawColor( |
||
| 345 | $options['bordercolor'][0], |
||
| 346 | $options['bordercolor'][1], |
||
| 347 | $options['bordercolor'][2] |
||
| 348 | ); |
||
| 349 | $this->SetLineWidth($options['borderwidth']); |
||
| 350 | $this->SetFont($this->defaultOptions['font']['family']); |
||
| 351 | // Data |
||
| 352 | foreach ($data as &$row) { |
||
| 353 | $num_pages = $this->getNumPages(); |
||
| 354 | $this->startTransaction(); |
||
| 355 | // agregar datos de la fila |
||
| 356 | $this->SetX($x); |
||
| 357 | $y_0 = $this->GetY(); |
||
| 358 | $y_s = []; |
||
| 359 | View Code Duplication | foreach($headers as $i => $header) { |
|
| 360 | $x_0 = $this->GetX(); |
||
| 361 | $this->SetXY($x_0, $y_0); |
||
| 362 | $aux = explode("\n", $row[$i]); |
||
| 363 | $value1 = $aux[0]; |
||
| 364 | $value2 = isset($aux[1]) ? $aux[1] : null; |
||
| 365 | $y_1 = $this->MultiCell($options['width'][$i], $options['height'], $value1, $options['tdborder'], $options['align'][$i], false, 0); |
||
| 366 | if ($value2) { |
||
| 367 | $this->Ln(); |
||
| 368 | $this->SetX($x_0); |
||
| 369 | $this->SetFont($this->defaultOptions['font']['family'], '', $options['fontsize']-2); |
||
| 370 | $y_2 = $this->MultiCell($options['width'][$i], $options['height'], $value2, $options['tdborder'], $options['align'][$i], false, 0); |
||
| 371 | $this->SetFont($this->defaultOptions['font']['family'], '', $options['fontsize']); |
||
| 372 | $y_s[] = $y_1 + $y_2*0.9; |
||
| 373 | } else { |
||
| 374 | $y_s[] = $y_1; |
||
| 375 | } |
||
| 376 | } |
||
| 377 | $this->Ln(max($y_s)*5); |
||
| 378 | // si se pasó a página siguiente se hace rollback y se crea nueva página con cabecera nuevamente en la tabla |
||
| 379 | if($num_pages < $this->getNumPages()) { |
||
| 380 | $this->rollbackTransaction(true); |
||
| 381 | $this->AddPage(); |
||
| 382 | $this->SetX($x); |
||
| 383 | View Code Duplication | foreach($headers as $i => $header) { |
|
| 384 | $this->Cell($options['width'][$i], $options['height'], $headers[$i], 1, 0, $options['align'][$i], 1); |
||
| 385 | } |
||
| 386 | $this->Ln(); |
||
| 387 | $this->SetX($x); |
||
| 388 | $y_0 = $this->GetY(); |
||
| 389 | $y_s = []; |
||
| 390 | View Code Duplication | foreach($headers as $i => $header) { |
|
| 391 | $x_0 = $this->GetX(); |
||
| 392 | $this->SetXY($x_0, $y_0); |
||
| 393 | $aux = explode("\n", $row[$i]); |
||
| 394 | $value1 = $aux[0]; |
||
| 395 | $value2 = isset($aux[1]) ? $aux[1] : null; |
||
| 396 | $y_1 = $this->MultiCell($options['width'][$i], $options['height'], $value1, $options['tdborder'], $options['align'][$i], false, 0); |
||
| 397 | if ($value2) { |
||
| 398 | $this->Ln(); |
||
| 399 | $this->SetX($x_0); |
||
| 400 | $this->SetFont($this->defaultOptions['font']['family'], '', $options['fontsize']-2); |
||
| 401 | $y_2 = $this->MultiCell($options['width'][$i], $options['height'], $value2, $options['tdborder'], $options['align'][$i], false, 0); |
||
| 402 | $this->SetFont($this->defaultOptions['font']['family'], '', $options['fontsize']); |
||
| 403 | $y_s[] = $y_1 + $y_2*0.9; |
||
| 404 | } else { |
||
| 405 | $y_s[] = $y_1; |
||
| 406 | } |
||
| 407 | } |
||
| 408 | $this->Ln(max($y_s)*5); |
||
| 409 | } else { |
||
| 410 | $this->commitTransaction(); |
||
| 411 | } |
||
| 412 | } |
||
| 413 | // si la tabla tiene indicado un punto específico en Y donde terminar se usa ese punto |
||
| 414 | if ($options['end']) { |
||
| 415 | $lx = $x; |
||
| 416 | $this->Line($lx, $y, $lx, $options['end']); |
||
| 417 | foreach ($options['width'] as $ancho) { |
||
| 418 | $lx += $ancho; |
||
| 419 | $this->Line($lx, $y, $lx, $options['end']); |
||
| 420 | } |
||
| 421 | $this->SetXY($x, $options['end']); |
||
| 422 | } else { |
||
| 423 | $this->SetX($x); |
||
| 424 | } |
||
| 425 | // asignar línea final |
||
| 426 | $this->Cell(array_sum($options['width']), 0, '', 'T'); |
||
| 427 | $this->Ln(); |
||
| 428 | } |
||
| 429 | |||
| 473 |
Loading history...
PHP has two types of connecting operators (logical operators, and boolean operators):
and&&or||The difference between these is the order in which they are executed. In most cases, you would want to use a boolean operator like
&&, or||.Let’s take a look at a few examples:
Logical Operators are used for Control-Flow
One case where you explicitly want to use logical operators is for control-flow such as this:
Since
dieintroduces problems of its own, f.e. it makes our code hardly testable, and prevents any kind of more sophisticated error handling; you probably do not want to use this in real-world code. Unfortunately, logical operators cannot be combined withthrowat this point:These limitations lead to logical operators rarely being of use in current PHP code.