libredte /
libredte-lib-core
| Total Complexity | 43 |
| Total Lines | 348 |
| Duplicated Lines | 0 % |
| Coverage | 0% |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like DispatcherWorker often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DispatcherWorker, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 45 | #[Worker(name: 'dispatcher', component: 'document', package: 'billing')] |
||
| 46 | class DispatcherWorker extends AbstractWorker implements DispatcherWorkerInterface |
||
| 47 | { |
||
| 48 | public function __construct( |
||
| 49 | private XmlServiceInterface $xmlService, |
||
| 50 | private SignatureServiceInterface $signatureService, |
||
| 51 | private DocumentBagManagerWorkerInterface $documentBagManagerWorker, |
||
| 52 | iterable $jobs = [], |
||
| 53 | iterable $handlers = [] |
||
| 54 | ) { |
||
| 55 | $this->setJobs($jobs); |
||
| 56 | $this->setHandlers($handlers); |
||
| 57 | } |
||
| 58 | |||
| 59 | /** |
||
| 60 | * {@inheritDoc} |
||
| 61 | */ |
||
| 62 | public function normalize( |
||
| 63 | DocumentEnvelopeInterface $envelope |
||
| 64 | ): DocumentEnvelopeInterface { |
||
| 65 | $this->ensureSobreEnvio($envelope); |
||
| 66 | $this->ensureDocuments($envelope); |
||
| 67 | $this->ensureEmisor($envelope); |
||
| 68 | $this->ensureMandatario($envelope); |
||
| 69 | $this->ensureReceptor($envelope); |
||
| 70 | $this->ensureCaratula($envelope); |
||
| 71 | $this->ensureXmlDocument($envelope); |
||
| 72 | |||
| 73 | return $envelope; |
||
| 74 | } |
||
| 75 | |||
| 76 | /** |
||
| 77 | * {@inheritDoc} |
||
| 78 | */ |
||
| 79 | public function loadXml(string $xml): DocumentEnvelopeInterface |
||
| 80 | { |
||
| 81 | $xmlDocument = new XmlDocument(); |
||
| 82 | $xmlDocument->loadXML($xml); |
||
| 83 | $envelope = new DocumentEnvelope(); |
||
| 84 | $envelope->setXmlDocument($xmlDocument); |
||
| 85 | |||
| 86 | return $this->normalize($envelope); |
||
| 87 | } |
||
| 88 | |||
| 89 | /** |
||
| 90 | * {@inheritDoc} |
||
| 91 | */ |
||
| 92 | public function validate( |
||
| 93 | DocumentEnvelopeInterface|XmlDocumentInterface|string $source |
||
| 94 | ): void { |
||
| 95 | // TODO: Agregar validaciones del sobre. |
||
| 96 | } |
||
| 97 | |||
| 98 | /** |
||
| 99 | * {@inheritDoc} |
||
| 100 | */ |
||
| 101 | public function validateSchema( |
||
| 102 | DocumentEnvelopeInterface|XmlDocumentInterface|string $source |
||
| 103 | ): void { |
||
| 104 | // Obtener el documento XML. |
||
| 105 | if ($source instanceof DocumentEnvelopeInterface) { |
||
| 106 | $xmlDocument = $source->getXmlDocument(); |
||
| 107 | } elseif ($source instanceof XmlDocumentInterface) { |
||
| 108 | $xmlDocument = $source; |
||
| 109 | } else { |
||
| 110 | $xmlDocument = new XmlDocument(); |
||
| 111 | $xmlDocument->loadXml($source); |
||
| 112 | } |
||
| 113 | |||
| 114 | // Validar esquema del sobre de documentos (EnvioDTE y EnvioBOLETA). |
||
| 115 | $schema = sprintf( |
||
| 116 | '%s/resources/schemas/%s', |
||
| 117 | dirname(__DIR__, 6), |
||
| 118 | $xmlDocument->getSchema() |
||
| 119 | ); |
||
| 120 | $this->xmlService->validate( |
||
| 121 | $xmlDocument, |
||
|
Bug
introduced
by
|
|||
| 122 | $schema |
||
| 123 | ); |
||
| 124 | } |
||
| 125 | |||
| 126 | /** |
||
| 127 | * {@inheritDoc} |
||
| 128 | */ |
||
| 129 | public function validateSignature( |
||
| 130 | DocumentEnvelopeInterface|XmlDocumentInterface|string $source |
||
| 131 | ): void { |
||
| 132 | $xml = $source instanceof DocumentEnvelopeInterface |
||
| 133 | ? $source->getXmlDocument() |
||
| 134 | : $source |
||
| 135 | ; |
||
| 136 | |||
| 137 | $this->signatureService->validateXml($xml); |
||
| 138 | } |
||
| 139 | |||
| 140 | /** |
||
| 141 | * Se asegura que exista un arreglo con las bolsas de los documentos |
||
| 142 | * tributarios si no está definida y existe un documento XML en el sobre. |
||
| 143 | * |
||
| 144 | * @param DocumentEnvelopeInterface $envelope |
||
| 145 | * @return void |
||
| 146 | */ |
||
| 147 | protected function ensureDocuments( |
||
| 148 | DocumentEnvelopeInterface $envelope |
||
| 149 | ): void { |
||
| 150 | // Verificar si es necesario, y se puede, asignar. |
||
| 151 | if ($envelope->getDocuments() !== null || !$envelope->getSobreEnvio()) { |
||
| 152 | return; |
||
| 153 | } |
||
| 154 | |||
| 155 | // Buscar documentos (DTE) en el XML del sobre y crear la bolsa de |
||
| 156 | // cada documento para agregarla al listado de documentos que el sobre |
||
| 157 | // gestiona. |
||
| 158 | foreach ($envelope->getSobreEnvio()->getXmlDocumentos() as $xml) { |
||
| 159 | $xmlDocument = new XmlDocument(); |
||
| 160 | $xmlDocument->loadXml($xml); |
||
| 161 | $bag = $this->documentBagManagerWorker->create($xmlDocument); |
||
| 162 | $envelope->addDocument($bag); |
||
| 163 | } |
||
| 164 | } |
||
| 165 | |||
| 166 | protected function ensureEmisor(DocumentEnvelopeInterface $envelope): void |
||
| 167 | { |
||
| 168 | // Verificar si es necesario, y se puede, asignar. |
||
| 169 | if ($envelope->getEmisor() || !$envelope->getDocuments()) { |
||
| 170 | return; |
||
| 171 | } |
||
| 172 | |||
| 173 | // Asignar como emisor del sobre el emisor del primer documento. |
||
| 174 | $emisor = $envelope->getDocuments()[0]->getEmisor(); |
||
| 175 | $envelope->setEmisor($emisor); |
||
| 176 | } |
||
| 177 | |||
| 178 | protected function ensureMandatario(DocumentEnvelopeInterface $envelope): void |
||
| 188 | } |
||
| 189 | |||
| 190 | protected function ensureReceptor(DocumentEnvelopeInterface $envelope): void |
||
| 191 | { |
||
| 192 | // Verificar si es necesario, y se puede, asignar. |
||
| 193 | if ($envelope->getReceptor() || !$envelope->getDocuments()) { |
||
| 194 | return; |
||
| 195 | } |
||
| 196 | |||
| 197 | // Asignar como receptor del sobre el receptor del primer documento. |
||
| 198 | $receptor = $envelope->getDocuments()[0]->getReceptor(); |
||
| 199 | $envelope->setReceptor($receptor); |
||
| 200 | } |
||
| 201 | |||
| 202 | protected function ensureCaratula(DocumentEnvelopeInterface $envelope): void |
||
| 203 | { |
||
| 204 | // Verificar si es necesario, y se puede, asignar. |
||
| 205 | if ( |
||
| 206 | $envelope->getCaratula() |
||
| 207 | || !$envelope->getDocuments() |
||
| 208 | || !$envelope->getEmisor() |
||
| 209 | || !$envelope->getMandatario() |
||
| 210 | || !$envelope->getReceptor() |
||
| 211 | ) { |
||
| 212 | return; |
||
| 213 | } |
||
| 214 | |||
| 215 | // Si se agregaron más tipos de documentos que los permitidos error. |
||
| 216 | $SubTotDTE = $this->getResumen($envelope); |
||
| 217 | |||
| 218 | $maximoTiposDocumentos = $envelope->getTipoSobre()->getMaximoTiposDocumentos(); |
||
| 219 | if (isset($SubTotDTE[$maximoTiposDocumentos])) { |
||
| 220 | throw new DispatcherException( |
||
| 221 | 'Se agregaron más tipos de documentos de los que son permitidos en el sobre (%d).', |
||
| 222 | $maximoTiposDocumentos |
||
| 223 | ); |
||
| 224 | } |
||
| 225 | |||
| 226 | // Timestamp de la firma del sobre que se generará. |
||
| 227 | $timestamp = date('Y-m-d\TH:i:s'); |
||
| 228 | |||
| 229 | // Crear datos de la carátula. |
||
| 230 | $caratula = [ |
||
| 231 | '@attributes' => [ |
||
| 232 | 'version' => '1.0', |
||
| 233 | ], |
||
| 234 | 'RutEmisor' => $envelope->getEmisor()->getRut(), |
||
| 235 | 'RutEnvia' => $envelope->getMandatario()->getRun(), |
||
| 236 | 'RutReceptor' => $envelope->getReceptor()->getRut(), |
||
| 237 | 'FchResol' => $envelope->getEmisor()->getAutorizacionDte()->getFechaResolucion(), |
||
| 238 | 'NroResol' => $envelope->getEmisor()->getAutorizacionDte()->getNumeroResolucion(), |
||
| 239 | 'TmstFirmaEnv' => $timestamp, |
||
| 240 | 'SubTotDTE' => $SubTotDTE, |
||
| 241 | ]; |
||
| 242 | |||
| 243 | // Asignar carátula al sobre. |
||
| 244 | $envelope->setCaratula($caratula); |
||
| 245 | } |
||
| 246 | |||
| 247 | protected function ensureXmlDocument( |
||
| 306 | } |
||
| 307 | } |
||
| 308 | |||
| 309 | protected function ensureSobreEnvio( |
||
| 310 | DocumentEnvelopeInterface $envelope |
||
| 311 | ): void { |
||
| 312 | // Verificar si es necesario, y se puede, asignar. |
||
| 313 | if ($envelope->getSobreEnvio() || !$envelope->getXmlDocument()) { |
||
| 314 | return; |
||
| 315 | } |
||
| 316 | |||
| 317 | // Asignar la entidad del sobre del envío. |
||
| 318 | $sobreEnvio = new SobreEnvio($envelope->getXmlDocument()); |
||
| 319 | $envelope->setSobreEnvio($sobreEnvio); |
||
| 320 | } |
||
| 321 | |||
| 322 | /** |
||
| 323 | * Obtiene el resumen de los documentos que hay en el sobre. |
||
| 324 | * |
||
| 325 | * Esto se usa para para generar los tags del XML `SubTotDTE`. |
||
| 326 | * |
||
| 327 | * @param DocumentEnvelopeInterface $envelope |
||
| 328 | * @return array Arreglo con el resumen de documentos por tipo. |
||
| 329 | */ |
||
| 330 | protected function getResumen(DocumentEnvelopeInterface $envelope): array |
||
| 353 | } |
||
| 354 | |||
| 355 | /** |
||
| 356 | * Firma el sobre de documentos. |
||
| 357 | * |
||
| 358 | * @param DocumentEnvelopeInterface $envelope |
||
| 359 | * @return void |
||
| 360 | */ |
||
| 361 | protected function sign(DocumentEnvelopeInterface $envelope): void |
||
| 393 | } |
||
| 394 | } |
||
| 395 |
Loading history...