Graviton\ImportExport\Command\ImportCommandAbstract

Complexity

Total Complexity

13

Size/Duplication

Total Lines	111
Duplicated Lines	11.71 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

70.73%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	execute()	0	10	2
C	getFinder()	13	56	10
	doImport()	0	1	?

<?php
/**
 * base abstract for import based commands where a bunch of file must be collected and
 * done something with them..
 */

namespace Graviton\ImportExport\Command;

use Graviton\ImportExport\Exception\MissingTargetException;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Finder\Finder;
use Symfony\Component\Finder\SplFileInfo;

/**
 * @author   List of contributors <https://github.com/libgraviton/import-export/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
abstract class ImportCommandAbstract extends Command
{
    /**
     * @var Finder
     */
    protected $finder;

    /**
     * @param Finder $finder finder instance
     */
    public function __construct(
        Finder $finder
    ) {
        $this->finder = $finder;
        parent::__construct();
    }

    /**
     * Executes the current command.
     *
     * @param InputInterface  $input  User input on console
     * @param OutputInterface $output Output of the command
     *
     * @return integer
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $exitCode = 1;
        try {
            $exitCode = $this->doImport($this->getFinder($input), $input, $output);

It seems like $this->getFinder($input) targeting Graviton\ImportExport\Command\ImportCommandAbstract::getFinder() can also be of type array<integer,object<Symfony\Component\Finder\SplFileInfo>>; however, Graviton\ImportExport\Command\ImportCommandAbstract::doImport() does only seem to accept object<Symfony\Component\Finder\Finder>, maybe add an additional type check?

        } catch (MissingTargetException $e) {
            $output->writeln('<error>' . $e->getMessage() . '</error>');
        }
        return $exitCode;
    }

    /**
     * Returns a Finder according to the input params
     *
     * @param InputInterface $input User input on console
     *
     * @return Finder|SplFileInfo[] finder
     */
    protected function getFinder($input)
    {
        $files = $input->getArgument('file');
        $inputFile = $input->getOption('input-file');

        if (empty($files) && is_null($inputFile)) {
            throw new \LogicException('You either need to provide <file> arguments or the --input-file option.');
        }

        $finder = $this->finder->files();

        /**
         * @param SplFileInfo $file
         * @return bool
         */
        $filter = function (SplFileInfo $file) {

This code seems to be duplicated across your project.

            if (!in_array($file->getExtension(), ['yml','json']) || $file->isDir()) {
                return false;
            }
            return true;
        };

        if (is_null($inputFile)) {
            // normal way - file arguments..
            foreach ($files as $file) {

This code seems to be duplicated across your project.

                if (is_file($file)) {
                    $finder->in(dirname($file))->name(basename($file));
                } else {
                    $finder->in($file);
                }
            }
        } else {
            // file list via input file
            if (!file_exists($inputFile)) {
                throw new \LogicException('File '.$inputFile.' does not seem to exist.');
            }

            $fileList = explode(PHP_EOL, file_get_contents($inputFile));

            $fileList = array_filter(
                $fileList,
                function ($val) {
                    if (!empty($val)) {
                        return true;
                    }
                    return false;
                }
            );

            $finder->append($fileList);
        }

        $finder->ignoreDotFiles(true)->filter($filter);

        return $finder;
    }

    /**
     * the actual command can do his import here..
     *
     * @param Finder          $finder finder
     * @param InputInterface  $input  input
     * @param OutputInterface $output output
     *
     * @return mixed
     */
    abstract protected function doImport(Finder $finder, InputInterface $input, OutputInterface $output);
}