FileManagerTest::testHas() - Code Metrics - Inspection of "Merge branch 'release/0.82.0'" - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4d0d5e...a83342 )

by Bastian

created 2016-11-14 10:48 UTC

FileManagerTest::testHas() A

↳ Parent: FileManagerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php
/**
 * Test suite for the FileManager
 */

namespace Graviton\FileBundle\Tests;

use Graviton\FileBundle\FileManager;
use Graviton\TestBundle\Test\WebTestCase;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\HttpFoundation\Response;

/**
 * Basic functional test for /file
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class FileManagerTest extends WebTestCase
{
    /** @var \Gaufrette\Filesystem $fileSystem */
    private $fileSystem;

    /** @var \Graviton\FileBundle\FileDocumentFactory $fileDocumentFactory */
    private $fileDocumentFactory;

    /**
     * Initiates mandatory properties
     *
     * @return void
     */
    public function setUp()
    {
        $this->fileSystem = $this->getMockBuilder('\Gaufrette\Filesystem')
            ->disableOriginalConstructor()
            ->getMock();

        $this->fileDocumentFactory = $this->getMockBuilder('\Graviton\FileBundle\FileDocumentFactory')
            ->getMock();
    }

    /**
     * Verifies the correct behavior of has method
     *
     * @return void
     */
    public function testHas()

    {
        $this->fileSystem

            ->expects($this->once())
            ->method('has')
            ->willReturn(true);

        $manager = new FileManager($this->fileSystem, $this->fileDocumentFactory);

        $this->assertTrue($manager->has('myKey'));
    }

    /**
     * Verifies the correct behavior of read method
     *
     * @return void
     */
    public function testRead()

    {
        $this->fileSystem

            ->expects($this->once())
            ->method('read')
            ->willReturn('myData');

        $manager = new FileManager($this->fileSystem, $this->fileDocumentFactory);

        $this->assertEquals('myData', $manager->read('myKey'));
    }

    /**
     * Verifies the correct behavior of read method
     *
     * @return void
     */
    public function testDelete()

    {
        $this->fileSystem

            ->expects($this->once())
            ->method('delete')
            ->willReturn(true);

        $manager = new FileManager($this->fileSystem, $this->fileDocumentFactory);

        $this->assertTrue($manager->delete('myKey'));
    }

    /**
     * Verifies the correct behavior of the FileManager
     *
     * @return void
     */
    public function testSaveFiles()
    {
        $jsonData = '{
          "links": [
            {
              "$ref": "http://localhost/testcase/readonly/101",
              "type": "owner"
            },
            {
              "$ref": "http://localhost/testcase/readonly/102",
              "type": "module"
            }
          ],
          "metadata": {
            "action":[{"command":"print"},{"command":"archive"}]
          }
        }';

        copy(__DIR__ . '/Fixtures/test.txt', sys_get_temp_dir() . '/test.txt');
        $file = sys_get_temp_dir() . '/test.txt';
        $uploadedFile = new UploadedFile($file, 'test.txt', 'text/plain', 15);
        $client = $this->createClient();
        $client->request(
            'POST',
            '/file',
            [
                'metadata' => $jsonData,
            ],
            [
                'upload' => $uploadedFile,
            ]
        );
        $response = $client->getResponse();
        $location = $response->headers->get('location');

        $this->assertEquals(Response::HTTP_CREATED, $response->getStatusCode());
        $this->assertContains('/file/', $location);

        // receive generated file information
        $client = $this->createClient();
        $client->request(
            'GET',
            $location,
            [],
            [],
            [
                'HTTP_ACCEPT' => 'application/json'
            ]
        );

        $response = $client->getResponse();
        $contentArray = json_decode($response->getContent(), true);

        $this->assertEquals([["command" => "print"], ["command" => "archive"]], $contentArray['metadata']['action']);
        $this->assertJsonStringEqualsJsonString(
            '[
              {
                "$ref": "http://localhost/testcase/readonly/101",
                "type": "owner"
              },
              {
                "$ref": "http://localhost/testcase/readonly/102",
                "type": "module"
              }
            ]',
            json_encode($contentArray['links'])
        );

        // Check contain data
        $this->assertArrayHasKey('modificationDate', $contentArray['metadata']);
        $this->assertArrayHasKey('createDate', $contentArray['metadata']);

        // Test Metadata, and Remove date.
        unset($contentArray['metadata']['modificationDate']);
        unset($contentArray['metadata']['createDate']);

        $this->assertJsonStringEqualsJsonString(
            '{
                "size":16,
                "action":[
                    {"command":"print"},
                    {"command":"archive"}
                ],
                "mime":"text\/plain",
                "filename":"test.txt",
                "hash":"4f3cbec0e58903d8bdcbd03d283cf43ed49a95d8d8b341ee38c0ba085204e2d5",
                "additionalProperties":[]
             }',
            json_encode($contentArray['metadata'])
        );

        // clean up
        $client = $this->createClient();
        $client->request(
            'DELETE',
            $location
        );
    }


    /**
     * Verifies the correct behavior of the FileManager
     *
     * @return void
     */
    public function testUpdateFiles()
    {
        $timeFormat = 'Y-m-d\TH:i:sP';

        $jsonData = '{
          "links": [
            {
              "$ref": "http://localhost/testcase/readonly/101",
              "type": "owner"
            },
            {
              "$ref": "http://localhost/testcase/readonly/102",
              "type": "module"
            }
          ],
          "metadata": {
            "action":[{"command":"print"},{"command":"archive"}]
          }
        }';

        copy(__DIR__ . '/Fixtures/test.txt', sys_get_temp_dir() . '/test.txt');
        $file = sys_get_temp_dir() . '/test.txt';
        $uploadedFile = new UploadedFile($file, 'test.txt', 'text/plain', 15);
        $client = $this->createClient();
        $client->request(
            'POST',
            '/file',
            [
                'metadata' => $jsonData,
            ],
            [
                'upload' => $uploadedFile,
            ]
        );
        $response = $client->getResponse();
        $location = $response->headers->get('location');

        $this->assertEquals(Response::HTTP_CREATED, $response->getStatusCode());
        $this->assertContains('/file/', $location);

        // receive generated file information
        $client = $this->createClient();
        $client->request('GET', $location, [], [], ['HTTP_ACCEPT' => 'application/json']);

        $response = $client->getResponse();
        $contentArray = json_decode($response->getContent(), true);

        // Check contain data
        $this->assertArrayHasKey('modificationDate', $contentArray['metadata']);
        $this->assertArrayHasKey('createDate', $contentArray['metadata']);
        // Test Metadata, and Remove date.
        $originalAt = \DateTime::createFromFormat($timeFormat, $contentArray['metadata']['modificationDate']);
        unset($contentArray['metadata']['modificationDate']);
        unset($contentArray['metadata']['createDate']);

        // PUT Lets UPDATE some additional Params
        $client = $this->createClient();
        $value = new \stdClass();
        $value->name = 'aField';
        $value->value = 'aValue';
        $contentArray['metadata']['additionalProperties'] = [$value];
        sleep(1);
        $client->request(
            'PUT',
            $location,
            [
                'metadata' => json_encode($contentArray),
            ]
        );
        $response = $client->getResponse();
        $this->assertEquals(Response::HTTP_NO_CONTENT, $response->getStatusCode());

        $client = $this->createClient();
        $client->request('GET', $location, [], [], ['HTTP_ACCEPT' => 'application/json']);

        $response = $client->getResponse();
        $contentUpdatedArray = json_decode($response->getContent(), true);
        $modifiedAt = \DateTime::createFromFormat($timeFormat, $contentUpdatedArray['metadata']['modificationDate']);

        $this->assertTrue($modifiedAt > $originalAt, 'File put should have changed modification date and did not');


        // PATCH Lets patch, and time should be changed
        $value->value = 'bValue';
        $patchJson = json_encode(
            array(
                'op' => 'replace',
                'path' => '/metadata/additionalProperties',
                'value' => [$value]
            )
        );
        sleep(1);
        $client = $this->createClient();
        $client->request('PATCH', $location, array(), array(), array(), $patchJson);
        $response = $client->getResponse();
        $this->assertEquals(Response::HTTP_OK, $response->getStatusCode());

        $client->request('GET', $location, [], [], ['HTTP_ACCEPT' => 'application/json']);
        $response = $client->getResponse();
        $contentPatchedArray = json_decode($response->getContent(), true);
        $pacthedAt = \DateTime::createFromFormat($timeFormat, $contentPatchedArray['metadata']['modificationDate']);
        $this->assertTrue($pacthedAt > $modifiedAt, 'File patched should have changed modification date and did not');


        // clean up
        $client = $this->createClient();
        $client->request(
            'DELETE',
            $location
        );
    }
}


1		<?php
2		/**
3		* Test suite for the FileManager
4		*/
5
6		namespace Graviton\FileBundle\Tests;
7
8		use Graviton\FileBundle\FileManager;
9		use Graviton\TestBundle\Test\WebTestCase;
10		use Symfony\Component\HttpFoundation\File\UploadedFile;
11		use Symfony\Component\HttpFoundation\Response;
12
13		/**
14		* Basic functional test for /file
15		*
16		* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
17		* @license http://opensource.org/licenses/gpl-license.php GNU Public License
18		* @link http://swisscom.ch
19		*/
20		class FileManagerTest extends WebTestCase
21		{
22		/** @var \Gaufrette\Filesystem $fileSystem */
23		private $fileSystem;
24
25		/** @var \Graviton\FileBundle\FileDocumentFactory $fileDocumentFactory */
26		private $fileDocumentFactory;
27
28		/**
29		* Initiates mandatory properties
30		*
31		* @return void
32		*/
33		public function setUp()
34		{
35		$this->fileSystem = $this->getMockBuilder('\Gaufrette\Filesystem')
36		->disableOriginalConstructor()
37		->getMock();
38
39		$this->fileDocumentFactory = $this->getMockBuilder('\Graviton\FileBundle\FileDocumentFactory')
40		->getMock();
41		}
42
43		/**
44		* Verifies the correct behavior of has method
45		*
46		* @return void
47		*/
48	View Code Duplication	public function testHas()
		0 ignored issues – show Duplication introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		{
50		$this->fileSystem
		0 ignored issues – show Bug introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Gaufrette\Filesystem>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
51		->expects($this->once())
52		->method('has')
53		->willReturn(true);
54
55		$manager = new FileManager($this->fileSystem, $this->fileDocumentFactory);
56
57		$this->assertTrue($manager->has('myKey'));
58		}
59
60		/**
61		* Verifies the correct behavior of read method
62		*
63		* @return void
64		*/
65	View Code Duplication	public function testRead()
		0 ignored issues – show Duplication introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		{
67		$this->fileSystem
		0 ignored issues – show Bug introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Gaufrette\Filesystem>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
68		->expects($this->once())
69		->method('read')
70		->willReturn('myData');
71
72		$manager = new FileManager($this->fileSystem, $this->fileDocumentFactory);
73
74		$this->assertEquals('myData', $manager->read('myKey'));
75		}
76
77		/**
78		* Verifies the correct behavior of read method
79		*
80		* @return void
81		*/
82	View Code Duplication	public function testDelete()
		0 ignored issues – show Duplication introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83		{
84		$this->fileSystem
		0 ignored issues – show Bug introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Gaufrette\Filesystem>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
85		->expects($this->once())
86		->method('delete')
87		->willReturn(true);
88
89		$manager = new FileManager($this->fileSystem, $this->fileDocumentFactory);
90
91		$this->assertTrue($manager->delete('myKey'));
92		}
93
94		/**
95		* Verifies the correct behavior of the FileManager
96		*
97		* @return void
98		*/
99		public function testSaveFiles()
100		{
101		$jsonData = '{
102		"links": [
103		{
104		"$ref": "http://localhost/testcase/readonly/101",
105		"type": "owner"
106		},
107		{
108		"$ref": "http://localhost/testcase/readonly/102",
109		"type": "module"
110		}
111		],
112		"metadata": {
113		"action":[{"command":"print"},{"command":"archive"}]
114		}
115		}';
116
117		copy(__DIR__ . '/Fixtures/test.txt', sys_get_temp_dir() . '/test.txt');
118		$file = sys_get_temp_dir() . '/test.txt';
119		$uploadedFile = new UploadedFile($file, 'test.txt', 'text/plain', 15);
120		$client = $this->createClient();
121		$client->request(
122		'POST',
123		'/file',
124		[
125		'metadata' => $jsonData,
126		],
127		[
128		'upload' => $uploadedFile,
129		]
130		);
131		$response = $client->getResponse();
132		$location = $response->headers->get('location');
133
134		$this->assertEquals(Response::HTTP_CREATED, $response->getStatusCode());
135		$this->assertContains('/file/', $location);
136
137		// receive generated file information
138		$client = $this->createClient();
139		$client->request(
140		'GET',
141		$location,
142		[],
143		[],
144		[
145		'HTTP_ACCEPT' => 'application/json'
146		]
147		);
148
149		$response = $client->getResponse();
150		$contentArray = json_decode($response->getContent(), true);
151
152		$this->assertEquals([["command" => "print"], ["command" => "archive"]], $contentArray['metadata']['action']);
153		$this->assertJsonStringEqualsJsonString(
154		'[
155		{
156		"$ref": "http://localhost/testcase/readonly/101",
157		"type": "owner"
158		},
159		{
160		"$ref": "http://localhost/testcase/readonly/102",
161		"type": "module"
162		}
163		]',
164		json_encode($contentArray['links'])
165		);
166
167		// Check contain data
168		$this->assertArrayHasKey('modificationDate', $contentArray['metadata']);
169		$this->assertArrayHasKey('createDate', $contentArray['metadata']);
170
171		// Test Metadata, and Remove date.
172		unset($contentArray['metadata']['modificationDate']);
173		unset($contentArray['metadata']['createDate']);
174
175		$this->assertJsonStringEqualsJsonString(
176		'{
177		"size":16,
178		"action":[
179		{"command":"print"},
180		{"command":"archive"}
181		],
182		"mime":"text\/plain",
183		"filename":"test.txt",
184		"hash":"4f3cbec0e58903d8bdcbd03d283cf43ed49a95d8d8b341ee38c0ba085204e2d5",
185		"additionalProperties":[]
186		}',
187		json_encode($contentArray['metadata'])
188		);
189
190		// clean up
191		$client = $this->createClient();
192		$client->request(
193		'DELETE',
194		$location
195		);
196		}
197
198
199		/**
200		* Verifies the correct behavior of the FileManager
201		*
202		* @return void
203		*/
204		public function testUpdateFiles()
205		{
206		$timeFormat = 'Y-m-d\TH:i:sP';
207
208		$jsonData = '{
209		"links": [
210		{
211		"$ref": "http://localhost/testcase/readonly/101",
212		"type": "owner"
213		},
214		{
215		"$ref": "http://localhost/testcase/readonly/102",
216		"type": "module"
217		}
218		],
219		"metadata": {
220		"action":[{"command":"print"},{"command":"archive"}]
221		}
222		}';
223
224		copy(__DIR__ . '/Fixtures/test.txt', sys_get_temp_dir() . '/test.txt');
225		$file = sys_get_temp_dir() . '/test.txt';
226		$uploadedFile = new UploadedFile($file, 'test.txt', 'text/plain', 15);
227		$client = $this->createClient();
228		$client->request(
229		'POST',
230		'/file',
231		[
232		'metadata' => $jsonData,
233		],
234		[
235		'upload' => $uploadedFile,
236		]
237		);
238		$response = $client->getResponse();
239		$location = $response->headers->get('location');
240
241		$this->assertEquals(Response::HTTP_CREATED, $response->getStatusCode());
242		$this->assertContains('/file/', $location);
243
244		// receive generated file information
245		$client = $this->createClient();
246		$client->request('GET', $location, [], [], ['HTTP_ACCEPT' => 'application/json']);
247
248		$response = $client->getResponse();
249		$contentArray = json_decode($response->getContent(), true);
250
251		// Check contain data
252		$this->assertArrayHasKey('modificationDate', $contentArray['metadata']);
253		$this->assertArrayHasKey('createDate', $contentArray['metadata']);
254		// Test Metadata, and Remove date.
255		$originalAt = \DateTime::createFromFormat($timeFormat, $contentArray['metadata']['modificationDate']);
256		unset($contentArray['metadata']['modificationDate']);
257		unset($contentArray['metadata']['createDate']);
258
259		// PUT Lets UPDATE some additional Params
260		$client = $this->createClient();
261		$value = new \stdClass();
262		$value->name = 'aField';
263		$value->value = 'aValue';
264		$contentArray['metadata']['additionalProperties'] = [$value];
265		sleep(1);
266		$client->request(
267		'PUT',
268		$location,
269		[
270		'metadata' => json_encode($contentArray),
271		]
272		);
273		$response = $client->getResponse();
274		$this->assertEquals(Response::HTTP_NO_CONTENT, $response->getStatusCode());
275
276		$client = $this->createClient();
277		$client->request('GET', $location, [], [], ['HTTP_ACCEPT' => 'application/json']);
278
279		$response = $client->getResponse();
280		$contentUpdatedArray = json_decode($response->getContent(), true);
281		$modifiedAt = \DateTime::createFromFormat($timeFormat, $contentUpdatedArray['metadata']['modificationDate']);
282
283		$this->assertTrue($modifiedAt > $originalAt, 'File put should have changed modification date and did not');
		0 ignored issues – show introduced 2016-11-02 14:50 UTC by Report Bug Copy Issue Report Instead of `assertTrue()` consider using `$this->assertGreaterThan...riginalAt, $modifiedAt)`. Loading history...
284
285		// PATCH Lets patch, and time should be changed
286		$value->value = 'bValue';
287		$patchJson = json_encode(
288		array(
289		'op' => 'replace',
290		'path' => '/metadata/additionalProperties',
291		'value' => [$value]
292		)
293		);
294		sleep(1);
295		$client = $this->createClient();
296		$client->request('PATCH', $location, array(), array(), array(), $patchJson);
297		$response = $client->getResponse();
298		$this->assertEquals(Response::HTTP_OK, $response->getStatusCode());
299
300		$client->request('GET', $location, [], [], ['HTTP_ACCEPT' => 'application/json']);
301		$response = $client->getResponse();
302		$contentPatchedArray = json_decode($response->getContent(), true);
303		$pacthedAt = \DateTime::createFromFormat($timeFormat, $contentPatchedArray['metadata']['modificationDate']);
304		$this->assertTrue($pacthedAt > $modifiedAt, 'File patched should have changed modification date and did not');
		0 ignored issues – show introduced 2016-11-02 14:50 UTC by Report Bug Copy Issue Report Instead of `assertTrue()` consider using `$this->assertGreaterThan($modifiedAt, $pacthedAt)`. Loading history...
305
306		// clean up
307		$client = $this->createClient();
308		$client->request(
309		'DELETE',
310		$location
311		);
312		}
313		}
314

libgraviton / graviton

Push — master ( 4d0d5e...a83342 )

FileManagerTest::testHas() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like