Completed
Pull Request — develop (#523)
by Bastian
09:09
created

MultiStrategyTest::setUp()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 22
Code Lines 14

Duplication

Lines 0
Ratio 0 %

Importance

Changes 2
Bugs 0 Features 0
Metric Value
dl 0
loc 22
rs 9.2
c 2
b 0
f 0
cc 1
eloc 14
nc 1
nop 0
1
<?php
2
/**
3
 * Handling authentication for clients in the same network.
4
 */
5
6
namespace Graviton\SecurityBundle\Authentication\Strategies;
7
8
use Graviton\TestBundle\Test\WebTestCase;
9
use Symfony\Component\BrowserKit\Cookie;
10
11
/**
12
 * Class MultiStrategyTest
13
 *
14
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
15
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
16
 * @link     http://swisscom.ch
17
 */
18
class MultiStrategyTest extends WebTestCase
19
{
20
    protected $strategy;
21
    protected $client;
22
    protected $propertyKey;
23
24
    /**
25
     * UnitTest Starts this on reach test
26
     * @return void
27
     */
28
    public function setUp()
29
    {
30
        parent::setUp();
31
32
        /** @var \Symfony\Bundle\FrameworkBundle\Client client */
33
        $this->client = static::createClient();
34
        $propertyKey = $this->client->getKernel()
35
            ->getContainer()
36
            ->getParameter('graviton.security.authentication.strategy.subnet.key');
37
        $sameSubnetStrategy = new SameSubnetStrategy($propertyKey);
38
        $this->propertyKey = $this->client->getKernel()
39
            ->getContainer()
40
            ->getParameter('graviton.security.authentication.strategy.cookie.key');
41
        $cookieFieldStrategy = new CookieFieldStrategy($this->propertyKey);
42
43
        $this->strategy = new MultiStrategy(
44
            [
45
                $sameSubnetStrategy,
46
                $cookieFieldStrategy,
47
            ]
48
        );
49
    }
50
51
    /**
52
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\MultiStrategy::apply
53
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::extractFieldInfo
54
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::validateField
55
     *
56
     * @return void
57
     */
58 View Code Duplication
    public function testApply()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
59
    {
60
        $fieldValue = 'exampleAuthenticationHeader';
61
62
        $cookie = new Cookie(
63
            $this->propertyKey,
64
            $fieldValue,
65
            time() + 3600 * 24 * 7,
66
            '/',
67
            null,
68
            false,
69
            false
70
        );
71
        $this->client->getCookieJar()->set($cookie);
72
        $this->client->request(
73
            'GET', //method
74
            '/', //uri
75
            array(), //parameters
76
            array(), //files
77
            array() //server
78
        );
79
80
        $this->assertSame($fieldValue, $this->strategy->apply($this->client->getRequest()));
0 ignored issues
show
Documentation introduced by
$this->client->getRequest() is of type object|null, but the function expects a object<Symfony\Component\HttpFoundation\Request>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
81
    }
82
}
83