EmbedHashTest::testInvalid() - Code Metrics - Inspection of "update test services dep; accept @mrix 's required..." - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/other-validation ( 01c6ab...a6eaef )

by Narcotic

created 2016-06-17 08:14 UTC

EmbedHashTest::testInvalid() A

↳ Parent: EmbedHashTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	12
loc	12
rs	9.4285
cc	2
eloc	7
nc	2
nop	2

<?php
/**
 * EmbedHashTest class file
 */

namespace Graviton\CoreBundle\Tests\Controller;

use Graviton\TestBundle\Test\RestTestCase;
use Symfony\Component\HttpFoundation\Response;

/**
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class EmbedHashTest extends RestTestCase
{
    /**
     * @param object $data JSON data
     * @return void
     *
     * @dataProvider dataValid
     * @group newEmbed
     * @group newEmbedValid
     * @group newEmbedHash
     * @group newEmbedHashValid
     */
    public function testValid($data)
    {
        $client = static::createRestClient();
        $client->post('/testcase/embed-hash/', $data);

        $this->assertEquals(Response::HTTP_CREATED, $client->getResponse()->getStatusCode());
    }

    /**
     * @return array

     */
    public function dataValid()
    {
        return [
            'all' => [
                (object) [
                    'value'         => 'value',
                    'defaultHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'defaultHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'defaultHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'defaultHash.subRequiredHash.value'],
                    ],
                    'optionalHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'optionalHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'optionalHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'optionalHash.subRequiredHash.value'],
                    ],
                    'requiredHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'requiredHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'requiredHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'requiredHash.subRequiredHash.value'],
                    ],
                ],
            ],
            'no optionalHash' => [
                (object) [
                    'value'         => 'value',
                    'defaultHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'defaultHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'defaultHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'defaultHash.subRequiredHash.value'],
                    ],
                    'requiredHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'requiredHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'requiredHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'requiredHash.subRequiredHash.value'],
                    ],
                ],
            ],
            'no subOptionalHash' => [
                (object) [
                    'value'         => 'value',
                    'defaultHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'defaultHash.subDefaultHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'defaultHash.subRequiredHash.value'],
                    ],
                    'optionalHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'optionalHash.subDefaultHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'optionalHash.subRequiredHash.value'],
                    ],
                    'requiredHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'requiredHash.subDefaultHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'requiredHash.subRequiredHash.value'],
                    ],
                ],
            ],
        ];
    }

    /**
     * @param object   $data   JSON data
     * @param object[] $errors Expected errors
     * @return void
     *
     * @dataProvider dataInvalid
     * @group newEmbed
     * @group newEmbedInvalid
     * @group newEmbedHash
     * @group newEmbedHashInvalid
     */
    public function testInvalid($data, array $errors)

    {
        $client = static::createRestClient();
        $client->post('/testcase/embed-hash/', $data);

        $this->assertEquals(Response::HTTP_BAD_REQUEST, $client->getResponse()->getStatusCode());
        $this->assertEquals(count($client->getResults()), count($errors));

        foreach ($errors as $error) {
            $this->assertContains($error, $client->getResults(), '', false, false);
        }
    }

    /**
     * @return array

     */
    public function dataInvalid()
    {
        return [
            'no value' => [
                (object) [
                    'defaultHash'   => (object) [
                        'subDefaultHash'    => (object) ['value' => 'defaultHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'defaultHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'defaultHash.subRequiredHash.value'],
                    ],
                    'optionalHash'   => (object) [
                        'subDefaultHash'    => (object) ['value' => 'optionalHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'optionalHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'optionalHash.subRequiredHash.value'],
                    ],
                    'requiredHash'   => (object) [
                        'subDefaultHash'    => (object) ['value' => 'requiredHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'requiredHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'requiredHash.subRequiredHash.value'],
                    ],
                ],
                [
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'defaultHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'optionalHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'requiredHash.value',
                    ],
                ],
            ],
            'no value at all' => [
                (object) [
                    'defaultHash'   => (object) [
                        'subDefaultHash'    => (object) [],
                        'subOptionalHash'   => (object) [],
                        'subRequiredHash'   => (object) [],
                    ],
                    'optionalHash'   => (object) [
                        'subDefaultHash'    => (object) [],
                        'subOptionalHash'   => (object) [],
                        'subRequiredHash'   => (object) [],
                    ],
                    'requiredHash'   => (object) [
                        'subDefaultHash'    => (object) [],
                        'subOptionalHash'   => (object) [],
                        'subRequiredHash'   => (object) [],
                    ],
                ],
                [
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'value',
                    ],

                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'defaultHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'defaultHash.subDefaultHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'defaultHash.subOptionalHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'defaultHash.subRequiredHash.value',
                    ],

                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'optionalHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'optionalHash.subDefaultHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'optionalHash.subOptionalHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'optionalHash.subRequiredHash.value',
                    ],

                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'requiredHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'requiredHash.subDefaultHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'requiredHash.subOptionalHash.value',
                    ],
                    (object) [
                        'message'       => 'The property value is required',
                        'propertyPath'  => 'requiredHash.subRequiredHash.value',
                    ],
                ],
            ],
            'no requiredHash' => [
                (object) [
                    'value'         => 'value',
                    'defaultHash'   => (object) [
                        'value'             => 'defaultHash.value',
                        'subDefaultHash'    => (object) ['value' => 'defaultHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'defaultHash.subOptionalHash.value'],
                    ],
                    'optionalHash'   => (object) [
                        'value'             => 'optionalHash.value',
                        'subDefaultHash'    => (object) ['value' => 'optionalHash.subDefaultHash.value'],
                        'subOptionalHash'   => (object) ['value' => 'optionalHash.subOptionalHash.value'],
                    ],
                ],
                [
                    (object) [
                        'message'       => 'The property requiredHash is required',
                        'propertyPath'  => 'requiredHash',
                    ],
                    (object) [
                        'message'       => 'The property subRequiredHash is required',
                        'propertyPath'  => 'defaultHash.subRequiredHash',
                    ],
                    (object) [
                        'message'       => 'The property subRequiredHash is required',
                        'propertyPath'  => 'optionalHash.subRequiredHash',
                    ],
                ],
            ],
            'no defaultHash' => [
                (object) [
                    'value'         => 'value',
                    'optionalHash'   => (object) [
                        'value'             => 'optionalHash.value',
                        'subOptionalHash'   => (object) ['value' => 'optionalHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'optionalHash.subRequiredHash.value'],
                    ],
                    'requiredHash'   => (object) [
                        'value'             => 'requiredHash.value',
                        'subOptionalHash'   => (object) ['value' => 'requiredHash.subOptionalHash.value'],
                        'subRequiredHash'   => (object) ['value' => 'requiredHash.subRequiredHash.value'],
                    ],
                ],
                [
                    (object) [
                        'message'       => 'The property defaultHash is required',
                        'propertyPath'  => 'defaultHash',
                    ],
                    (object) [
                        'message'       => 'The property subDefaultHash is required',
                        'propertyPath'  => 'optionalHash.subDefaultHash',
                    ],
                    (object) [
                        'message'       => 'The property subDefaultHash is required',
                        'propertyPath'  => 'requiredHash.subDefaultHash',
                    ],
                ],
            ],
        ];
    }
}


1		<?php
2		/**
3		* EmbedHashTest class file
4		*/
5
6		namespace Graviton\CoreBundle\Tests\Controller;
7
8		use Graviton\TestBundle\Test\RestTestCase;
9		use Symfony\Component\HttpFoundation\Response;
10
11		/**
12		* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
13		* @license http://opensource.org/licenses/gpl-license.php GNU Public License
14		* @link http://swisscom.ch
15		*/
16		class EmbedHashTest extends RestTestCase
17		{
18		/**
19		* @param object $data JSON data
20		* @return void
21		*
22		* @dataProvider dataValid
23		* @group newEmbed
24		* @group newEmbedValid
25		* @group newEmbedHash
26		* @group newEmbedHashValid
27		*/
28		public function testValid($data)
29		{
30		$client = static::createRestClient();
31		$client->post('/testcase/embed-hash/', $data);
32
33		$this->assertEquals(Response::HTTP_CREATED, $client->getResponse()->getStatusCode());
34		}
35
36		/**
37		* @return array
		1 ignored issue – show Documentation introduced 2016-06-17 08:23 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<string,array>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
38		*/
39		public function dataValid()
40		{
41		return [
42		'all' => [
43		(object) [
44		'value' => 'value',
45		'defaultHash' => (object) [
46		'value' => 'defaultHash.value',
47		'subDefaultHash' => (object) ['value' => 'defaultHash.subDefaultHash.value'],
48		'subOptionalHash' => (object) ['value' => 'defaultHash.subOptionalHash.value'],
49		'subRequiredHash' => (object) ['value' => 'defaultHash.subRequiredHash.value'],
50		],
51		'optionalHash' => (object) [
52		'value' => 'defaultHash.value',
53		'subDefaultHash' => (object) ['value' => 'optionalHash.subDefaultHash.value'],
54		'subOptionalHash' => (object) ['value' => 'optionalHash.subOptionalHash.value'],
55		'subRequiredHash' => (object) ['value' => 'optionalHash.subRequiredHash.value'],
56		],
57		'requiredHash' => (object) [
58		'value' => 'defaultHash.value',
59		'subDefaultHash' => (object) ['value' => 'requiredHash.subDefaultHash.value'],
60		'subOptionalHash' => (object) ['value' => 'requiredHash.subOptionalHash.value'],
61		'subRequiredHash' => (object) ['value' => 'requiredHash.subRequiredHash.value'],
62		],
63		],
64		],
65		'no optionalHash' => [
66		(object) [
67		'value' => 'value',
68		'defaultHash' => (object) [
69		'value' => 'defaultHash.value',
70		'subDefaultHash' => (object) ['value' => 'defaultHash.subDefaultHash.value'],
71		'subOptionalHash' => (object) ['value' => 'defaultHash.subOptionalHash.value'],
72		'subRequiredHash' => (object) ['value' => 'defaultHash.subRequiredHash.value'],
73		],
74		'requiredHash' => (object) [
75		'value' => 'defaultHash.value',
76		'subDefaultHash' => (object) ['value' => 'requiredHash.subDefaultHash.value'],
77		'subOptionalHash' => (object) ['value' => 'requiredHash.subOptionalHash.value'],
78		'subRequiredHash' => (object) ['value' => 'requiredHash.subRequiredHash.value'],
79		],
80		],
81		],
82		'no subOptionalHash' => [
83		(object) [
84		'value' => 'value',
85		'defaultHash' => (object) [
86		'value' => 'defaultHash.value',
87		'subDefaultHash' => (object) ['value' => 'defaultHash.subDefaultHash.value'],
88		'subRequiredHash' => (object) ['value' => 'defaultHash.subRequiredHash.value'],
89		],
90		'optionalHash' => (object) [
91		'value' => 'defaultHash.value',
92		'subDefaultHash' => (object) ['value' => 'optionalHash.subDefaultHash.value'],
93		'subRequiredHash' => (object) ['value' => 'optionalHash.subRequiredHash.value'],
94		],
95		'requiredHash' => (object) [
96		'value' => 'defaultHash.value',
97		'subDefaultHash' => (object) ['value' => 'requiredHash.subDefaultHash.value'],
98		'subRequiredHash' => (object) ['value' => 'requiredHash.subRequiredHash.value'],
99		],
100		],
101		],
102		];
103		}
104
105		/**
106		* @param object $data JSON data
107		* @param object[] $errors Expected errors
108		* @return void
109		*
110		* @dataProvider dataInvalid
111		* @group newEmbed
112		* @group newEmbedInvalid
113		* @group newEmbedHash
114		* @group newEmbedHashInvalid
115		*/
116	View Code Duplication	public function testInvalid($data, array $errors)
		1 ignored issue – show Duplication introduced 2016-06-17 08:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
117		{
118		$client = static::createRestClient();
119		$client->post('/testcase/embed-hash/', $data);
120
121		$this->assertEquals(Response::HTTP_BAD_REQUEST, $client->getResponse()->getStatusCode());
122		$this->assertEquals(count($client->getResults()), count($errors));
123
124		foreach ($errors as $error) {
125		$this->assertContains($error, $client->getResults(), '', false, false);
126		}
127		}
128
129		/**
130		* @return array
		1 ignored issue – show Documentation introduced 2016-06-17 08:23 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<string,array[]>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
131		*/
132		public function dataInvalid()
133		{
134		return [
135		'no value' => [
136		(object) [
137		'defaultHash' => (object) [
138		'subDefaultHash' => (object) ['value' => 'defaultHash.subDefaultHash.value'],
139		'subOptionalHash' => (object) ['value' => 'defaultHash.subOptionalHash.value'],
140		'subRequiredHash' => (object) ['value' => 'defaultHash.subRequiredHash.value'],
141		],
142		'optionalHash' => (object) [
143		'subDefaultHash' => (object) ['value' => 'optionalHash.subDefaultHash.value'],
144		'subOptionalHash' => (object) ['value' => 'optionalHash.subOptionalHash.value'],
145		'subRequiredHash' => (object) ['value' => 'optionalHash.subRequiredHash.value'],
146		],
147		'requiredHash' => (object) [
148		'subDefaultHash' => (object) ['value' => 'requiredHash.subDefaultHash.value'],
149		'subOptionalHash' => (object) ['value' => 'requiredHash.subOptionalHash.value'],
150		'subRequiredHash' => (object) ['value' => 'requiredHash.subRequiredHash.value'],
151		],
152		],
153		[
154		(object) [
155		'message' => 'The property value is required',
156		'propertyPath' => 'value',
157		],
158		(object) [
159		'message' => 'The property value is required',
160		'propertyPath' => 'defaultHash.value',
161		],
162		(object) [
163		'message' => 'The property value is required',
164		'propertyPath' => 'optionalHash.value',
165		],
166		(object) [
167		'message' => 'The property value is required',
168		'propertyPath' => 'requiredHash.value',
169		],
170		],
171		],
172		'no value at all' => [
173		(object) [
174		'defaultHash' => (object) [
175		'subDefaultHash' => (object) [],
176		'subOptionalHash' => (object) [],
177		'subRequiredHash' => (object) [],
178		],
179		'optionalHash' => (object) [
180		'subDefaultHash' => (object) [],
181		'subOptionalHash' => (object) [],
182		'subRequiredHash' => (object) [],
183		],
184		'requiredHash' => (object) [
185		'subDefaultHash' => (object) [],
186		'subOptionalHash' => (object) [],
187		'subRequiredHash' => (object) [],
188		],
189		],
190		[
191		(object) [
192		'message' => 'The property value is required',
193		'propertyPath' => 'value',
194		],
195
196		(object) [
197		'message' => 'The property value is required',
198		'propertyPath' => 'defaultHash.value',
199		],
200		(object) [
201		'message' => 'The property value is required',
202		'propertyPath' => 'defaultHash.subDefaultHash.value',
203		],
204		(object) [
205		'message' => 'The property value is required',
206		'propertyPath' => 'defaultHash.subOptionalHash.value',
207		],
208		(object) [
209		'message' => 'The property value is required',
210		'propertyPath' => 'defaultHash.subRequiredHash.value',
211		],
212
213		(object) [
214		'message' => 'The property value is required',
215		'propertyPath' => 'optionalHash.value',
216		],
217		(object) [
218		'message' => 'The property value is required',
219		'propertyPath' => 'optionalHash.subDefaultHash.value',
220		],
221		(object) [
222		'message' => 'The property value is required',
223		'propertyPath' => 'optionalHash.subOptionalHash.value',
224		],
225		(object) [
226		'message' => 'The property value is required',
227		'propertyPath' => 'optionalHash.subRequiredHash.value',
228		],
229
230		(object) [
231		'message' => 'The property value is required',
232		'propertyPath' => 'requiredHash.value',
233		],
234		(object) [
235		'message' => 'The property value is required',
236		'propertyPath' => 'requiredHash.subDefaultHash.value',
237		],
238		(object) [
239		'message' => 'The property value is required',
240		'propertyPath' => 'requiredHash.subOptionalHash.value',
241		],
242		(object) [
243		'message' => 'The property value is required',
244		'propertyPath' => 'requiredHash.subRequiredHash.value',
245		],
246		],
247		],
248		'no requiredHash' => [
249		(object) [
250		'value' => 'value',
251		'defaultHash' => (object) [
252		'value' => 'defaultHash.value',
253		'subDefaultHash' => (object) ['value' => 'defaultHash.subDefaultHash.value'],
254		'subOptionalHash' => (object) ['value' => 'defaultHash.subOptionalHash.value'],
255		],
256		'optionalHash' => (object) [
257		'value' => 'optionalHash.value',
258		'subDefaultHash' => (object) ['value' => 'optionalHash.subDefaultHash.value'],
259		'subOptionalHash' => (object) ['value' => 'optionalHash.subOptionalHash.value'],
260		],
261		],
262		[
263		(object) [
264		'message' => 'The property requiredHash is required',
265		'propertyPath' => 'requiredHash',
266		],
267		(object) [
268		'message' => 'The property subRequiredHash is required',
269		'propertyPath' => 'defaultHash.subRequiredHash',
270		],
271		(object) [
272		'message' => 'The property subRequiredHash is required',
273		'propertyPath' => 'optionalHash.subRequiredHash',
274		],
275		],
276		],
277		'no defaultHash' => [
278		(object) [
279		'value' => 'value',
280		'optionalHash' => (object) [
281		'value' => 'optionalHash.value',
282		'subOptionalHash' => (object) ['value' => 'optionalHash.subOptionalHash.value'],
283		'subRequiredHash' => (object) ['value' => 'optionalHash.subRequiredHash.value'],
284		],
285		'requiredHash' => (object) [
286		'value' => 'requiredHash.value',
287		'subOptionalHash' => (object) ['value' => 'requiredHash.subOptionalHash.value'],
288		'subRequiredHash' => (object) ['value' => 'requiredHash.subRequiredHash.value'],
289		],
290		],
291		[
292		(object) [
293		'message' => 'The property defaultHash is required',
294		'propertyPath' => 'defaultHash',
295		],
296		(object) [
297		'message' => 'The property subDefaultHash is required',
298		'propertyPath' => 'optionalHash.subDefaultHash',
299		],
300		(object) [
301		'message' => 'The property subDefaultHash is required',
302		'propertyPath' => 'requiredHash.subDefaultHash',
303		],
304		],
305		],
306		];
307		}
308		}
309

libgraviton / graviton

Push — feature/other-validation ( 01c6ab...a6eaef )

EmbedHashTest::testInvalid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like