Graviton\ProxyApiBundle\Processor\PreProcessor::process()

Complexity

Conditions	7
Paths	10

Size

Total Lines	34
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

0

<?php
    public function process(
        Request $originalRequest,
        HttpHelper $httpHelper,
        ProxyModel $proxyModel
    ) {
        $httpHelper->setMethod($originalRequest->getMethod());

        $queryParams = (array) $originalRequest->query->all();

        // Query Params, it will remove unwanted params and map to new.
        if ($optParams = $proxyModel->getQueryParams()) {
            $newParamsString = http_build_query($optParams);
            foreach ($queryParams as $key => $value) {
                // Remove attempt to inject with %26 = & in value.
                $value = strpos($value, '&') !== false ? strstr($value, '&', true) : $value;
                $newParamsString = str_replace('%7B'.$key.'%7D', trim($value), $newParamsString);
            }
            parse_str($newParamsString, $queryParams);
        }

        // Map additional params, append additional params
        if ($optParams = $proxyModel->getQueryAdditionals()) {
            foreach ($optParams as $key => $value) {
                $queryParams[$key] = $value;
            }
        }

        // Add to HTTP Query Params
        foreach ($queryParams as $name => $value) {

The expression $queryParams of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            $httpHelper->addQueryParams($name, $value);
        }

        return $httpHelper;
    }
}