DefaultController::optionsAction() - Code Metrics - Inspection of "Implementation of Proxy, extendable by service" - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#605)

unknown

created 2017-09-19 08:26 UTC

DefaultController::optionsAction() A

↳ Parent: DefaultController

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	7
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	7
loc	7
ccs	0
cts	7
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0
crap	2

<?php
/**
 * Entry point controller.
 */
namespace Graviton\ProxyApiBundle\Controller;

use Graviton\ProxyApiBundle\Manager\ServiceManager;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Response;

/**
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class DefaultController

{
    /** @var ServiceManager */
    private $serviceManager;

    /**
     * DefaultController constructor.
     * @param ServiceManager $serviceManager Parsing the requested date
     */
    public function __construct(
        ServiceManager $serviceManager
    ) {
        $this->serviceManager = $serviceManager;
    }

    /**
     * @return JsonResponse
     */
    public function indexAction()
    {

        $data = $this->serviceManager->getServices();

        return new JsonResponse($data);
    }

    /**
     * @return Response
     */
    public function optionsAction()
    {
        $resp = new Response();
        $resp->setStatusCode(Response::HTTP_NO_CONTENT);
        $resp->headers->set("Access-Control-Allow-Methods", "GET, OPTIONS, POST");
        return $resp;
    }

    /**
     * @return Response
     */
    public function proxyAction()
    {
        return $this->serviceManager->processRequest();
    }

    /**
     * @return JsonResponse
     */
    public function schemaAction()
    {
        $data = $this->serviceManager->getSchema();


        return new JsonResponse($data);
    }
}


1		<?php
2		/**
3		* Entry point controller.
4		*/
5		namespace Graviton\ProxyApiBundle\Controller;
6
7		use Graviton\ProxyApiBundle\Manager\ServiceManager;
8		use Symfony\Component\HttpFoundation\JsonResponse;
9		use Symfony\Component\HttpFoundation\Response;
10
11		/**
12		* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
13		* @license http://opensource.org/licenses/gpl-license.php GNU Public License
14		* @link http://swisscom.ch
15		*/
16	View Code Duplication	class DefaultController
		0 ignored issues – show Duplication introduced 2017-09-14 17:10 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		/** @var ServiceManager */
19		private $serviceManager;
20
21		/**
22		* DefaultController constructor.
23		* @param ServiceManager $serviceManager Parsing the requested date
24		*/
25		public function __construct(
26		ServiceManager $serviceManager
27		) {
28		$this->serviceManager = $serviceManager;
29		}
30
31		/**
32		* @return JsonResponse
33		*/
34		public function indexAction()
35		{
36
37		$data = $this->serviceManager->getServices();
38
39		return new JsonResponse($data);
40		}
41
42		/**
43		* @return Response
44		*/
45		public function optionsAction()
46		{
47		$resp = new Response();
48		$resp->setStatusCode(Response::HTTP_NO_CONTENT);
49		$resp->headers->set("Access-Control-Allow-Methods", "GET, OPTIONS, POST");
50		return $resp;
51		}
52
53		/**
54		* @return Response
55		*/
56		public function proxyAction()
57		{
58		return $this->serviceManager->processRequest();
59		}
60
61		/**
62		* @return JsonResponse
63		*/
64		public function schemaAction()
65		{
66		$data = $this->serviceManager->getSchema();
		0 ignored issues – show Bug introduced 2017-09-14 17:10 UTC by Report Bug Copy Issue Report The method `getSchema()` does not seem to exist on `object<Graviton\ProxyApi...Manager\ServiceManager>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
67
68		return new JsonResponse($data);
69		}
70		}
71

libgraviton / graviton

Pull Request — develop (#605)

DefaultController::optionsAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like