SameSubnetStrategyTest::testApply() - Code Metrics - Inspection of "Use of Multi Strategy in Auth Service" - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/EVO-6305_worker_authen... ( 9fae6b )

unknown

created 2016-11-14 09:30 UTC

SameSubnetStrategyTest::testApply() A

↳ Parent: SameSubnetStrategyTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0

<?php
/**
 * Handling authentication for clients in the same network.
 */

namespace Graviton\SecurityBundle\Authentication\Strategies;

use Graviton\TestBundle\Test\WebTestCase;
use Symfony\Component\BrowserKit\Cookie;

/**
 * Class SameSubnetStrategyTest
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class SameSubnetStrategyTest extends WebTestCase
{
    protected $strategy;
    protected $client;
    protected $propertyKey;

    /**
     * UnitTest Starts this on reach test
     * @return void
     */
    public function setUp()

    {
        parent::setUp();

        /** @var \Symfony\Bundle\FrameworkBundle\Client client */
        $this->client = static::createClient();
        $this->propertyKey = $this->client->getKernel()
            ->getContainer()
            ->getParameter('graviton.security.authentication.strategy.subnet.key');
        $this->strategy = new SameSubnetStrategy(
            $this->propertyKey
        );
    }

    /**
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\SameSubnetStrategy::apply
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::extractFieldInfo
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::validateField
     *
     * @return void
     */
    public function testApply()
    {
        $this->client->request(
            'GET', //method
            '/', //uri
            array(), //parameters
            array(), //files
            array() //server
        );

        $this->assertSame('graviton_subnet_user', $this->strategy->apply($this->client->getRequest()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\SameSubnetStrategy::apply
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::extractFieldInfo
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::validateField
     *
     * @return void
     */
    public function testApplyExpectingInvalidArgumentException()
    {
        $this->client->request(
            'GET', //method
            '/', //uri
            array(), //parameters
            array(), //files
            array() //server
        );

        $strategy = new SameSubnetStrategy('10.2.0.2');

        $this->setExpectedException('\InvalidArgumentException');

        $strategy->apply($this->client->getRequest());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2		/**
3		* Handling authentication for clients in the same network.
4		*/
5
6		namespace Graviton\SecurityBundle\Authentication\Strategies;
7
8		use Graviton\TestBundle\Test\WebTestCase;
9		use Symfony\Component\BrowserKit\Cookie;
10
11		/**
12		* Class SameSubnetStrategyTest
13		*
14		* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
15		* @license http://opensource.org/licenses/gpl-license.php GNU Public License
16		* @link http://swisscom.ch
17		*/
18		class SameSubnetStrategyTest extends WebTestCase
19		{
20		protected $strategy;
21		protected $client;
22		protected $propertyKey;
23
24		/**
25		* UnitTest Starts this on reach test
26		* @return void
27		*/
28	View Code Duplication	public function setUp()
		0 ignored issues – show Duplication introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		parent::setUp();
31
32		/** @var \Symfony\Bundle\FrameworkBundle\Client client */
33		$this->client = static::createClient();
34		$this->propertyKey = $this->client->getKernel()
35		->getContainer()
36		->getParameter('graviton.security.authentication.strategy.subnet.key');
37		$this->strategy = new SameSubnetStrategy(
38		$this->propertyKey
39		);
40		}
41
42		/**
43		* @covers \Graviton\SecurityBundle\Authentication\Strategies\SameSubnetStrategy::apply
44		* @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::extractFieldInfo
45		* @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::validateField
46		*
47		* @return void
48		*/
49		public function testApply()
50		{
51		$this->client->request(
52		'GET', //method
53		'/', //uri
54		array(), //parameters
55		array(), //files
56		array() //server
57		);
58
59		$this->assertSame('graviton_subnet_user', $this->strategy->apply($this->client->getRequest()));
		0 ignored issues – show Documentation introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report `$this->client->getRequest()` is of type `object\|null`, but the function expects a `object<Symfony\Component\HttpFoundation\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60		}
61
62		/**
63		* @covers \Graviton\SecurityBundle\Authentication\Strategies\SameSubnetStrategy::apply
64		* @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::extractFieldInfo
65		* @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::validateField
66		*
67		* @return void
68		*/
69		public function testApplyExpectingInvalidArgumentException()
70		{
71		$this->client->request(
72		'GET', //method
73		'/', //uri
74		array(), //parameters
75		array(), //files
76		array() //server
77		);
78
79		$strategy = new SameSubnetStrategy('10.2.0.2');
80
81		$this->setExpectedException('\InvalidArgumentException');
		0 ignored issues – show Deprecated Code introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
82		$strategy->apply($this->client->getRequest());
		0 ignored issues – show Documentation introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report `$this->client->getRequest()` is of type `object\|null`, but the function expects a `object<Symfony\Component\HttpFoundation\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
83		}
84		}
85

libgraviton / graviton

Push — feature/EVO-6305_worker_authen... ( 9fae6b )

SameSubnetStrategyTest::testApply() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like