SelectExclusionStrategy::shouldSkipProperty() - Code Metrics - Inspection of "EVO-7301 initial commit" - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — bugfix/EVO-7301 ( cec151 )

unknown

created 2016-09-19 11:56 UTC

SelectExclusionStrategy::shouldSkipProperty() B

↳ Parent: SelectExclusionStrategy

Complexity

Conditions	6
Paths	7

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	23
ccs	0
cts	15
cp	0
rs	8.5906
cc	6
eloc	15
nc	7
nop	2
crap	42

<?php
/**
 * Class for exclusion strategies.
 */
namespace Graviton\RestBundle\ExclusionStrategy;

use JMS\Serializer\Exclusion\ExclusionStrategyInterface;
use JMS\Serializer\Metadata\ClassMetadata;
use JMS\Serializer\Metadata\PropertyMetadata;
use JMS\Serializer\Context;

/**
 * In this Strategy we skip all properties on first level who are not selected if there is a select in rql.
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class SelectExclusionStrategy implements ExclusionStrategyInterface
{
    /**
     * @InheritDoc: Whether the class should be skipped.
     * @param ClassMetadata $metadata         blabla
     * @param Context       $navigatorContext blabla
     * @return boolean
     */
    public function shouldSkipClass(ClassMetadata $metadata, Context $navigatorContext)
    {
        return false;
    }

    /**
     * @InheritDoc: Whether the property should be skipped.
     * Skipping properties on first level who are not selected if there is a select in rql.
     * @param PropertyMetadata $property blabla
     * @param Context          $context  blabla
     * @return boolean
     */
    public function shouldSkipProperty(PropertyMetadata $property, Context $context)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // we are only dealing with the first level of the JSON here
        if ($context->getDepth() > 1) {
            return false;
        }

        $select = false;
        $selectVars=[];
        foreach ($_GET as $getVar => $val) {
            if (strstr($getVar, 'select(')) {
                preg_match('/\((.*?)\)/', $getVar, $match);
                $select = true;
                $selectVars = explode(',', $match[1]);
                break;
            }
        }
        if ($select && ! in_array($property->name, $selectVars)) {
            return true;
        } else {
            return false;
        }
    }
}


1			<?php
2			/**
3			* Class for exclusion strategies.
4			*/
5			namespace Graviton\RestBundle\ExclusionStrategy;
6
7			use JMS\Serializer\Exclusion\ExclusionStrategyInterface;
8			use JMS\Serializer\Metadata\ClassMetadata;
9			use JMS\Serializer\Metadata\PropertyMetadata;
10			use JMS\Serializer\Context;
11
12			/**
13			* In this Strategy we skip all properties on first level who are not selected if there is a select in rql.
14			*
15			* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
16			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
17			* @link http://swisscom.ch
18			*/
19			class SelectExclusionStrategy implements ExclusionStrategyInterface
20			{
21			/**
22			* @InheritDoc: Whether the class should be skipped.
23			* @param ClassMetadata $metadata blabla
24			* @param Context $navigatorContext blabla
25			* @return boolean
26			*/
27			public function shouldSkipClass(ClassMetadata $metadata, Context $navigatorContext)
28			{
29			return false;
30			}
31
32			/**
33			* @InheritDoc: Whether the property should be skipped.
34			* Skipping properties on first level who are not selected if there is a select in rql.
35			* @param PropertyMetadata $property blabla
36			* @param Context $context blabla
37			* @return boolean
38			*/
39			public function shouldSkipProperty(PropertyMetadata $property, Context $context)
			0 ignored issues – show Coding Style introduced 2016-09-19 12:15 UTC by Report Bug Copy Issue Report `shouldSkipProperty` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
40			{
41			// we are only dealing with the first level of the JSON here
42			if ($context->getDepth() > 1) {
43			return false;
44			}
45
46			$select = false;
47			$selectVars=[];
48			foreach ($_GET as $getVar => $val) {
49			if (strstr($getVar, 'select(')) {
50			preg_match('/\((.*?)\)/', $getVar, $match);
51			$select = true;
52			$selectVars = explode(',', $match[1]);
53			break;
54			}
55			}
56			if ($select && ! in_array($property->name, $selectVars)) {
57			return true;
58			} else {
59			return false;
60			}
61			}
62			}
63

libgraviton / graviton

Push — bugfix/EVO-7301 ( cec151 )

SelectExclusionStrategy::shouldSkipProperty() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like