MultiStrategyTest::testApply() - Code Metrics - Inspection of "Added tests for MultiStrategy" - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/EVO-6305_worker_authen... ( c61b56...244cb1 )

by Bastian

created 2016-11-09 19:46 UTC

MultiStrategyTest::testApply() B

↳ Parent: MultiStrategyTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	18

Duplication

Lines	24
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	24
loc	24
rs	8.9713
cc	1
eloc	18
nc	1
nop	0

<?php
/**
 * Handling authentication for clients in the same network.
 */

namespace Graviton\SecurityBundle\Authentication\Strategies;

use Graviton\TestBundle\Test\WebTestCase;
use Symfony\Component\BrowserKit\Cookie;

/**
 * Class MultiStrategyTest
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
    class MultiStrategyTest extends WebTestCase
{
    protected $strategy;
    protected $client;
    protected $propertyKey;

    /**
     * UnitTest Starts this on reach test
     * @return void
     */
    public function setUp()
    {
        parent::setUp();

        /** @var \Symfony\Bundle\FrameworkBundle\Client client */
        $this->client = static::createClient();
        $propertyKey = $this->client->getKernel()
            ->getContainer()
            ->getParameter('graviton.security.authentication.strategy.subnet.key');
        $SameSubnetStrategy = new SameSubnetStrategy(

            $propertyKey
        );
        $this->propertyKey = $this->client->getKernel()
            ->getContainer()
            ->getParameter('graviton.security.authentication.strategy.cookie.key');
        $CookieFieldStrategy = new CookieFieldStrategy(

            $this->propertyKey
        );

        $this->strategy = new MultiStrategy([
            $SameSubnetStrategy,

            $CookieFieldStrategy,

        ]);
    }

    /**
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\MultiStrategy::apply
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::extractFieldInfo
     * @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::validateField
     *
     * @return void
     */
    public function testApply()

    {
        $fieldValue = 'exampleAuthenticationHeader';

        $cookie = new Cookie(
            $this->propertyKey,
            $fieldValue,
            time() + 3600 * 24 * 7,
            '/',
            null,
            false,
            false
        );
        $this->client->getCookieJar()->set($cookie);
        $this->client->request(
            'GET', //method
            '/', //uri
            array(), //parameters
            array(), //files
            array() //server
        );

        $this->assertSame($fieldValue, $this->strategy->apply($this->client->getRequest()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}



1		<?php
2		/**
3		* Handling authentication for clients in the same network.
4		*/
5
6		namespace Graviton\SecurityBundle\Authentication\Strategies;
7
8		use Graviton\TestBundle\Test\WebTestCase;
9		use Symfony\Component\BrowserKit\Cookie;
10
11		/**
12		* Class MultiStrategyTest
13		*
14		* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
15		* @license http://opensource.org/licenses/gpl-license.php GNU Public License
16		* @link http://swisscom.ch
17		*/
18		class MultiStrategyTest extends WebTestCase
19		{
20		protected $strategy;
21		protected $client;
22		protected $propertyKey;
23
24		/**
25		* UnitTest Starts this on reach test
26		* @return void
27		*/
28		public function setUp()
29		{
30		parent::setUp();
31
32		/** @var \Symfony\Bundle\FrameworkBundle\Client client */
33		$this->client = static::createClient();
34		$propertyKey = $this->client->getKernel()
35		->getContainer()
36		->getParameter('graviton.security.authentication.strategy.subnet.key');
37		$SameSubnetStrategy = new SameSubnetStrategy(
		0 ignored issues – show Coding Style introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report `$SameSubnetStrategy` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
38		$propertyKey
39		);
40		$this->propertyKey = $this->client->getKernel()
41		->getContainer()
42		->getParameter('graviton.security.authentication.strategy.cookie.key');
43		$CookieFieldStrategy = new CookieFieldStrategy(
		0 ignored issues – show Coding Style introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report `$CookieFieldStrategy` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
44		$this->propertyKey
45		);
46
47		$this->strategy = new MultiStrategy([
48		$SameSubnetStrategy,
		0 ignored issues – show Coding Style introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report `$SameSubnetStrategy` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
49		$CookieFieldStrategy,
		0 ignored issues – show Coding Style introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report `$CookieFieldStrategy` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
50		]);
51		}
52
53		/**
54		* @covers \Graviton\SecurityBundle\Authentication\Strategies\MultiStrategy::apply
55		* @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::extractFieldInfo
56		* @covers \Graviton\SecurityBundle\Authentication\Strategies\AbstractHttpStrategy::validateField
57		*
58		* @return void
59		*/
60	View Code Duplication	public function testApply()
		0 ignored issues – show Duplication introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		$fieldValue = 'exampleAuthenticationHeader';
63
64		$cookie = new Cookie(
65		$this->propertyKey,
66		$fieldValue,
67		time() + 3600 * 24 * 7,
68		'/',
69		null,
70		false,
71		false
72		);
73		$this->client->getCookieJar()->set($cookie);
74		$this->client->request(
75		'GET', //method
76		'/', //uri
77		array(), //parameters
78		array(), //files
79		array() //server
80		);
81
82		$this->assertSame($fieldValue, $this->strategy->apply($this->client->getRequest()));
		0 ignored issues – show Documentation introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report `$this->client->getRequest()` is of type `object\|null`, but the function expects a `object<Symfony\Component\HttpFoundation\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
83		}
84		}
		0 ignored issues – show Coding Style introduced 2016-11-09 19:56 UTC by Report Bug Copy Issue Report Closing brace indented incorrectly; expected 4 spaces, found 0 Loading history...
85

libgraviton / graviton

Push — feature/EVO-6305_worker_authen... ( c61b56...244cb1 )

MultiStrategyTest::testApply() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like