MultiStrategy::apply() - Code Metrics - Inspection of "Remove Exception from Authentication" - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/no-exception-if-no-use... ( 196818 )

unknown

created 2017-10-12 14:58 UTC

MultiStrategy::apply() A

↳ Parent: MultiStrategy

Complexity

Conditions	4
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	0
cts	7
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	3
nop	1
crap	20

<?php
/**
 * strategy combining a set of strategies to be applied
 */

namespace Graviton\SecurityBundle\Authentication\Strategies;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Role\Role;

/**
 * Class MultiStrategy
 *
 * @package Graviton\SecurityBundle\Authentication\Strategies
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class MultiStrategy implements StrategyInterface
{
    /** @var StrategyInterface[]  */
    private $strategies;

    /** @var Role[] */
    private $roles= [];

    /**
     * MultiStrategy constructor.
     *
     * @param StrategyInterface[] $strategies List of strategies to be applied.
     */
    public function __construct(array $strategies)
    {
        $this->strategies = $strategies;
    }

    /**
     * Applies the defined strategies on the provided request.
     *
     * @param Request $request request to handle
     *
     * @return string

     */
    public function apply(Request $request)
    {
        foreach ($this->strategies as $strategy) {
            $name = $strategy->apply($request);
            $this->roles = $strategy->getRoles();

            if ($name && $strategy->stopPropagation()) {
                return $name;
            }
        }

        return false;
    }

    /**
     * Decider to stop other strategies running after from being considered.
     *
     * @return boolean
     */
    public function stopPropagation()
    {
        return false;
    }

    /**
     * Provides the list of registered roles.
     *
     * @return Role[]
     */
    public function getRoles()
    {
        return array_unique($this->roles);
    }
}


1		<?php
2		/**
3		* strategy combining a set of strategies to be applied
4		*/
5
6		namespace Graviton\SecurityBundle\Authentication\Strategies;
7
8		use Symfony\Component\HttpFoundation\Request;
9		use Symfony\Component\Security\Core\Role\Role;
10
11		/**
12		* Class MultiStrategy
13		*
14		* @package Graviton\SecurityBundle\Authentication\Strategies
15		* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
16		* @license http://opensource.org/licenses/gpl-license.php GNU Public License
17		* @link http://swisscom.ch
18		*/
19		class MultiStrategy implements StrategyInterface
20		{
21		/** @var StrategyInterface[] */
22		private $strategies;
23
24		/** @var Role[] */
25		private $roles= [];
26
27		/**
28		* MultiStrategy constructor.
29		*
30		* @param StrategyInterface[] $strategies List of strategies to be applied.
31		*/
32	2	public function __construct(array $strategies)
33		{
34	2	$this->strategies = $strategies;
35	2	}
36
37		/**
38		* Applies the defined strategies on the provided request.
39		*
40		* @param Request $request request to handle
41		*
42		* @return string
		0 ignored issues – show Documentation introduced 2017-10-12 15:04 UTC by Report Bug Copy Issue Report Should the return type not be `string\|false`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
43		*/
44		public function apply(Request $request)
45		{
46		foreach ($this->strategies as $strategy) {
47		$name = $strategy->apply($request);
48		$this->roles = $strategy->getRoles();
49
50		if ($name && $strategy->stopPropagation()) {
51		return $name;
52		}
53		}
54
55		return false;
56		}
57
58		/**
59		* Decider to stop other strategies running after from being considered.
60		*
61		* @return boolean
62		*/
63		public function stopPropagation()
64		{
65		return false;
66		}
67
68		/**
69		* Provides the list of registered roles.
70		*
71		* @return Role[]
72		*/
73		public function getRoles()
74		{
75		return array_unique($this->roles);
76		}
77		}
78

libgraviton / graviton

Push — feature/no-exception-if-no-use... ( 196818 )

MultiStrategy::apply() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like