ProxyControllerTest::testProxyAction() - Code Metrics - Inspection of "rewrite proxy controller test" - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/service-wrapper-for-sw... ( 7b5228...6a2d19 )

by Samuel

created 2015-12-07 17:27 UTC

ProxyControllerTest::testProxyAction() A

↳ Parent: ProxyControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	51
rs	9.411
cc	1
eloc	39
nc	1
nop	0

How to fix Long Method

<?php
/**
 * ProxyControllerTest
 */

namespace Graviton\ProxyBundle\Tests\Controller;

use Graviton\TestBundle\Client;
use Graviton\TestBundle\Test\RestTestCase;

/**
 * functional test for /3rdparty/{api}
 *
 * @author  List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link    http://swisscom.ch
 */
class ProxyControllerTest extends RestTestCase
{
    /**
     * @var string
     */
    const REQUEST_URL = "/3rdparty/graviton/core/app";

    /**
     * test post request with the proxy Action
     *
     * @return void
     */
    public function testProxyAction()
    {
        $client = static::createRestClient();
        $headers = array(
            'Content_Type'  => 'application/json',
        );

        $testApp = new \stdClass();
        $testApp->id = "testapp";
        $testApp->showInMenu = false;
        $testApp->order = 33;
        $testApp->name = new \stdClass();
        $testApp->name->en = "testapp";

        $client->request(
            'PUT',
            self::REQUEST_URL.'/'.$testApp->id,
            array(),
            array(),
            $headers,
            json_encode($testApp)
        );

        $response = $client->getResponse();

        $this->assertEquals(204, $response->getStatusCode());
        $this->assertEmpty($response->getContent());

        $client->request(
            'GET',
            self::REQUEST_URL.'/'.$testApp->id,
            array(),
            array(),
            $headers
        );
        $response = $client->getResponse();
        $content = json_decode($response->getContent());
        $this->assertEquals(200, $response->getStatusCode());
        $this->assertEquals($testApp, $content);

        $client->request(
            'DELETE',
            self::REQUEST_URL.'/'.$testApp->id,
            array(),
            array(),
            $headers
        );
        $response = $client->getResponse();
        $this->assertEquals(204, $response->getStatusCode());
        $this->assertEmpty($response->getContent());
    }

    /**
     * test the schema proxy Action
     *
     * @return void
     */
    public function testSchemaProxyAction()
    {
        $client = static::createRestClient();
        $client->request(
            'GET',
            '/schema'.self::REQUEST_URL.'/item'
        );
        $this->assertEquals(200, $client->getResponse()->getStatusCode());
    }
}


1			<?php
2			/**
3			* ProxyControllerTest
4			*/
5
6			namespace Graviton\ProxyBundle\Tests\Controller;
7
8			use Graviton\TestBundle\Client;
9			use Graviton\TestBundle\Test\RestTestCase;
10
11			/**
12			* functional test for /3rdparty/{api}
13			*
14			* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
15			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
16			* @link http://swisscom.ch
17			*/
18			class ProxyControllerTest extends RestTestCase
19			{
20			/**
21			* @var string
22			*/
23			const REQUEST_URL = "/3rdparty/graviton/core/app";
24
25			/**
26			* test post request with the proxy Action
27			*
28			* @return void
29			*/
30			public function testProxyAction()
31			{
32			$client = static::createRestClient();
33			$headers = array(
34			'Content_Type' => 'application/json',
35			);
36
37			$testApp = new \stdClass();
38			$testApp->id = "testapp";
39			$testApp->showInMenu = false;
40			$testApp->order = 33;
41			$testApp->name = new \stdClass();
42			$testApp->name->en = "testapp";
43
44			$client->request(
45			'PUT',
46			self::REQUEST_URL.'/'.$testApp->id,
47			array(),
48			array(),
49			$headers,
50			json_encode($testApp)
51			);
52
53			$response = $client->getResponse();
54
55			$this->assertEquals(204, $response->getStatusCode());
56			$this->assertEmpty($response->getContent());
57
58			$client->request(
59			'GET',
60			self::REQUEST_URL.'/'.$testApp->id,
61			array(),
62			array(),
63			$headers
64			);
65			$response = $client->getResponse();
66			$content = json_decode($response->getContent());
67			$this->assertEquals(200, $response->getStatusCode());
68			$this->assertEquals($testApp, $content);
69
70			$client->request(
71			'DELETE',
72			self::REQUEST_URL.'/'.$testApp->id,
73			array(),
74			array(),
75			$headers
76			);
77			$response = $client->getResponse();
78			$this->assertEquals(204, $response->getStatusCode());
79			$this->assertEmpty($response->getContent());
80			}
81
82			/**
83			* test the schema proxy Action
84			*
85			* @return void
86			*/
87			public function testSchemaProxyAction()
88			{
89			$client = static::createRestClient();
90			$client->request(
91			'GET',
92			'/schema'.self::REQUEST_URL.'/item'
93			);
94			$this->assertEquals(200, $client->getResponse()->getStatusCode());
95			}
96			}
97

libgraviton / graviton

Push — feature/service-wrapper-for-sw... ( 7b5228...6a2d19 )

ProxyControllerTest::testProxyAction() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like