Graviton\CoreBundle\Tests\Command\GenerateVersionsCommandTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	testGenerateVersions()	0	45	5

<?php
/** GenerateVersionsCommandTest **/

namespace Graviton\CoreBundle\Tests\Command;

use Graviton\CoreBundle\Command\GenerateVersionsCommand;
use Graviton\TestBundle\Test\GravitonTestCase;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Tester\CommandTester;
use Symfony\Component\Yaml\Parser;

/**
 * GenerateVersionsCommandTest
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class GenerateVersionsCommandTest extends \PHPUnit_Framework_TestCase
{
    /**
     * Tests the execution of the command
     *
     * @return void
     */
    public function testGenerateVersions()
    {
        $kernel = GravitonTestCase::createKernel();
        $application = new Application($kernel);

        $application->add(new GenerateVersionsCommand());

        $command = $application->find('graviton:core:generateversions');

        $commandTester = new CommandTester($command);
        $commandTester->execute(array());

        $rootDir = $kernel->getContainer()->getParameter("kernel.root_dir");
        $contextDir = $rootDir;
        // are we in Wrapper context?
        if (strstr($contextDir, 'vendor')) {
            $contextDir.='/../../../../app';
        }

        $parser = new Parser();
        $config = $parser->parse(file_get_contents($contextDir.'/config/version_service.yml'));
        $versions = $parser->parse(file_get_contents($rootDir.'/../versions.yml'));

        $deliveredVersions = [];
        foreach ($versions as $version) {

The expression $versions of type array|string|object<stdClass> is not guaranteed to be traversable. How about adding an additional type check?

            $deliveredVersions[$version['id']] = $version['version'];
        };

        // check if all keys are in the resulting array (canonical, because the sorting doesnt matter)
        $this->assertEquals(
            $config['desiredVersions'],
            array_keys($deliveredVersions),
            "canonical = true",
            0.0,
            10,
            true
        );

        // check if the version contains at least 4 chars (i.e. minimum dev-)
        foreach ($config['desiredVersions'] as $desiredVersion) {
            if (isset($deliveredVersions[$desiredVersion])) {
                $this->assertTrue(strlen($deliveredVersions[$desiredVersion])>3);

Instead of assertTrue() use $this->assertGreaterThan(3, strlen($deliveredVersions[$desiredVersion])). This will lead to a better error message when the test fails.

            }
        }
    }
}