Conditions | 1 |
Paths | 1 |
Total Lines | 75 |
Code Lines | 65 |
Lines | 0 |
Ratio | 0 % |
Tests | 66 |
CRAP Score | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
30 | 33 | public function load(ObjectManager $manager) |
|
31 | { |
||
32 | 33 | $deAdmin = new Translatable; |
|
33 | 33 | $deAdmin->setId('i18n-de-Administration'); |
|
34 | 33 | $deAdmin->setDomain('core'); |
|
35 | 33 | $deAdmin->setLocale('de'); |
|
36 | 33 | $deAdmin->setOriginal('Administration'); |
|
37 | 33 | $deAdmin->setTranslated('Die Administration'); |
|
38 | 33 | $deAdmin->setIsLocalized(true); |
|
39 | 33 | $language = new TranslatableLanguage; |
|
40 | 33 | $language->setRef(ExtReference::create('Language', 'de')); |
|
41 | 33 | $deAdmin->setLanguage($language); |
|
42 | 33 | $manager->persist($deAdmin); |
|
43 | |||
44 | 33 | $frAdmin = new Translatable; |
|
45 | 33 | $frAdmin->setId('i18n-fr-Administration'); |
|
46 | 33 | $frAdmin->setDomain('core'); |
|
47 | 33 | $frAdmin->setLocale('fr'); |
|
48 | 33 | $frAdmin->setOriginal('Administration'); |
|
49 | 33 | $frAdmin->setIsLocalized(false); |
|
50 | 33 | $language = new TranslatableLanguage; |
|
51 | 33 | $language->setRef(ExtReference::create('Language', 'fr')); |
|
52 | 33 | $frAdmin->setLanguage($language); |
|
53 | 33 | $manager->persist($frAdmin); |
|
54 | |||
55 | 33 | $enAdmin = new Translatable; |
|
56 | 33 | $enAdmin->setId('i18n-en-Administration'); |
|
57 | 33 | $enAdmin->setDomain('core'); |
|
58 | 33 | $enAdmin->setLocale('en'); |
|
59 | 33 | $enAdmin->setOriginal('Administration'); |
|
60 | 33 | $enAdmin->setTranslated('Administration'); |
|
61 | 33 | $enAdmin->setIsLocalized(true); |
|
62 | 33 | $language = new TranslatableLanguage; |
|
63 | 33 | $language->setRef(ExtReference::create('Language', 'en')); |
|
64 | 33 | $enAdmin->setLanguage($language); |
|
65 | 33 | $manager->persist($enAdmin); |
|
66 | |||
67 | /*** THIS TRANSLATABLES HERE SHOULD *NOT* BE TRANSLATED FOR TESTS ***/ |
||
68 | |||
69 | 33 | $deTablet = new Translatable; |
|
70 | 33 | $deTablet->setId('i18n-de-Tablet'); |
|
71 | 33 | $deTablet->setDomain('core'); |
|
72 | 33 | $deTablet->setLocale('de'); |
|
73 | 33 | $deTablet->setOriginal('Tablet'); |
|
74 | 33 | $deTablet->setIsLocalized(false); |
|
75 | 33 | $language = new TranslatableLanguage; |
|
76 | 33 | $language->setRef(ExtReference::create('Language', 'de')); |
|
77 | 33 | $deTablet->setLanguage($language); |
|
78 | 33 | $manager->persist($deTablet); |
|
79 | |||
80 | 33 | $frTablet = new Translatable; |
|
81 | 33 | $frTablet->setId('i18n-fr-Tablet'); |
|
82 | 33 | $frTablet->setDomain('core'); |
|
83 | 33 | $frTablet->setLocale('fr'); |
|
84 | 33 | $frTablet->setOriginal('Tablet'); |
|
85 | 33 | $frTablet->setIsLocalized(false); |
|
86 | 33 | $language = new TranslatableLanguage; |
|
87 | 33 | $language->setRef(ExtReference::create('Language', 'fr')); |
|
88 | 33 | $frTablet->setLanguage($language); |
|
89 | 33 | $manager->persist($frTablet); |
|
90 | |||
91 | 33 | $enTablet = new Translatable; |
|
92 | 33 | $enTablet->setId('i18n-en-Tablet'); |
|
93 | 33 | $enTablet->setDomain('core'); |
|
94 | 33 | $enTablet->setLocale('en'); |
|
95 | 33 | $enTablet->setOriginal('Tablet'); |
|
96 | 33 | $enTablet->setTranslated('Tablet'); |
|
97 | 33 | $enTablet->setIsLocalized(true); |
|
98 | 33 | $language = new TranslatableLanguage; |
|
99 | 33 | $language->setRef(ExtReference::create('Language', 'en')); |
|
100 | 33 | $enTablet->setLanguage($language); |
|
101 | 33 | $manager->persist($enTablet); |
|
102 | |||
103 | 33 | $manager->flush(); |
|
104 | 33 | } |
|
105 | } |
||
106 |