Graviton\DocumentBundle\Serializer\Handler\EmptyHandler

Complexity

Total Complexity

2

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	serializeEmptyToJson()	0	8	1
A	deserializeEmptyFromJson()	0	8	1

<?php
/**
 * HashHandler class file
 */

namespace Graviton\DocumentBundle\Serializer\Handler;

use JMS\Serializer\Context;
use JMS\Serializer\JsonDeserializationVisitor;
use JMS\Serializer\JsonSerializationVisitor;
use Graviton\DocumentBundle\Entity\Hash;

/**
 * Hash handler for JMS serializer
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class EmptyHandler
{
    /**
     * Serialize Hash object
     *
     * @param JsonSerializationVisitor $visitor Visitor
     * @param Hash                     $data    Data
     * @param array                    $type    Type
     * @param Context                  $context Context
     * @return array

Should the return type not be array|null? Also, consider making the array more specific, something like array<String>, or String[].

     */
    public function serializeEmptyToJson(
        JsonSerializationVisitor $visitor,

The parameter $visitor is not used and could be removed.

        $data,

The parameter $data is not used and could be removed.

        array $type,

The parameter $type is not used and could be removed.

        Context $context

The parameter $context is not used and could be removed.

    ) {
        return null;
    }

    /**
     * Deserialize Hash object
     *
     * @param JsonDeserializationVisitor $visitor Visitor
     * @param array                      $data    Data
     * @param array                      $type    Type
     * @param Context                    $context Context
     * @return Hash

Should the return type not be Hash|null?

     */
    public function deserializeEmptyFromJson(
        JsonDeserializationVisitor $visitor,

The parameter $visitor is not used and could be removed.

        $data,

The parameter $data is not used and could be removed.

        array $type,

The parameter $type is not used and could be removed.

        Context $context

The parameter $context is not used and could be removed.

    ) {
        return null;
    }
}