Graviton\DocumentBundle\Entity\Hash

Complexity

Total Complexity

12

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	jsonSerialize()	0	4	1
B	arrayFilterRecursive()	0	12	5
B	cleanUpArray()	0	13	6

<?php
/**
 * Hash class file
 */

namespace Graviton\DocumentBundle\Entity;

/**
 * Special type for hash fields
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class Hash extends \ArrayObject implements \JsonSerializable
{
    /**
     * Specify data which should be serialized to JSON
     *
     * @return object
     */
    public function jsonSerialize()
    {
        return (object) $this->arrayFilterRecursive($this->getArrayCopy());
    }

    /**
     * Clean up, remove empty positions of second level and above
     *
     * @param array $input to be cleaned up
     * @return array
     */
    private function arrayFilterRecursive($input)

This method is not used, and could be removed.

    {
        if (empty($input)) {
            return [];
        }
        foreach ($input as &$value) {
            if (is_array($value) || is_object($value)) {
                $value = $this->arrayFilterRecursive($value);

It seems like $value can also be of type object; however, Graviton\DocumentBundle\Entity\Hash::arrayFilterRecursive() does only seem to accept array, maybe add an additional type check?

            }
        }
        return array_filter($input, [$this, 'cleanUpArray']);
    }

    /**
     * Remove NULL values or Empty array object
     * @param mixed $var object field value
     * @return bool
     */
    private function cleanUpArray($var)
    {
        $empty = empty($var);
        if ($empty && (
                is_int($var) ||
                is_bool($var) ||
                is_float($var) ||
                is_integer($var))
        ) {
            return true;
        }
        return !$empty;
    }
}