Graviton\GeneratorBundle\Definition\Utils\ConstraintNormalizer

Complexity

Total Complexity

1

Size/Duplication

Total Lines	24
Duplicated Lines	62.5 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	1	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	normalize()	15	15	1

<?php
/**
 * ConstraintNormalizer class file
 */
namespace Graviton\GeneratorBundle\Definition\Utils;

use Graviton\GeneratorBundle\Definition\Schema\Constraint;
use Graviton\GeneratorBundle\Definition\Schema\ConstraintOption;

/**
 * Constraint normalizer
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class ConstraintNormalizer

ConstraintNormalizer does not seem to conform to the naming convention (Utils?$).

{
    /**
     * Convert constraint to array to selerialile it via json_encode
     *
     * @param Constraint $constraint Constraint
     * @return array

Consider making the return type a bit more specific; maybe use array<string,string|array>.

     */
    public static function normalize(Constraint $constraint)

This method seems to be duplicated in your project.

    {
        return [
            'name'      => $constraint->getName(),
            'options'   => array_map(
                function (ConstraintOption $option) {
                    return [
                        'name'  => $option->getName(),
                        'value' => $option->getValue(),
                    ];
                },
                $constraint->getOptions()
            ),
        ];
    }
}