SecurityUser::getSalt() - Code Metrics - Inspection of "evo-2472 and evo-2476 security authentication" - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#353)

by Jan

created 2016-01-28 08:41 UTC

SecurityUser::getSalt() A

↳ Parent: SecurityUser

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 * security consultant entity
 */

namespace Graviton\SecurityBundle\Entities;

use Symfony\Component\Security\Core\Role\Role;
use Symfony\Component\Security\Core\User\UserInterface;

/**
 * Class SecurityUser
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
class SecurityUser implements UserInterface
{
    const ROLE_USER = 'ROLE_GRAVITON_USER';
    const ROLE_ANONYMOUS = 'ROLE_GRAVITON_ANONYMOUS';

    /**
     * @var Object
     */
    private $user;

    /**
     * @var Role[]
     */
    private $roles;


    /**
     * Constructor of the class.
     *
     * @param object $user  the user
     * @param Role[] $roles roles for the contract
     */
    public function __construct($user, array $roles = array())
    {
        $this->user = $user;
        $this->roles = $roles;
    }

    /**
     * Returns the roles granted to the user.
     *
     * @return Role[] The user roles
     */
    public function getRoles()
    {
        return $this->roles;
    }

    /**
     * Returns the password used to authenticate the user.
     *
     * @return string The password
     */
    public function getPassword()
    {
        return '';
    }

    /**
     * Returns the salt that was originally used to encode the password.
     *
     * @return null The salt
     */
    public function getSalt()
    {
        return null;
    }

    /**
     * Returns the username used to authenticate the user.
     *
     * @return string The username
     */
    public function getUsername()
    {
        if (method_exists($this->user, 'getUsername')) {
            return $this->user->getUsername();
        }
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Removes sensitive data from the user.
     *
     * This is important if, at any given point, sensitive information like
     * the plain-text password is stored on this object.
     *
     * @return void
     */
    public function eraseCredentials()
    {
    }

    /**
     * Provides the consultant object.
     *
     * @return Object
     */
    public function getUser()
    {
        return $this->user;
    }

    /**
     * Check if user has role
     * @param string $role
     * @return bool
     */
    public function hasRole($role)
    {
        return in_array($role, $this->roles);
    }

    /**
     * @return string
     */
    public function __toString()
    {
        $roles = $this->$this->getRoles();
        $username = $this->getUsername() ? $this->getUsername() : 'anonymous';
        return reser($roles).':'.$username;
    }
}


1			<?php
2			/**
3			* security consultant entity
4			*/
5
6			namespace Graviton\SecurityBundle\Entities;
7
8			use Symfony\Component\Security\Core\Role\Role;
9			use Symfony\Component\Security\Core\User\UserInterface;
10
11			/**
12			* Class SecurityUser
13			*
14			* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
15			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
16			* @link http://swisscom.ch
17			*/
18			class SecurityUser implements UserInterface
19			{
20			const ROLE_USER = 'ROLE_GRAVITON_USER';
21			const ROLE_ANONYMOUS = 'ROLE_GRAVITON_ANONYMOUS';
22
23			/**
24			* @var Object
25			*/
26			private $user;
27
28			/**
29			* @var Role[]
30			*/
31			private $roles;
32
33
34			/**
35			* Constructor of the class.
36			*
37			* @param object $user the user
38			* @param Role[] $roles roles for the contract
39			*/
40			public function __construct($user, array $roles = array())
41			{
42			$this->user = $user;
43			$this->roles = $roles;
44			}
45
46			/**
47			* Returns the roles granted to the user.
48			*
49			* @return Role[] The user roles
50			*/
51			public function getRoles()
52			{
53			return $this->roles;
54			}
55
56			/**
57			* Returns the password used to authenticate the user.
58			*
59			* @return string The password
60			*/
61			public function getPassword()
62			{
63			return '';
64			}
65
66			/**
67			* Returns the salt that was originally used to encode the password.
68			*
69			* @return null The salt
70			*/
71			public function getSalt()
72			{
73			return null;
74			}
75
76			/**
77			* Returns the username used to authenticate the user.
78			*
79			* @return string The username
80			*/
81			public function getUsername()
82			{
83			if (method_exists($this->user, 'getUsername')) {
84			return $this->user->getUsername();
85			}
86			return false;
			0 ignored issues – show Bug Best Practice introduced 2016-01-26 09:25 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Symfony\Component\Securi...rInterface::getUsername` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
87			}
88
89			/**
90			* Removes sensitive data from the user.
91			*
92			* This is important if, at any given point, sensitive information like
93			* the plain-text password is stored on this object.
94			*
95			* @return void
96			*/
97			public function eraseCredentials()
98			{
99			}
100
101			/**
102			* Provides the consultant object.
103			*
104			* @return Object
105			*/
106			public function getUser()
107			{
108			return $this->user;
109			}
110
111			/**
112			* Check if user has role
113			* @param string $role
114			* @return bool
115			*/
116			public function hasRole($role)
117			{
118			return in_array($role, $this->roles);
119			}
120
121			/**
122			* @return string
123			*/
124			public function __toString()
125			{
126			$roles = $this->$this->getRoles();
127			$username = $this->getUsername() ? $this->getUsername() : 'anonymous';
128			return reser($roles).':'.$username;
129			}
130			}
131

libgraviton / graviton

Pull Request — develop (#353)

SecurityUser::getSalt() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like