WebTestCase::createClient() - Code Metrics - Inspection of "try to force debug: false everywhere to speed up t..." - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/fix-some-deps-no-debug ( 88213d )

by Narcotic

created 2016-02-29 14:45 UTC

WebTestCase::createClient() A

↳ Parent: WebTestCase

Complexity

Conditions	3
Paths	2

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	22
rs	9.2
cc	3
eloc	12
nc	2
nop	2

<?php
/**
 * Base class for tests that need a http client..
 */

namespace Graviton\TestBundle\Test;

use Graviton\BundleBundle\GravitonBundleBundle;
use Graviton\BundleBundle\Loader\BundleLoader;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase as SymWebTestCase;

/**
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     http://swisscom.ch
 */
abstract class WebTestCase extends SymWebTestCase

{
    /**
     * Provides a HttpClient based on the Graviton\AppKernel
     *
     * @todo why are we not using createClient from SymWebTestCase? This need fixing or an explanation.
     *
     * @param array $options environment and debug option for kernel
     * @param array $server  server params
     *
     * @return \Symfony\Bundle\FrameworkBundle\Client
     */
    protected static function createClient(array $options = array(), array $server = array())
    {
        WebTestCase::ensureKernelShutdown();
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}

        if (null === KernelTestCase::$class) {
            KernelTestCase::$class = '\\Graviton\\'.static::getKernelClass();
        }

        WebTestCase::$kernel = new WebTestCase::$class(
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
            isset($options['environment']) ? $options['environment'] : 'test',
            false
        );

        WebTestCase::$kernel->setBundleLoader(new BundleLoader(new GravitonBundleBundle()));
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}

        WebTestCase::$kernel->boot();
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}

        $client = WebTestCase::$kernel->getContainer()->get('test.client');
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
        $client->setServerParameters($server);

        return $client;
    }

    /**
     * Attempts to guess the kernel location.
     *
     * When the Kernel is located, the file is required.
     *
     * @return string The Kernel class name
     *
     * @throws \RuntimeException
     */
    protected static function getKernelClass()
    {
        // @codingStandardsIgnoreStart
        require_once __DIR__ . '/../../../../app/AppKernel.php';
        // @codingStandardsIgnoreEnd

        return 'AppKernel';
    }
}


1			<?php
2			/**
3			* Base class for tests that need a http client..
4			*/
5
6			namespace Graviton\TestBundle\Test;
7
8			use Graviton\BundleBundle\GravitonBundleBundle;
9			use Graviton\BundleBundle\Loader\BundleLoader;
10			use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
11			use Symfony\Bundle\FrameworkBundle\Test\WebTestCase as SymWebTestCase;
12
13			/**
14			* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
15			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
16			* @link http://swisscom.ch
17			*/
18			abstract class WebTestCase extends SymWebTestCase
			0 ignored issues – show Coding Style introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report `WebTestCase` does not seem to conform to the naming convention (`^Abstract\|Factory$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
19			{
20			/**
21			* Provides a HttpClient based on the Graviton\AppKernel
22			*
23			* @todo why are we not using createClient from SymWebTestCase? This need fixing or an explanation.
24			*
25			* @param array $options environment and debug option for kernel
26			* @param array $server server params
27			*
28			* @return \Symfony\Bundle\FrameworkBundle\Client
29			*/
30			protected static function createClient(array $options = array(), array $server = array())
31			{
32			WebTestCase::ensureKernelShutdown();
			0 ignored issues – show Coding Style introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
33
34			if (null === KernelTestCase::$class) {
35			KernelTestCase::$class = '\\Graviton\\'.static::getKernelClass();
36			}
37
38			WebTestCase::$kernel = new WebTestCase::$class(
			0 ignored issues – show Coding Style introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
39			isset($options['environment']) ? $options['environment'] : 'test',
40			false
41			);
42
43			WebTestCase::$kernel->setBundleLoader(new BundleLoader(new GravitonBundleBundle()));
			0 ignored issues – show Coding Style introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
44
45			WebTestCase::$kernel->boot();
			0 ignored issues – show Coding Style introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
46
47			$client = WebTestCase::$kernel->getContainer()->get('test.client');
			0 ignored issues – show Coding Style introduced 2015-11-23 08:02 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
48			$client->setServerParameters($server);
49
50			return $client;
51			}
52
53			/**
54			* Attempts to guess the kernel location.
55			*
56			* When the Kernel is located, the file is required.
57			*
58			* @return string The Kernel class name
59			*
60			* @throws \RuntimeException
61			*/
62			protected static function getKernelClass()
63			{
64			// @codingStandardsIgnoreStart
65			require_once __DIR__ . '/../../../../app/AppKernel.php';
66			// @codingStandardsIgnoreEnd
67
68			return 'AppKernel';
69			}
70			}
71

libgraviton / graviton

Push — feature/fix-some-deps-no-debug ( 88213d )

WebTestCase::createClient() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like