Graviton\DocumentBundle\Service\DateConverter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getDateFormat()	0	4	1
A	getTimezone()	0	4	1
A	getDateTimeFromString()	0	4	1
A	formatDateTime()	0	4	1
A	getDateTimeStringInFormat()	0	6	1

<?php
/**
 * DateConverter class file
 */

namespace Graviton\DocumentBundle\Service;

use JsonSchema\Rfc3339;

/**
 * Date converter
 *
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  https://opensource.org/licenses/MIT MIT License
 * @link     http://swisscom.ch
 */
class DateConverter
{

    /**
     * @var string
     */
    private $dateFormat;

    /**
     * @var string
     */
    private $timezone;

    /**
     * Constructor
     *
     * @param string $dateFormat date format
     * @param string $timezone   timezone
     */
    public function __construct($dateFormat, $timezone)
    {
        $this->dateFormat = $dateFormat;
        $this->timezone = $timezone;
    }

    /**
     * get DateFormat
     *
     * @return string DateFormat
     */
    public function getDateFormat()
    {
        return $this->dateFormat;
    }

    /**
     * get Timezone
     *
     * @return string Timezone
     */
    public function getTimezone()
    {
        return $this->timezone;
    }

    /**
     * Returns a DateTime instance from a string representation
     *
     * @param string $data string Rfc3339 date
     *
     * @return \DateTime datetime

Should the return type not be \DateTime|null?

     */
    public function getDateTimeFromString($data)
    {
        return Rfc3339::createFromString($data);
    }

    /**
     * formats a DateTime to the defined default format
     *
     * @param \DateTime $dateTime datetime
     *
     * @return string formatted date
     */
    public function formatDateTime(\DateTime $dateTime)
    {
        return $dateTime->format($this->dateFormat);
    }

    /**
     * accepts a Rfc3339 datetime string and converts it to the defined default format
     *
     * @param string $data Rfc3339 datetime
     *
     * @return string date in configured format
     */
    public function getDateTimeStringInFormat($data)
    {
        return $this->formatDateTime(
            $this->getDateTimeFromString($data)

It seems like $this->getDateTimeFromString($data) can be null; however, formatDateTime() does not accept null, maybe add an additional type check?

        );
    }
}