SolrQuery::__construct() - Code Metrics - libgraviton/graviton - Measure and Improve Code Quality continuously with Scrutinizer

SolrQuery::__construct() A
last analyzed 2019-01-17 15:19 UTC

↳ Parent: SolrQuery

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	11
cts	11
cp	1
rs	9.584
c	0
b	0
f	0
cc	2
nc	2
nop	8
crap	2

How to fix Many Parameters

<?php
/**
 * SolrQuery class file
 */

namespace Graviton\DocumentBundle\Service;

use Graviton\Rql\Node\SearchNode;
use Solarium\Client;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Xiag\Rql\Parser\Node\LimitNode;

/**
 * @author   List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
 * @license  https://opensource.org/licenses/MIT MIT License
 * @link     http://swisscom.ch
 */
class SolrQuery
{

    /**
     * @var string
     */
    private $className;

    /**
     * @var array
     */
    private $urlParts = [];

    /**
     * @var int
     */
    private $solrFuzzyBridge;

    /**
     * @var int
     */
    private $solrWildcardBridge;

    /**
     * @var boolean
     */
    private $andifyTerms;

    /**
     * @var array
     */
    private $solrMap;

    /**
     * @var int
     */
    private $paginationDefaultLimit;

    /**
     * @var Client
     */
    private $solrClient;

    /**
     * @var RequestStack
     */
    private $requestStack;

    /**
     * if the full search term matches one of these patterns, the whole thing is sent quoted to solr
     *
     * @var array
     */
    private $fullTermPatterns = [
        '/^[0-9]+ [0-9\.]{9,}$/i'
    ];

    /**
     * pattern to match a solr field query
     *
     * @var string
     */
    private $fieldQueryPattern = '/(.{2,}):(.+)/i';

    /**
     * stuff that does not get andified/quoted/whatever
     *
     * @var array
     */
    private $queryOperators = [
        'AND',
        'NOT',
        'OR',
        '&&',
        '||',
        '!'
    ];

    /**
     * Constructor
     *
     * @param string       $solrUrl                url to solr
     * @param int          $solrFuzzyBridge        fuzzy bridge
     * @param int          $solrWildcardBridge     wildcard bridge
     * @param boolean      $andifyTerms            andify terms or not?
     * @param array        $solrMap                solr class field weight map
     * @param int          $paginationDefaultLimit default pagination limit
     * @param Client       $solrClient             solr client
     * @param RequestStack $requestStack           request stack
     */
    public function __construct(
        $solrUrl,
        $solrFuzzyBridge,
        $solrWildcardBridge,
        $andifyTerms,
        array $solrMap,
        $paginationDefaultLimit,
        Client $solrClient,
        RequestStack $requestStack
    ) {
        if (!is_null($solrUrl)) {
            $this->urlParts = parse_url($solrUrl);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }
        $this->solrFuzzyBridge = (int) $solrFuzzyBridge;
        $this->solrWildcardBridge = (int) $solrWildcardBridge;
        $this->andifyTerms = (boolean) $andifyTerms;
        $this->solrMap = $solrMap;
        $this->paginationDefaultLimit = (int) $paginationDefaultLimit;
        $this->solrClient = $solrClient;
        $this->requestStack = $requestStack;
    }

    /**
     * sets the class name to search - last part equates to solr core name
     *
     * @param string $className class name
     *
     * @return void
     */
    public function setClassName($className)
    {
        $this->className = $className;
    }

    /**
     * returns true if solr is configured currently, false otherwise
     *
     * @return bool if solr is configured
     */
    public function isConfigured()
    {
        if (!empty($this->urlParts) && isset($this->solrMap[$this->className])) {
            return true;
        }
        return false;
    }

    /**
     * executes the search on solr using the rql parsing nodes.
     *
     * @param SearchNode     $node      search node
     * @param LimitNode|null $limitNode limit node
     *
     * @return array an array of just record ids (the ids of the matching documents in solr)
     */
    public function query(SearchNode $node, LimitNode $limitNode = null)
    {
        $client = $this->getClient();

        $query = $client->createQuery($client::QUERY_SELECT);

        // set the weights
        $query->getEDisMax()->setQueryFields($this->solrMap[$this->className]);

        $query->setQuery($this->getSearchTerm($node));

        if ($limitNode instanceof LimitNode) {
            $query->setStart($limitNode->getOffset())->setRows($limitNode->getLimit());
        } else {
            $query->setStart(0)->setRows($this->paginationDefaultLimit);
        }

        $query->setFields(['id']);

        $result = $client->select($query);

        if ($this->requestStack->getCurrentRequest() instanceof Request) {
            $this->requestStack->getCurrentRequest()->attributes->set('totalCount', $result->getNumFound());
            $this->requestStack->getCurrentRequest()->attributes->set('X-Search-Source', 'solr');
        }

        $idList = [];
        foreach ($result as $document) {
            if (isset($document->id)) {
                $idList[] = (string) $document->id;
            } elseif (isset($document->_id)) {
                $idList[] = (string) $document->_id;
            }
        }

        return $idList;
    }

    /**
     * returns the string search term to be used in the solr query
     *
     * @param SearchNode $node the search node
     *
     * @return string the composed search query
     */
    private function getSearchTerm(SearchNode $node)
    {
        $fullTerm = $node->getSearchQuery();

        foreach ($this->fullTermPatterns as $pattern) {
            if (preg_match($pattern, $fullTerm, $matches) === 1) {
                return '"'.$fullTerm.'"';
            }
        }

        if ($this->andifyTerms) {
            $glue = 'AND';
        } else {
            $glue = '';
        }


        $i = 0;
        $hasPreviousOperator = false;
        $fullSearchElements = [];

        foreach (explode(' ', $node->getSearchQuery()) as $term) {
            $i++;

            // is this an operator?
            if (array_search($term, $this->queryOperators) !== false) {
                $fullSearchElements[] = $term;
                $hasPreviousOperator = true;
                continue;
            }

            $singleTerm = $this->getSingleTerm($term);

            if ($i > 1 && $hasPreviousOperator == false && !empty($glue)) {
                $fullSearchElements[] = $glue;
            } else {
                $hasPreviousOperator = false;
            }

            $fullSearchElements[] = $singleTerm;
        }

        return implode(' ', $fullSearchElements);
    }

    /**
     * returns a single term how to search. here we can apply custom logic to the user input string
     *
     * @param string $term single search term
     *
     * @return string modified search term
     */
    private function getSingleTerm($term)
    {
        // we don't modify numbers
        if (ctype_digit($term)) {
            return '"'.$term.'"';
        }

        // formatted number?
        $formatted = str_replace(
            [
                '-',
                '.'
            ],
            '',
            $term
        );
        if (ctype_digit($formatted)) {
            return '"'.$term.'"';
        }

        // everything that is only numbers *and* characters and at least 3 long, we don't fuzzy/wildcard
        // thanks to https://stackoverflow.com/a/7684859/3762521
        $pattern = '/^(?=.*[0-9])(?=.*[a-zA-Z])([a-zA-Z0-9]+)$/';
        if (strlen($term) > 3 && preg_match($pattern, $term, $matches) === 1) {
            return '"'.$term.'"';
        }

        // is it a solr field query (like id:333)?
        if (preg_match($this->fieldQueryPattern, $term) === 1) {
            return $this->parseSolrFieldQuery($term);
        }

        // strings shorter then 5 chars (like hans) we wildcard, all others we make fuzzy
        if (strlen($term) >= $this->solrFuzzyBridge) {
            return $this->doAndNotPrefixSingleTerm($term, '~');
        }

        if (strlen($term) >= $this->solrWildcardBridge) {
            return $this->doAndNotPrefixSingleTerm($term, '*');
        }

        return $term;
    }

    /**
     * parses the special solr field syntax fieldName:fieldValue, converts int ranges
     *
     * @param string $fieldQuery the query
     *
     * @return string solr compatible expression
     */
    private function parseSolrFieldQuery($fieldQuery)
    {
        $fieldNameParts = explode(':', $fieldQuery);
        $fieldName = $fieldNameParts[0];
        unset($fieldNameParts[0]);
        $fieldValue = implode(':', $fieldNameParts);

        // change > and <
        if ($fieldValue[0] == '<') {
            $fieldValue = '[* TO '.substr($fieldValue, 1).']';
        } elseif ($fieldValue[0] == '>') {
            $fieldValue = '['.substr($fieldValue, 1).' TO *]';
        } else {
            $fieldValue = $this->getSingleTerm($fieldValue);
        }

        return $fieldName.':'.$fieldValue;
    }

    /**
     * ORify a single term
     *
     * @param string $term     search term
     * @param string $modifier modified
     *
     * @return string ORified query
     */
    private function doAndNotPrefixSingleTerm($term, $modifier)
    {
        // already modifier there?
        $last = substr($term, -1);
        if ($last == '~' || $last == '*') {
            // clean from term, override modifier from client
            $modifier = $last;
            $term = substr($term, 0, -1);
        }

        return sprintf(
            '(%s OR %s%s)',
            $term,
            $term,
            $modifier
        );
    }

    /**
     * returns the client to use for the current query
     *
     * @return Client client
     */
    private function getClient()
    {
        $endpointConfig = $this->urlParts;
        if (!isset($endpointConfig['path'])) {
            $endpointConfig['path'] = '/';
        }

        if (substr($endpointConfig['path'], -1) != '/') {
            $endpointConfig['path'] .= '/';
        }

        // find core name
        $classnameParts = explode('\\', $this->className);
        $endpointConfig['core'] = array_pop($classnameParts);

        $endpointConfig['timeout'] = 10000;
        $endpointConfig['key'] = 'local';

        $this->solrClient->addEndpoint($endpointConfig);
        $this->solrClient->setDefaultEndpoint($endpointConfig['key']);

        return $this->solrClient;
    }
}


1			<?php
2			/**
3			* SolrQuery class file
4			*/
5
6			namespace Graviton\DocumentBundle\Service;
7
8			use Graviton\Rql\Node\SearchNode;
9			use Solarium\Client;
10			use Symfony\Component\HttpFoundation\Request;
11			use Symfony\Component\HttpFoundation\RequestStack;
12			use Xiag\Rql\Parser\Node\LimitNode;
13
14			/**
15			* @author List of contributors <https://github.com/libgraviton/graviton/graphs/contributors>
16			* @license https://opensource.org/licenses/MIT MIT License
17			* @link http://swisscom.ch
18			*/
19			class SolrQuery
20			{
21
22			/**
23			* @var string
24			*/
25			private $className;
26
27			/**
28			* @var array
29			*/
30			private $urlParts = [];
31
32			/**
33			* @var int
34			*/
35			private $solrFuzzyBridge;
36
37			/**
38			* @var int
39			*/
40			private $solrWildcardBridge;
41
42			/**
43			* @var boolean
44			*/
45			private $andifyTerms;
46
47			/**
48			* @var array
49			*/
50			private $solrMap;
51
52			/**
53			* @var int
54			*/
55			private $paginationDefaultLimit;
56
57			/**
58			* @var Client
59			*/
60			private $solrClient;
61
62			/**
63			* @var RequestStack
64			*/
65			private $requestStack;
66
67			/**
68			* if the full search term matches one of these patterns, the whole thing is sent quoted to solr
69			*
70			* @var array
71			*/
72			private $fullTermPatterns = [
73			'/^[0-9]+ [0-9\.]{9,}$/i'
74			];
75
76			/**
77			* pattern to match a solr field query
78			*
79			* @var string
80			*/
81			private $fieldQueryPattern = '/(.{2,}):(.+)/i';
82
83			/**
84			* stuff that does not get andified/quoted/whatever
85			*
86			* @var array
87			*/
88			private $queryOperators = [
89			'AND',
90			'NOT',
91			'OR',
92			'&&',
93			'\|\|',
94			'!'
95			];
96
97			/**
98			* Constructor
99			*
100			* @param string $solrUrl url to solr
101			* @param int $solrFuzzyBridge fuzzy bridge
102			* @param int $solrWildcardBridge wildcard bridge
103			* @param boolean $andifyTerms andify terms or not?
104			* @param array $solrMap solr class field weight map
105			* @param int $paginationDefaultLimit default pagination limit
106			* @param Client $solrClient solr client
107			* @param RequestStack $requestStack request stack
108			*/
109	38		public function __construct(
110			$solrUrl,
111			$solrFuzzyBridge,
112			$solrWildcardBridge,
113			$andifyTerms,
114			array $solrMap,
115			$paginationDefaultLimit,
116			Client $solrClient,
117			RequestStack $requestStack
118			) {
119	38		if (!is_null($solrUrl)) {
120	38		$this->urlParts = parse_url($solrUrl);
			0 ignored issues – show Documentation Bug introduced 2019-01-17 15:18 UTC by Report Bug Copy Issue Report It seems like `parse_url($solrUrl)` can also be of type `false`. However, the property `$urlParts` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
121			}
122	38		$this->solrFuzzyBridge = (int) $solrFuzzyBridge;
123	38		$this->solrWildcardBridge = (int) $solrWildcardBridge;
124	38		$this->andifyTerms = (boolean) $andifyTerms;
125	38		$this->solrMap = $solrMap;
126	38		$this->paginationDefaultLimit = (int) $paginationDefaultLimit;
127	38		$this->solrClient = $solrClient;
128	38		$this->requestStack = $requestStack;
129	38		}
130
131			/**
132			* sets the class name to search - last part equates to solr core name
133			*
134			* @param string $className class name
135			*
136			* @return void
137			*/
138	38		public function setClassName($className)
139			{
140	38		$this->className = $className;
141	38		}
142
143			/**
144			* returns true if solr is configured currently, false otherwise
145			*
146			* @return bool if solr is configured
147			*/
148	2		public function isConfigured()
149			{
150	2		if (!empty($this->urlParts) && isset($this->solrMap[$this->className])) {
151	2		return true;
152			}
153	2		return false;
154			}
155
156			/**
157			* executes the search on solr using the rql parsing nodes.
158			*
159			* @param SearchNode $node search node
160			* @param LimitNode\|null $limitNode limit node
161			*
162			* @return array an array of just record ids (the ids of the matching documents in solr)
163			*/
164	36		public function query(SearchNode $node, LimitNode $limitNode = null)
165			{
166	36		$client = $this->getClient();
167
168	36		$query = $client->createQuery($client::QUERY_SELECT);
169
170			// set the weights
171	36		$query->getEDisMax()->setQueryFields($this->solrMap[$this->className]);
172
173	36		$query->setQuery($this->getSearchTerm($node));
174
175	36		if ($limitNode instanceof LimitNode) {
176	36		$query->setStart($limitNode->getOffset())->setRows($limitNode->getLimit());
177			} else {
178			$query->setStart(0)->setRows($this->paginationDefaultLimit);
179			}
180
181	36		$query->setFields(['id']);
182
183	36		$result = $client->select($query);
184
185	36	View Code Duplication	if ($this->requestStack->getCurrentRequest() instanceof Request) {
186	36		$this->requestStack->getCurrentRequest()->attributes->set('totalCount', $result->getNumFound());
187	36		$this->requestStack->getCurrentRequest()->attributes->set('X-Search-Source', 'solr');
188			}
189
190	36		$idList = [];
191	36		foreach ($result as $document) {
192	2		if (isset($document->id)) {
193	2		$idList[] = (string) $document->id;
194			} elseif (isset($document->_id)) {
195	2		$idList[] = (string) $document->_id;
196			}
197			}
198
199	36		return $idList;
200			}
201
202			/**
203			* returns the string search term to be used in the solr query
204			*
205			* @param SearchNode $node the search node
206			*
207			* @return string the composed search query
208			*/
209	36		private function getSearchTerm(SearchNode $node)
210			{
211	36		$fullTerm = $node->getSearchQuery();
212
213	36		foreach ($this->fullTermPatterns as $pattern) {
214	36		if (preg_match($pattern, $fullTerm, $matches) === 1) {
215	36		return '"'.$fullTerm.'"';
216			}
217			}
218
219	34		if ($this->andifyTerms) {
220	32		$glue = 'AND';
221			} else {
222	2		$glue = '';
223			}
224
225
226	34		$i = 0;
227	34		$hasPreviousOperator = false;
228	34		$fullSearchElements = [];
229
230	34		foreach (explode(' ', $node->getSearchQuery()) as $term) {
231	34		$i++;
232
233			// is this an operator?
234	34		if (array_search($term, $this->queryOperators) !== false) {
235	8		$fullSearchElements[] = $term;
236	8		$hasPreviousOperator = true;
237	8		continue;
238			}
239
240	34		$singleTerm = $this->getSingleTerm($term);
241
242	34		if ($i > 1 && $hasPreviousOperator == false && !empty($glue)) {
243	8		$fullSearchElements[] = $glue;
244			} else {
245	34		$hasPreviousOperator = false;
246			}
247
248	34		$fullSearchElements[] = $singleTerm;
249			}
250
251	34		return implode(' ', $fullSearchElements);
252			}
253
254			/**
255			* returns a single term how to search. here we can apply custom logic to the user input string
256			*
257			* @param string $term single search term
258			*
259			* @return string modified search term
260			*/
261	34		private function getSingleTerm($term)
262			{
263			// we don't modify numbers
264	34		if (ctype_digit($term)) {
265	10		return '"'.$term.'"';
266			}
267
268			// formatted number?
269	32		$formatted = str_replace(
270			[
271	32		'-',
272			'.'
273			],
274	32		'',
275	16		$term
276			);
277	32		if (ctype_digit($formatted)) {
278			return '"'.$term.'"';
279			}
280
281			// everything that is only numbers and characters and at least 3 long, we don't fuzzy/wildcard
282			// thanks to https://stackoverflow.com/a/7684859/3762521
283	32		$pattern = '/^(?=.[0-9])(?=.[a-zA-Z])([a-zA-Z0-9]+)$/';
284	32		if (strlen($term) > 3 && preg_match($pattern, $term, $matches) === 1) {
285	4		return '"'.$term.'"';
286			}
287
288			// is it a solr field query (like id:333)?
289	28		if (preg_match($this->fieldQueryPattern, $term) === 1) {
290	8		return $this->parseSolrFieldQuery($term);
291			}
292
293			// strings shorter then 5 chars (like hans) we wildcard, all others we make fuzzy
294	28		if (strlen($term) >= $this->solrFuzzyBridge) {
295	20		return $this->doAndNotPrefixSingleTerm($term, '~');
296			}
297
298	14		if (strlen($term) >= $this->solrWildcardBridge) {
299	10		return $this->doAndNotPrefixSingleTerm($term, '*');
300			}
301
302	8		return $term;
303			}
304
305			/**
306			* parses the special solr field syntax fieldName:fieldValue, converts int ranges
307			*
308			* @param string $fieldQuery the query
309			*
310			* @return string solr compatible expression
311			*/
312	8		private function parseSolrFieldQuery($fieldQuery)
313			{
314	8		$fieldNameParts = explode(':', $fieldQuery);
315	8		$fieldName = $fieldNameParts[0];
316	8		unset($fieldNameParts[0]);
317	8		$fieldValue = implode(':', $fieldNameParts);
318
319			// change > and <
320	8		if ($fieldValue[0] == '<') {
321	2		$fieldValue = '[* TO '.substr($fieldValue, 1).']';
322	8		} elseif ($fieldValue[0] == '>') {
323	2		$fieldValue = '['.substr($fieldValue, 1).' TO *]';
324			} else {
325	8		$fieldValue = $this->getSingleTerm($fieldValue);
326			}
327
328	8		return $fieldName.':'.$fieldValue;
329			}
330
331			/**
332			* ORify a single term
333			*
334			* @param string $term search term
335			* @param string $modifier modified
336			*
337			* @return string ORified query
338			*/
339	24		private function doAndNotPrefixSingleTerm($term, $modifier)
340			{
341			// already modifier there?
342	24		$last = substr($term, -1);
343	24		if ($last == '~' \|\| $last == '*') {
344			// clean from term, override modifier from client
345	6		$modifier = $last;
346	6		$term = substr($term, 0, -1);
347			}
348
349	24		return sprintf(
350	24		'(%s OR %s%s)',
351	12		$term,
352	12		$term,
353	12		$modifier
354			);
355			}
356
357			/**
358			* returns the client to use for the current query
359			*
360			* @return Client client
361			*/
362	36		private function getClient()
363			{
364	36		$endpointConfig = $this->urlParts;
365	36		if (!isset($endpointConfig['path'])) {
366	34		$endpointConfig['path'] = '/';
367			}
368
369	36		if (substr($endpointConfig['path'], -1) != '/') {
370	2		$endpointConfig['path'] .= '/';
371			}
372
373			// find core name
374	36		$classnameParts = explode('\\', $this->className);
375	36		$endpointConfig['core'] = array_pop($classnameParts);
376
377	36		$endpointConfig['timeout'] = 10000;
378	36		$endpointConfig['key'] = 'local';
379
380	36		$this->solrClient->addEndpoint($endpointConfig);
381	36		$this->solrClient->setDefaultEndpoint($endpointConfig['key']);
382
383	36		return $this->solrClient;
384			}
385			}
386

libgraviton / graviton

SolrQuery::__construct() A last analyzed 2019-01-17 15:19 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like

SolrQuery::__construct() A
last analyzed 2019-01-17 15:19 UTC