ParameterResolver - Code Metrics - lexik/LexikPayboxBundle - Measure and Improve Code Quality continuously with Scrutinizer

ParameterResolver A
last analyzed 2017-09-27 09:06 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	183
Duplicated Lines	4.37 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	2
dl	8
loc	183
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	resolve()	0	9	1
A	initResolver()	8	8	1
A	initAllowed()	0	66	1
A	normalize()	0	10	3

How to fix Duplicated Code

<?php

namespace Lexik\Bundle\PayboxBundle\Paybox\DirectPlus;

use Lexik\Bundle\PayboxBundle\Paybox\AbstractParameterResolver;

/**
 * Class ParameterResolver
 * Based on PAYBOX DIRECT PLUS VERSION 6.2 documentation.
 *
 * @package Lexik\Bundle\PayboxBundle\Paybox\DirectPlus
 *
 * @author Lexik <[email protected]>
 * @author Olivier Maisonneuve <[email protected]>
 */
class ParameterResolver extends AbstractParameterResolver
{
    /**
     * @var array All availables parameters DirectPlus calls.
     */
    private $knownParameters = array(
        'VERSION'             => '%05d',
        'TYPE'                => '%05d',
        'SITE'                => '%07d',
        'RANG'                => '%03d',
        'CLE'                 => '%s',
        'NUMQUESTION'         => '%010d',
        'DATEQ'               => '%014s',
        'ACQUEREUR'           => null,
        'ACTIVITE'            => '%03d',
        'ARCHIVAGE'           => null,
        'AUTORISATION'        => null,
        'CODEREPONSE'         => null,
        'COMMENTAIRE'         => null,
        'CVV'                 => null,
        'DATENAISS'           => '%08d',
        'DATEVAL'             => null,
        'DEVISE'              => null,
        'DIFFERE'             => '%03d',
        'ERRORCODETEST'       => '%05d',
        'ID3D'                => null,
        'MONTANT'             => '%010d',
        'NUMAPPEL'            => '%010d',
        'NUMTRANS'            => '%010d',
        'PAYS'                => null,
        'PORTEUR'             => null,
        'PRIV_CODETRAITEMENT' => '%03d',
        'REFABONNE'           => null,
        'REFERENCE'           => null,
        'REMISE'              => null,
        'SHA-1'               => null,
        'STATUS'              => null,
        'TYPECARTE'           => null,
    );

    /**
     * @var array Requireds parameters for any DirectPlus call.
     */
    private $requiredParameters = array(
        'VERSION',
        'TYPE',
        'SITE',
        'RANG',
        'CLE',
        'NUMQUESTION',
        'DATEQ',
    );

    /**
     * @var array
     */
    private $currencies;

    /**
     * Constructor initialize all available parameters.
     *
     * @param array $currencies
     */
    public function __construct(array $currencies)
    {
        parent::__construct();

        $this->currencies = $currencies;
    }

    /**
     * {@inheritdoc}
     */
    public function resolve(array $parameters)
    {
        $this->initResolver();

        $result = $this->resolver->resolve($parameters);
        $result = $this->normalize($result);

        return $result;
    }

    /**
     * {@inheritdoc}
     */
    protected function initResolver()

    {
        $this->resolver->setRequired($this->requiredParameters);

        $this->resolver->setDefined(array_diff(array_keys($this->knownParameters), $this->requiredParameters));

        $this->initAllowed();
    }

    /**
     * Initialize allowed values.
     */
    protected function initAllowed()
    {
        $this->resolver
            ->setAllowedValues('ACTIVITE', array(
                '020',
                '021',
                '022',
                '023',
                '024',
                '027',
                20,
                21,
                22,
                23,
                24,
                27,
            ))
            ->setAllowedValues('DEVISE', $this->currencies)
            ->setAllowedValues('TYPE', array(
                '00001',
                '00002',
                '00003',
                '00004',
                '00005',
                '00011',
                '00012',
                '00013',
                '00014',
                '00017',
                '00051',
                '00052',
                '00053',
                '00054',
                '00055',
                '00056',
                '00057',
                '00058',
                '00061',
                1,
                2,
                3,
                4,
                5,
                11,
                12,
                13,
                14,
                17,
                51,
                52,
                53,
                54,
                55,
                56,
                57,
                58,
                61,
            ))
            ->setAllowedValues('VERSION', array(
                '00103',
                '00104',
                103,
                104,
            ))
        ;
    }

    /**
     * Normalizes parameters depending on Paybox's 6.2 parameters specifications.
     *
     * @param array $parameters
     *
     * @return array
     */
    protected function normalize(array $parameters)
    {
        foreach ($parameters as $parameter => $value) {
            if (null !== $this->knownParameters[$parameter]) {
                $parameters[$parameter] = sprintf($this->knownParameters[$parameter], $value);
            }
        }

        return $parameters;
    }
}


1		<?php
2
3		namespace Lexik\Bundle\PayboxBundle\Paybox\DirectPlus;
4
5		use Lexik\Bundle\PayboxBundle\Paybox\AbstractParameterResolver;
6
7		/**
8		* Class ParameterResolver
9		* Based on PAYBOX DIRECT PLUS VERSION 6.2 documentation.
10		*
11		* @package Lexik\Bundle\PayboxBundle\Paybox\DirectPlus
12		*
13		* @author Lexik <[email protected]>
14		* @author Olivier Maisonneuve <[email protected]>
15		*/
16		class ParameterResolver extends AbstractParameterResolver
17		{
18		/**
19		* @var array All availables parameters DirectPlus calls.
20		*/
21		private $knownParameters = array(
22		'VERSION' => '%05d',
23		'TYPE' => '%05d',
24		'SITE' => '%07d',
25		'RANG' => '%03d',
26		'CLE' => '%s',
27		'NUMQUESTION' => '%010d',
28		'DATEQ' => '%014s',
29		'ACQUEREUR' => null,
30		'ACTIVITE' => '%03d',
31		'ARCHIVAGE' => null,
32		'AUTORISATION' => null,
33		'CODEREPONSE' => null,
34		'COMMENTAIRE' => null,
35		'CVV' => null,
36		'DATENAISS' => '%08d',
37		'DATEVAL' => null,
38		'DEVISE' => null,
39		'DIFFERE' => '%03d',
40		'ERRORCODETEST' => '%05d',
41		'ID3D' => null,
42		'MONTANT' => '%010d',
43		'NUMAPPEL' => '%010d',
44		'NUMTRANS' => '%010d',
45		'PAYS' => null,
46		'PORTEUR' => null,
47		'PRIV_CODETRAITEMENT' => '%03d',
48		'REFABONNE' => null,
49		'REFERENCE' => null,
50		'REMISE' => null,
51		'SHA-1' => null,
52		'STATUS' => null,
53		'TYPECARTE' => null,
54		);
55
56		/**
57		* @var array Requireds parameters for any DirectPlus call.
58		*/
59		private $requiredParameters = array(
60		'VERSION',
61		'TYPE',
62		'SITE',
63		'RANG',
64		'CLE',
65		'NUMQUESTION',
66		'DATEQ',
67		);
68
69		/**
70		* @var array
71		*/
72		private $currencies;
73
74		/**
75		* Constructor initialize all available parameters.
76		*
77		* @param array $currencies
78		*/
79		public function __construct(array $currencies)
80		{
81		parent::__construct();
82
83		$this->currencies = $currencies;
84		}
85
86		/**
87		* {@inheritdoc}
88		*/
89		public function resolve(array $parameters)
90		{
91		$this->initResolver();
92
93		$result = $this->resolver->resolve($parameters);
94		$result = $this->normalize($result);
95
96		return $result;
97		}
98
99		/**
100		* {@inheritdoc}
101		*/
102	View Code Duplication	protected function initResolver()
		0 ignored issues – show Duplication introduced 2017-08-09 08:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		{
104		$this->resolver->setRequired($this->requiredParameters);
105
106		$this->resolver->setDefined(array_diff(array_keys($this->knownParameters), $this->requiredParameters));
107
108		$this->initAllowed();
109		}
110
111		/**
112		* Initialize allowed values.
113		*/
114		protected function initAllowed()
115		{
116		$this->resolver
117		->setAllowedValues('ACTIVITE', array(
118		'020',
119		'021',
120		'022',
121		'023',
122		'024',
123		'027',
124		20,
125		21,
126		22,
127		23,
128		24,
129		27,
130		))
131		->setAllowedValues('DEVISE', $this->currencies)
132		->setAllowedValues('TYPE', array(
133		'00001',
134		'00002',
135		'00003',
136		'00004',
137		'00005',
138		'00011',
139		'00012',
140		'00013',
141		'00014',
142		'00017',
143		'00051',
144		'00052',
145		'00053',
146		'00054',
147		'00055',
148		'00056',
149		'00057',
150		'00058',
151		'00061',
152		1,
153		2,
154		3,
155		4,
156		5,
157		11,
158		12,
159		13,
160		14,
161		17,
162		51,
163		52,
164		53,
165		54,
166		55,
167		56,
168		57,
169		58,
170		61,
171		))
172		->setAllowedValues('VERSION', array(
173		'00103',
174		'00104',
175		103,
176		104,
177		))
178		;
179		}
180
181		/**
182		* Normalizes parameters depending on Paybox's 6.2 parameters specifications.
183		*
184		* @param array $parameters
185		*
186		* @return array
187		*/
188		protected function normalize(array $parameters)
189		{
190		foreach ($parameters as $parameter => $value) {
191		if (null !== $this->knownParameters[$parameter]) {
192		$parameters[$parameter] = sprintf($this->knownParameters[$parameter], $value);
193		}
194		}
195
196		return $parameters;
197		}
198		}
199

lexik / LexikPayboxBundle

GitHub Access Token became invalid

ParameterResolver A last analyzed 2017-09-27 09:06 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ParameterResolver A
last analyzed 2017-09-27 09:06 UTC