AnyAggregator::toArray() - Code Metrics - Inspection of "Implemented DataSketches methods." - level23/druid-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#35)

by Teye

created 2022-04-09 09:20 UTC

AnyAggregator::toArray() A

↳ Parent: AnyAggregator

Complexity

Conditions	3
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	13
ccs	8
cts	8
cp	1
rs	10
cc	3
nc	2
nop	0
crap	3

<?php
declare(strict_types=1);

namespace Level23\Druid\Aggregations;

use Level23\Druid\Types\DataType;

class AnyAggregator extends MethodAggregator
{
    /**
     * @var int|null
     */
    protected $maxStringBytes;

    /**
     * constructor.
     *
     * @param string   $metricName
     * @param string   $outputName                          When not given, we will use the same name as the metric.
     * @param string   $type                                The type of field. This can either be "long", "float" or
     *                                                      "double"
     * @param int|null $maxStringBytes                      optional, defaults to 1024
     */
    public function __construct(
        string $metricName,
        string $outputName = '',
        string $type = 'long',
        int $maxStringBytes = null
    ) {
        $type = DataType::validate($type);

        $this->type           = $type;
        $this->metricName     = $metricName;
        $this->outputName     = $outputName ?: $metricName;
        $this->maxStringBytes = $maxStringBytes;
    }

    /**
     * Return the aggregator as it can be used in a druid query.
     *
     * @return array
     */
    public function toArray(): array
    {
        $response = [
            'type'      => $this->type . ucfirst($this->getMethod()),
            'name'      => $this->outputName,
            'fieldName' => $this->metricName,
        ];

        if ($this->type == DataType::STRING && $this->maxStringBytes !== null) {
            $response['maxStringBytes'] = $this->maxStringBytes;
        }

        return $response;
    }

    /**
     * Returns the method for the type aggregation
     *
     * @return string
     */
    protected function getMethod(): string
    {
        return 'any';
    }
}

1		<?php
2		declare(strict_types=1);
3
4		namespace Level23\Druid\Aggregations;
5
6		use Level23\Druid\Types\DataType;
7
8		class AnyAggregator extends MethodAggregator
9		{
10		/**
11		* @var int\|null
12		*/
13		protected $maxStringBytes;
14
15		/**
16		* constructor.
17		*
18		* @param string $metricName
19		* @param string $outputName When not given, we will use the same name as the metric.
20		* @param string $type The type of field. This can either be "long", "float" or
21		* "double"
22		* @param int\|null $maxStringBytes optional, defaults to 1024
23		*/
24	6	public function __construct(
25		string $metricName,
26		string $outputName = '',
27		string $type = 'long',
28		int $maxStringBytes = null
29		) {
30	6	$type = DataType::validate($type);
31
32	5	$this->type = $type;
33	5	$this->metricName = $metricName;
34	5	$this->outputName = $outputName ?: $metricName;
35	5	$this->maxStringBytes = $maxStringBytes;
36		}
37
38		/**
39		* Return the aggregator as it can be used in a druid query.
40		*
41		* @return array
42		*/
43	5	public function toArray(): array
44		{
45	5	$response = [
46	5	'type' => $this->type . ucfirst($this->getMethod()),
47	5	'name' => $this->outputName,
48	5	'fieldName' => $this->metricName,
49		];
50
51	5	if ($this->type == DataType::STRING && $this->maxStringBytes !== null) {
52	1	$response['maxStringBytes'] = $this->maxStringBytes;
53		}
54
55	5	return $response;
56		}
57
58		/**
59		* Returns the method for the type aggregation
60		*
61		* @return string
62		*/
63	5	protected function getMethod(): string
64		{
65	5	return 'any';
66		}
67		}

level23 / druid-client

Pull Request — master (#35)

AnyAggregator::toArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like