LocalInputSource::toArray() - Code Metrics - Inspection of "V2.0" - level23/druid-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Retried Inspection

Pull Request — master (#38)

by Teye

created 2022-07-15 09:28 UTC

LocalInputSource::toArray() A

↳ Parent: LocalInputSource

Complexity

Conditions	4
Paths	8

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes

Metric	Value
eloc	9
c	0
b	0
f	0
dl	0
loc	19
ccs	9
cts	9
cp	1
rs	9.9666
cc	4
nc	8
nop	0
crap	4

<?php
declare(strict_types=1);

namespace Level23\Druid\InputSources;

use InvalidArgumentException;

class LocalInputSource implements InputSourceInterface
{
    protected ?string $baseDir;

    /**
     * @var string[]
     */
    protected array $files;

    protected ?string $filter;

    /**
     * @param string[]    $files
     * @param string|null $baseDir
     * @param string|null $filter
     */
    public function __construct(array $files = [], ?string $baseDir = null, ?string $filter = null)
    {
        if (empty($baseDir) && count($files) == 0) {
            throw new InvalidArgumentException('You have to specify either $baseDir or $files');
        }

        if (
            (!empty($baseDir) && empty($filter))
            ||
            (empty($baseDir) && !empty($filter))
        ) {
            throw new InvalidArgumentException('You have to specify both $filter and $baseDir to make use of these!');
        }

        $this->baseDir = $baseDir;
        $this->filter  = $filter;
        $this->files   = $files;
    }

    /**
     * @return array<string,string|string[]>
     */
    public function toArray(): array
    {
        $response = [
            'type' => 'local',
        ];

        if (count($this->files) > 0) {
            $response['files'] = $this->files;
        }

        if (!empty($this->baseDir)) {
            $response['baseDir'] = $this->baseDir;
        }

        if (!empty($this->filter)) {
            $response['filter'] = $this->filter;
        }

        return $response;
    }
}

1		<?php
2		declare(strict_types=1);
3
4		namespace Level23\Druid\InputSources;
5
6		use InvalidArgumentException;
7
8		class LocalInputSource implements InputSourceInterface
9		{
10		protected ?string $baseDir;
11
12		/**
13		* @var string[]
14		*/
15		protected array $files;
16
17		protected ?string $filter;
18
19		/**
20		* @param string[] $files
21		* @param string\|null $baseDir
22		* @param string\|null $filter
23		*/
24	8	public function __construct(array $files = [], ?string $baseDir = null, ?string $filter = null)
25		{
26	8	if (empty($baseDir) && count($files) == 0) {
27	1	throw new InvalidArgumentException('You have to specify either $baseDir or $files');
28		}
29
30		if (
31	7	(!empty($baseDir) && empty($filter))
32		\|\|
33	7	(empty($baseDir) && !empty($filter))
34		) {
35	2	throw new InvalidArgumentException('You have to specify both $filter and $baseDir to make use of these!');
36		}
37
38	5	$this->baseDir = $baseDir;
39	5	$this->filter = $filter;
40	5	$this->files = $files;
41		}
42
43		/**
44		* @return array<string,string\|string[]>
45		*/
46	4	public function toArray(): array
47		{
48	4	$response = [
49		'type' => 'local',
50		];
51
52	4	if (count($this->files) > 0) {
53	3	$response['files'] = $this->files;
54		}
55
56	4	if (!empty($this->baseDir)) {
57	2	$response['baseDir'] = $this->baseDir;
58		}
59
60	4	if (!empty($this->filter)) {
61	2	$response['filter'] = $this->filter;
62		}
63
64	4	return $response;
65		}
66		}

level23 / druid-client

Pull Request — master (#38)

LocalInputSource::toArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like