HttpInputSource::toArray() - Code Metrics - Inspection of "V2.0" - level23/druid-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Retried Inspection

Pull Request — master (#38)

by Teye

created 2022-07-15 09:28 UTC

HttpInputSource::toArray() A

↳ Parent: HttpInputSource

Complexity

Conditions	3
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
eloc	8
c	0
b	0
f	0
dl	0
loc	16
ccs	8
cts	8
cp	1
rs	10
cc	3
nc	4
nop	0
crap	3

<?php
declare(strict_types=1);

namespace Level23\Druid\InputSources;

class HttpInputSource implements InputSourceInterface
{
    /**
     * @var string[]
     */
    protected array $uris;

    protected ?string $username;

    /**
     * @var null|string|string[]
     */
    protected $password;

    /**
     * HttpInputSource constructor.
     *
     * @param string[]             $uris
     * @param string|null          $username
     * @param null|string|string[] $password
     */
    public function __construct(array $uris, ?string $username = null, $password = null)
    {
        $this->uris     = $uris;
        $this->username = $username;
        $this->password = $password;
    }

    /**
     * @return array<string,string|string[]>
     */
    public function toArray(): array
    {
        $response = [
            'type' => 'http',
            'uris' => $this->uris,
        ];

        if (!empty($this->username)) {
            $response['httpAuthenticationUsername'] = $this->username;
        }

        if (!empty($this->password)) {
            $response['httpAuthenticationPassword'] = $this->password;
        }

        return $response;
    }
}

1		<?php
2		declare(strict_types=1);
3
4		namespace Level23\Druid\InputSources;
5
6		class HttpInputSource implements InputSourceInterface
7		{
8		/**
9		* @var string[]
10		*/
11		protected array $uris;
12
13		protected ?string $username;
14
15		/**
16		* @var null\|string\|string[]
17		*/
18		protected $password;
19
20		/**
21		* HttpInputSource constructor.
22		*
23		* @param string[] $uris
24		* @param string\|null $username
25		* @param null\|string\|string[] $password
26		*/
27	4	public function __construct(array $uris, ?string $username = null, $password = null)
28		{
29	4	$this->uris = $uris;
30	4	$this->username = $username;
31	4	$this->password = $password;
32		}
33
34		/**
35		* @return array<string,string\|string[]>
36		*/
37	2	public function toArray(): array
38		{
39	2	$response = [
40		'type' => 'http',
41	2	'uris' => $this->uris,
42		];
43
44	2	if (!empty($this->username)) {
45	1	$response['httpAuthenticationUsername'] = $this->username;
46		}
47
48	2	if (!empty($this->password)) {
49	1	$response['httpAuthenticationPassword'] = $this->password;
50		}
51
52	2	return $response;
53		}
54		}

level23 / druid-client

Pull Request — master (#38)

HttpInputSource::toArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like