NodePath::count() - Code Metrics - letournel/path-finder - Measure and Improve Code Quality continuously with Scrutinizer

NodePath::count() A
last analyzed 2017-07-23 14:48 UTC

↳ Parent: NodePath

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Letournel\PathFinder\Core;

use Letournel\PathFinder\Distance;

class NodePath implements \Countable, \Iterator
{
    private
        $path,
class A {
    var $property;
}
        $valid;
    
    public function __construct(array $path)
    {
        $this->path = array();
        $this->valid = true;
        foreach($path as $node)
        {
            if($node instanceof Node)
            {
                $this->path[$node->getId()] = $node;
            }
        }
    }
    
    public function count()
    {
        return count($this->path);
    }
    
    public function current()
    {
        return current($this->path);
    }
    
    public function key()
    {
        return key($this->path);
    }
    
    public function next()
    {
        $this->valid = (next($this->path) !== false);
    }
    
    public function rewind()
    {
        reset($this->path);
        $this->valid = true;
    }
    
    public function valid()
    {
        return $this->valid;
    }
    
    public function getKey($key)
    {
        return $this->path[$key];
    }
    
    public function getKeys()
    {
        return array_keys($this->path);
    }
    
    public function computeLength(Distance $distance)

    {
        $length = 0;
        $prevNode = null;
        foreach($this->path as $node)
        {
            if($prevNode === null)
            {
                $prevNode = $node;
                continue;
            }
            
            $length += $distance->compute($prevNode, $node);
            $prevNode = $node;
        }
        
        return $length;
    }
    
    public function contains(Node $needleNode)
    {
        foreach($this->path as $node)
        {
            if($node->toString() == $needleNode->toString())
            {
                return true;
            }
        }
        
        return false;
    }
    
    public function getStartNode()
    {
        return reset($this->path);
    }
    
    public function getEndNode()
    {
        return end($this->path);
    }
    
    public function toString()
    {
        $nodesString = array();
        foreach($this->path as $node)
        {
            $nodesString[] = $node->toString();
        }
        
        return implode('->', $nodesString);
    }
}


1		<?php
2
3		namespace Letournel\PathFinder\Core;
4
5		use Letournel\PathFinder\Distance;
6
7		class NodePath implements \Countable, \Iterator
8		{
9		private
10		$path,
		0 ignored issues – show Coding Style introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$path`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
11		$valid;
12
13		public function __construct(array $path)
14		{
15		$this->path = array();
16		$this->valid = true;
17		foreach($path as $node)
18		{
19		if($node instanceof Node)
20		{
21		$this->path[$node->getId()] = $node;
22		}
23		}
24		}
25
26		public function count()
27		{
28		return count($this->path);
29		}
30
31		public function current()
32		{
33		return current($this->path);
34		}
35
36		public function key()
37		{
38		return key($this->path);
39		}
40
41		public function next()
42		{
43		$this->valid = (next($this->path) !== false);
44		}
45
46		public function rewind()
47		{
48		reset($this->path);
49		$this->valid = true;
50		}
51
52		public function valid()
53		{
54		return $this->valid;
55		}
56
57		public function getKey($key)
58		{
59		return $this->path[$key];
60		}
61
62		public function getKeys()
63		{
64		return array_keys($this->path);
65		}
66
67	View Code Duplication	public function computeLength(Distance $distance)
		0 ignored issues – show Duplication introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		$length = 0;
70		$prevNode = null;
71		foreach($this->path as $node)
72		{
73		if($prevNode === null)
74		{
75		$prevNode = $node;
76		continue;
77		}
78
79		$length += $distance->compute($prevNode, $node);
80		$prevNode = $node;
81		}
82
83		return $length;
84		}
85
86		public function contains(Node $needleNode)
87		{
88		foreach($this->path as $node)
89		{
90		if($node->toString() == $needleNode->toString())
91		{
92		return true;
93		}
94		}
95
96		return false;
97		}
98
99		public function getStartNode()
100		{
101		return reset($this->path);
102		}
103
104		public function getEndNode()
105		{
106		return end($this->path);
107		}
108
109		public function toString()
110		{
111		$nodesString = array();
112		foreach($this->path as $node)
113		{
114		$nodesString[] = $node->toString();
115		}
116
117		return implode('->', $nodesString);
118		}
119		}
120

letournel / path-finder

GitHub Access Token became invalid

NodePath::count() A last analyzed 2017-07-23 14:48 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

NodePath::count() A
last analyzed 2017-07-23 14:48 UTC