ThreeOpt::computeRoute() - Code Metrics - letournel/path-finder - Measure and Improve Code Quality continuously with Scrutinizer

ThreeOpt::computeRoute() C
last analyzed 2017-07-23 14:48 UTC

↳ Parent: ThreeOpt

Complexity

Conditions	12
Paths	9

Size

Total Lines	47
Code Lines	24

Duplication

Lines	8
Ratio	17.02 %

Importance

Changes

Metric	Value
dl	8
loc	47
rs	5.1384
c	0
b	0
f	0
cc	12
eloc	24
nc	9
nop	0

How to fix Complexity

<?php

namespace Letournel\PathFinder\Algorithms\TravelingSalesman;

use Letournel\PathFinder\AlgorithmTravelingSalesman;
use Letournel\PathFinder\Core\Node;
use Letournel\PathFinder\Core\NodeGraph;
use Letournel\PathFinder\Core\NodePath;

class ThreeOpt implements AlgorithmTravelingSalesman
{
    /*
     * For more info see
     * http://en.wikipedia.org/wiki/3-opt
     */
    
    private
        $existingRoute,
class A {
    var $property;
}
        $graph;
    
    public function setExistingRoute(NodePath $existingRoute)
    {
        $this->existingRoute = $existingRoute;
    }
    
    public function setGraph(NodeGraph $graph)
    {
        $this->graph = $graph;
    }
    
    public function computeRoute()
    {
        if(! $this->graph instanceof NodeGraph)
        {
            throw new \RuntimeException('Invalid Graph');
        }
        if(! $this->existingRoute instanceof NodePath)
        {
            throw new \RuntimeException('Invalid ExistingRoute');
        }
        if(count($this->existingRoute) < 3)
        {
            return $this->existingRoute;
        }
        
        $existingDistance = $this->graph->computeLength($this->existingRoute);
        
        do
        {
            $improvementMade = false;
            foreach($this->existingRoute->getKeys() as $iKey)
            {
                foreach($this->existingRoute->getKeys() as $jKey)
                {
                    foreach($this->existingRoute->getKeys() as $kKey)
                    {
                        if($iKey == $jKey || $iKey == $kKey || $jKey == $kKey)
                        {
                            continue;
                        }
                        $newRoute = $this->threeOptSwap($iKey, $jKey, $kKey);
                        $newDistance = $this->graph->computeLength($newRoute);
                        if($newDistance < $existingDistance)

                        {
                            $this->existingRoute = $newRoute;
                            $existingDistance = $newDistance;
                            $improvementMade = true;
                            
                            break 3;
                        }
                    }
                }
            }
        } while($improvementMade);
        
        return $this->existingRoute;
    }
    
    private function threeOptSwap($iKey, $jKey, $kKey)
    {
        $newRouteNodes = array();
        foreach($this->existingRoute->getKeys() as $key)
        {
            if ($key === $iKey)
            {
                $newRouteNodes[] = $this->existingRoute->getKey($kKey);
            }
            elseif($key === $jKey)
            {
                $newRouteNodes[] = $this->existingRoute->getKey($iKey);
            }
            elseif($key === $kKey)
            {
                $newRouteNodes[] = $this->existingRoute->getKey($jKey);
            }
            else
            {
                $newRouteNodes[] = $this->existingRoute->getKey($key);
            }
        }
        
        return new NodePath($newRouteNodes);
    }
}


1		<?php
2
3		namespace Letournel\PathFinder\Algorithms\TravelingSalesman;
4
5		use Letournel\PathFinder\AlgorithmTravelingSalesman;
6		use Letournel\PathFinder\Core\Node;
7		use Letournel\PathFinder\Core\NodeGraph;
8		use Letournel\PathFinder\Core\NodePath;
9
10		class ThreeOpt implements AlgorithmTravelingSalesman
11		{
12		/*
13		* For more info see
14		* http://en.wikipedia.org/wiki/3-opt
15		*/
16
17		private
18		$existingRoute,
		0 ignored issues – show Coding Style introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$existingRoute`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
19		$graph;
20
21		public function setExistingRoute(NodePath $existingRoute)
22		{
23		$this->existingRoute = $existingRoute;
24		}
25
26		public function setGraph(NodeGraph $graph)
27		{
28		$this->graph = $graph;
29		}
30
31		public function computeRoute()
32		{
33		if(! $this->graph instanceof NodeGraph)
34		{
35		throw new \RuntimeException('Invalid Graph');
36		}
37		if(! $this->existingRoute instanceof NodePath)
38		{
39		throw new \RuntimeException('Invalid ExistingRoute');
40		}
41		if(count($this->existingRoute) < 3)
42		{
43		return $this->existingRoute;
44		}
45
46		$existingDistance = $this->graph->computeLength($this->existingRoute);
47
48		do
49		{
50		$improvementMade = false;
51		foreach($this->existingRoute->getKeys() as $iKey)
52		{
53		foreach($this->existingRoute->getKeys() as $jKey)
54		{
55		foreach($this->existingRoute->getKeys() as $kKey)
56		{
57		if($iKey == $jKey \|\| $iKey == $kKey \|\| $jKey == $kKey)
58		{
59		continue;
60		}
61		$newRoute = $this->threeOptSwap($iKey, $jKey, $kKey);
62		$newDistance = $this->graph->computeLength($newRoute);
63	View Code Duplication	if($newDistance < $existingDistance)
		0 ignored issues – show Duplication introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$this->existingRoute = $newRoute;
66		$existingDistance = $newDistance;
67		$improvementMade = true;
68
69		break 3;
70		}
71		}
72		}
73		}
74		} while($improvementMade);
75
76		return $this->existingRoute;
77		}
78
79		private function threeOptSwap($iKey, $jKey, $kKey)
80		{
81		$newRouteNodes = array();
82		foreach($this->existingRoute->getKeys() as $key)
83		{
84		if ($key === $iKey)
85		{
86		$newRouteNodes[] = $this->existingRoute->getKey($kKey);
87		}
88		elseif($key === $jKey)
89		{
90		$newRouteNodes[] = $this->existingRoute->getKey($iKey);
91		}
92		elseif($key === $kKey)
93		{
94		$newRouteNodes[] = $this->existingRoute->getKey($jKey);
95		}
96		else
97		{
98		$newRouteNodes[] = $this->existingRoute->getKey($key);
99		}
100		}
101
102		return new NodePath($newRouteNodes);
103		}
104		}
105

GitHub Access Token became invalid

ThreeOpt::computeRoute() C
last analyzed 2017-07-23 14:48 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

letournel / path-finder

GitHub Access Token became invalid

ThreeOpt::computeRoute() C last analyzed 2017-07-23 14:48 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

ThreeOpt::computeRoute() C
last analyzed 2017-07-23 14:48 UTC