AStar::computePath() - Code Metrics - letournel/path-finder - Measure and Improve Code Quality continuously with Scrutinizer

AStar::computePath() C
last analyzed 2017-07-23 14:48 UTC

↳ Parent: AStar

Complexity

Conditions	8
Paths	7

Size

Total Lines	50
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	50
rs	6.3636
c	0
b	0
f	0
cc	8
eloc	28
nc	7
nop	2

<?php

namespace Letournel\PathFinder\Algorithms\ShortestPath;

use Letournel\PathFinder\AlgorithmShortestPath;
use Letournel\PathFinder\Core\Heuristic;
use Letournel\PathFinder\Core\Node;
use Letournel\PathFinder\Core\NodeGrid;
use Letournel\PathFinder\Core\NodeMap;
use Letournel\PathFinder\Core\NodePath;
use Letournel\PathFinder\Core\NodePriorityQueueMin;
use Letournel\PathFinder\Distance;

class AStar implements AlgorithmShortestPath
{
    /*
     * For more info see
     * http://en.wikipedia.org/wiki/A*_search_algorithm
     */
    
    private
        $distance,
class A {
    var $property;
}
        $grid,
        $heuristic;
    
    public function __construct(Distance $distance, Heuristic $heuristic)
    {
        $this->distance = $distance;
        $this->heuristic = $heuristic;
    }
    
    public function setGrid(NodeGrid $grid)
    {
        $this->grid = $grid;
    }
    
    public function computeLength(Node $source, Node $target)
    {
        $shortestPath = $this->computePath($source, $target);
        
        return $shortestPath->computeLength($this->distance);
    }
    
    public function computePath(Node $source, Node $target)
    {
        if(! $this->grid instanceof NodeGrid)
        {
            throw new \RuntimeException('Invalid Grid');
        }
        
        $fScorePriorityQueue = new NodePriorityQueueMin();
        $gScoreMap = new NodeMap();
        $openedMap = new NodeMap();
        $closedMap = new NodeMap();
        $previousMap = new NodeMap();
        
        $fScorePriorityQueue->insert($source, 0);
        $gScoreMap->insert($source, 0);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $openedMap->insert($source);
        
        while(! $fScorePriorityQueue->isEmpty())
        {
            $node = $fScorePriorityQueue->extract();
            $closedMap->insert($node);
            
            if($node->getId() === $target->getId())
            {
                return new NodePath($previousMap->lookupFrom($node));
            }
            
            $neighbors = $this->grid->getWalkableNeighbors($node);
            foreach($neighbors as $neighbor)
            {
                if($closedMap->exists($neighbor))
                {
                    continue;
                }
                
                $gScore = $gScoreMap->lookup($node) + $this->distance->compute($node, $neighbor);
                if(! $openedMap->exists($neighbor) || $gScore < $gScoreMap->lookup($neighbor))
                {
                    $fScore = $gScore + $this->heuristic->compute($node, $target);
                    $fScorePriorityQueue->insert($neighbor, $fScore);
                    $gScoreMap->insert($neighbor, $gScore);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $openedMap->insert($neighbor);
                    $previousMap->insert($neighbor, $node);
                }
            }
        }
        
        // no path found
        return array();
    }
}


1			<?php
2
3			namespace Letournel\PathFinder\Algorithms\ShortestPath;
4
5			use Letournel\PathFinder\AlgorithmShortestPath;
6			use Letournel\PathFinder\Core\Heuristic;
7			use Letournel\PathFinder\Core\Node;
8			use Letournel\PathFinder\Core\NodeGrid;
9			use Letournel\PathFinder\Core\NodeMap;
10			use Letournel\PathFinder\Core\NodePath;
11			use Letournel\PathFinder\Core\NodePriorityQueueMin;
12			use Letournel\PathFinder\Distance;
13
14			class AStar implements AlgorithmShortestPath
15			{
16			/*
17			* For more info see
18			* http://en.wikipedia.org/wiki/A*_search_algorithm
19			*/
20
21			private
22			$distance,
			0 ignored issues – show Coding Style introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$distance`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
23			$grid,
24			$heuristic;
25
26			public function __construct(Distance $distance, Heuristic $heuristic)
27			{
28			$this->distance = $distance;
29			$this->heuristic = $heuristic;
30			}
31
32			public function setGrid(NodeGrid $grid)
33			{
34			$this->grid = $grid;
35			}
36
37			public function computeLength(Node $source, Node $target)
38			{
39			$shortestPath = $this->computePath($source, $target);
40
41			return $shortestPath->computeLength($this->distance);
42			}
43
44			public function computePath(Node $source, Node $target)
45			{
46			if(! $this->grid instanceof NodeGrid)
47			{
48			throw new \RuntimeException('Invalid Grid');
49			}
50
51			$fScorePriorityQueue = new NodePriorityQueueMin();
52			$gScoreMap = new NodeMap();
53			$openedMap = new NodeMap();
54			$closedMap = new NodeMap();
55			$previousMap = new NodeMap();
56
57			$fScorePriorityQueue->insert($source, 0);
58			$gScoreMap->insert($source, 0);
			0 ignored issues – show Documentation introduced 2017-07-23 12:56 UTC by Report Bug Copy Issue Report `0` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59			$openedMap->insert($source);
60
61			while(! $fScorePriorityQueue->isEmpty())
62			{
63			$node = $fScorePriorityQueue->extract();
64			$closedMap->insert($node);
65
66			if($node->getId() === $target->getId())
67			{
68			return new NodePath($previousMap->lookupFrom($node));
69			}
70
71			$neighbors = $this->grid->getWalkableNeighbors($node);
72			foreach($neighbors as $neighbor)
73			{
74			if($closedMap->exists($neighbor))
75			{
76			continue;
77			}
78
79			$gScore = $gScoreMap->lookup($node) + $this->distance->compute($node, $neighbor);
80			if(! $openedMap->exists($neighbor) \|\| $gScore < $gScoreMap->lookup($neighbor))
81			{
82			$fScore = $gScore + $this->heuristic->compute($node, $target);
83			$fScorePriorityQueue->insert($neighbor, $fScore);
84			$gScoreMap->insert($neighbor, $gScore);
			0 ignored issues – show Documentation introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report `$gScore` is of type `double`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85			$openedMap->insert($neighbor);
86			$previousMap->insert($neighbor, $node);
87			}
88			}
89			}
90
91			// no path found
92			return array();
93			}
94			}
95

letournel / path-finder

GitHub Access Token became invalid

AStar::computePath() C last analyzed 2017-07-23 14:48 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AStar::computePath() C
last analyzed 2017-07-23 14:48 UTC