JiraRestApi\IssueType\IssueTypeService

Complexity

Total Complexity

1

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getAll()	0	9	1

<?php

namespace JiraRestApi\IssueType;

use JiraRestApi\JiraException;
use JsonMapper_Exception;

class IssueTypeService extends \JiraRestApi\JiraClient
{
    private $uri = '/issuetype';

    /**
     * get all issuetypes.
     *
     * @throws JiraException
     * @throws JsonMapper_Exception
     *
     * @return IssueType[] array of Project class
     */
    public function getAll()
    {
        $ret = $this->exec($this->uri.'/', null);
        $this->log->info("Result=\n".$ret);

Are you sure $ret of type string|true can be used in concatenation?

        return $this->json_mapper->mapArray(
            json_decode($ret, false),

It seems like $ret can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            new \ArrayObject(),
            \JiraRestApi\Issue\IssueType::class
        );
    }
}