JiraRestApi\Issue\VisibilityTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	setVisibility()	0	17	4

<?php

namespace JiraRestApi\Issue;

trait VisibilityTrait {

    /**
     *
     * @param Visibility $type
     * @param null       $value

Are you sure the doc-type for parameter $value is correct as it would always require null to be passed?

     *
     * @return $this
     */
    public function setVisibility($type, $value = null)
    {
        if (is_null($this->visibility)) {
            $this->visibility = new Visibility();

The property visibility does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        if (is_array($type)) {

The condition is_array($type) is always false.

            $this->visibility->setType($type['type']);
            $this->visibility->setValue($type['value']);
        } elseif ($type instanceof Visibility) {

$type is always a sub-type of JiraRestApi\Issue\Visibility.

            $this->visibility = $type;
        } else {
            $this->visibility->setType($type);
            $this->visibility->setValue($value);
        }

        return $this;
    }
}