Response::checkForErrors() - Code Metrics - leroy-merlin-br/laravel-axado-api - Measure and Improve Code Quality continuously with Scrutinizer

Response::checkForErrors() A
last analyzed 2017-09-04 17:49 UTC

↳ Parent: Response

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	2
eloc	4
nc	2
nop	1

<?php
namespace Axado;

use Axado\Exception\DestinationNotFoundException;
use Axado\Exception\OriginNotFoundException;
use Axado\Exception\ShippingException;

class Response
{
    /**
     * Relevant errors from Axado API that are mapped to exceptions.
     *
     * @var array
     */
    private static $translatedErrors = [
        101 => OriginNotFoundException::class,
        102 => DestinationNotFoundException::class,
    ];

    /**
     * Array of Axado\Quotation.
     *
     * @var array
     */
    protected $quotations = [];

    /**
     * Getter for quotations.
     *
     * @return array
     */
    public function quotations(): array
    {
        return $this->quotations;
    }

    /**
     * Parse the raw response to this object.
     *
     * @param array|null $raw
     */
    public function parse($raw = null)
    {
        $arrayResponse = (array) $raw;
        $this->checkForErrors($arrayResponse);

        $this->parseQuotations($arrayResponse);
    }

    /**
     * Verify if this Response has an error.
     *
     * @throws ShippingException
     *
     * @param array $arrayResponse
     */
    protected function checkForErrors($arrayResponse)
    {
        if ($errorId = $arrayResponse['erro_id'] ?? null) {
            $exceptionClass = static::$translatedErrors[$errorId] ?? ShippingException::class;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}

            throw new $exceptionClass($arrayResponse['erro_msg'], $errorId);
        }
    }

    /**
     * Parse the response into Quotation objects.
     *
     * @param array $arrayResponse
     */
    protected function parseQuotations(array $arrayResponse)
    {
        $quotationsArray = $arrayResponse['cotacoes'] ?? [];

        foreach ($quotationsArray as $quotationData) {
            $quotation = new Quotation();
            $quotation->fill($quotationData);
            $this->quotations[] = $quotation;
        }
    }
}


1			<?php
2			namespace Axado;
3
4			use Axado\Exception\DestinationNotFoundException;
5			use Axado\Exception\OriginNotFoundException;
6			use Axado\Exception\ShippingException;
7
8			class Response
9			{
10			/**
11			* Relevant errors from Axado API that are mapped to exceptions.
12			*
13			* @var array
14			*/
15			private static $translatedErrors = [
16			101 => OriginNotFoundException::class,
17			102 => DestinationNotFoundException::class,
18			];
19
20			/**
21			* Array of Axado\Quotation.
22			*
23			* @var array
24			*/
25			protected $quotations = [];
26
27			/**
28			* Getter for quotations.
29			*
30			* @return array
31			*/
32			public function quotations(): array
33			{
34			return $this->quotations;
35			}
36
37			/**
38			* Parse the raw response to this object.
39			*
40			* @param array\|null $raw
41			*/
42			public function parse($raw = null)
43			{
44			$arrayResponse = (array) $raw;
45			$this->checkForErrors($arrayResponse);
46
47			$this->parseQuotations($arrayResponse);
48			}
49
50			/**
51			* Verify if this Response has an error.
52			*
53			* @throws ShippingException
54			*
55			* @param array $arrayResponse
56			*/
57			protected function checkForErrors($arrayResponse)
58			{
59			if ($errorId = $arrayResponse['erro_id'] ?? null) {
60			$exceptionClass = static::$translatedErrors[$errorId] ?? ShippingException::class;
			0 ignored issues – show Bug introduced 2017-08-31 21:15 UTC by Report Bug Copy Issue Report Since `$translatedErrors` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$translatedErrors` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
61
62			throw new $exceptionClass($arrayResponse['erro_msg'], $errorId);
63			}
64			}
65
66			/**
67			* Parse the response into Quotation objects.
68			*
69			* @param array $arrayResponse
70			*/
71			protected function parseQuotations(array $arrayResponse)
72			{
73			$quotationsArray = $arrayResponse['cotacoes'] ?? [];
74
75			foreach ($quotationsArray as $quotationData) {
76			$quotation = new Quotation();
77			$quotation->fill($quotationData);
78			$this->quotations[] = $quotation;
79			}
80			}
81			}
82

leroy-merlin-br / laravel-axado-api

Response::checkForErrors() A last analyzed 2017-09-04 17:49 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Response::checkForErrors() A
last analyzed 2017-09-04 17:49 UTC