ResponseFieldsTrait::getDataItem() - Code Metrics - Inspection of "Added ServerNotifyRequest for acceptNotification" - leonardjke/omnipay-yoomoney - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — main ( 7136de...6d50be )

by Leonard

created 2021-02-14 11:26 UTC

ResponseFieldsTrait::getDataItem() A

↳ Parent: ResponseFieldsTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	6

<?php

namespace Omnipay\YooMoney\Traits;

trait ResponseFieldsTrait
{

    /**
     * Get a POST data item, or null if not present.
     *
     * @param string $name The key for the field.
     * @param mixed $default The value to return if the data item is not found at all, or is null.
     *
     * @return mixed           The value of the field, often a string, but could be case to anything..
     */
    protected function getDataItem($name, $default = null)
    {
        return isset($this->data[$name]) ? $this->data[$name] : $default;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function getLabel()
    {
        return $this->getTransactionId();
    }

    public function getAccount()
    {
        return $this->getTransactionId();
    }

    public function getTransactionId()
    {
        return $this->getDataItem('label');
    }

    public function getTransactionReference()
    {
        return $this->getDataItem('operation_id');
    }

    public function getOperationId()
    {
        return $this->getTransactionReference();
    }

    public function getAmount()
    {
        return $this->formatCurrency($this->getDataItem('amount', 0));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getWithdrawAmount()
    {
        return $this->formatCurrency($this->getDataItem('withdraw_amount', 0));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getCurrency()
    {
        return 'RUB';
    }

    public function getNotificationType()
    {
        return $this->getDataItem('notification_type');
    }

    public function getBillId()
    {
        return $this->getDataItem('bill_id');
    }

    public function getCodePro()
    {
        return $this->getDataItem('codepro');
    }

    public function getUnaccepted()
    {
        return $this->getDataItem('unaccepted');
    }

    public function getDatetime()
    {
        return $this->getDataItem('datetime');
    }

    public function getSender()
    {
        return $this->getDataItem('sender');
    }

    public function getSha1Hash()
    {
        return $this->getDataItem('sha1_hash');
    }

    public function getOperationLabel()
    {
        return $this->getDataItem('operation_label');
    }

    public function getTestMode()
    {
        return $this->getDataItem('test_notification', false);
    }

    public function getLastName()
    {
        return $this->getDataItem('lastname');
    }

    public function getFirstname()
    {
        return $this->getDataItem('firstname');
    }

    public function getFathersname()
    {
        return $this->getDataItem('fathersname');
    }

    public function getEmail()
    {
        return $this->getDataItem('email');
    }

    public function getPhone()
    {
        return $this->getDataItem('phone');
    }

    public function getCity()
    {
        return $this->getDataItem('city');
    }

    public function getStreet()
    {
        return $this->getDataItem('street');
    }

    public function getBuilding()
    {
        return $this->getDataItem('building');
    }

    public function getSuite()
    {
        return $this->getDataItem('suite');
    }

    public function getFlat()
    {
        return $this->getDataItem('flat');
    }

    public function getZip()
    {
        return $this->getDataItem('zip');
    }

}


1			<?php
2
3			namespace Omnipay\YooMoney\Traits;
4
5			trait ResponseFieldsTrait
6			{
7
8			/**
9			* Get a POST data item, or null if not present.
10			*
11			* @param string $name The key for the field.
12			* @param mixed $default The value to return if the data item is not found at all, or is null.
13			*
14			* @return mixed The value of the field, often a string, but could be case to anything..
15			*/
16			protected function getDataItem($name, $default = null)
17			{
18			return isset($this->data[$name]) ? $this->data[$name] : $default;
			0 ignored issues – show Bug introduced 2021-02-14 11:30 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			}
20
21			public function getLabel()
22			{
23			return $this->getTransactionId();
24			}
25
26			public function getAccount()
27			{
28			return $this->getTransactionId();
29			}
30
31			public function getTransactionId()
32			{
33			return $this->getDataItem('label');
34			}
35
36			public function getTransactionReference()
37			{
38			return $this->getDataItem('operation_id');
39			}
40
41			public function getOperationId()
42			{
43			return $this->getTransactionReference();
44			}
45
46			public function getAmount()
47			{
48			return $this->formatCurrency($this->getDataItem('amount', 0));
			0 ignored issues – show Bug introduced 2021-02-14 11:30 UTC by Report Bug Copy Issue Report It seems like `formatCurrency()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
49			}
50
51			public function getWithdrawAmount()
52			{
53			return $this->formatCurrency($this->getDataItem('withdraw_amount', 0));
			0 ignored issues – show Bug introduced 2021-02-14 11:30 UTC by Report Bug Copy Issue Report It seems like `formatCurrency()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54			}
55
56			public function getCurrency()
57			{
58			return 'RUB';
59			}
60
61			public function getNotificationType()
62			{
63			return $this->getDataItem('notification_type');
64			}
65
66			public function getBillId()
67			{
68			return $this->getDataItem('bill_id');
69			}
70
71			public function getCodePro()
72			{
73			return $this->getDataItem('codepro');
74			}
75
76			public function getUnaccepted()
77			{
78			return $this->getDataItem('unaccepted');
79			}
80
81			public function getDatetime()
82			{
83			return $this->getDataItem('datetime');
84			}
85
86			public function getSender()
87			{
88			return $this->getDataItem('sender');
89			}
90
91			public function getSha1Hash()
92			{
93			return $this->getDataItem('sha1_hash');
94			}
95
96			public function getOperationLabel()
97			{
98			return $this->getDataItem('operation_label');
99			}
100
101			public function getTestMode()
102			{
103			return $this->getDataItem('test_notification', false);
104			}
105
106			public function getLastName()
107			{
108			return $this->getDataItem('lastname');
109			}
110
111			public function getFirstname()
112			{
113			return $this->getDataItem('firstname');
114			}
115
116			public function getFathersname()
117			{
118			return $this->getDataItem('fathersname');
119			}
120
121			public function getEmail()
122			{
123			return $this->getDataItem('email');
124			}
125
126			public function getPhone()
127			{
128			return $this->getDataItem('phone');
129			}
130
131			public function getCity()
132			{
133			return $this->getDataItem('city');
134			}
135
136			public function getStreet()
137			{
138			return $this->getDataItem('street');
139			}
140
141			public function getBuilding()
142			{
143			return $this->getDataItem('building');
144			}
145
146			public function getSuite()
147			{
148			return $this->getDataItem('suite');
149			}
150
151			public function getFlat()
152			{
153			return $this->getDataItem('flat');
154			}
155
156			public function getZip()
157			{
158			return $this->getDataItem('zip');
159			}
160
161			}
162

leonardjke / omnipay-yoomoney

Push — main ( 7136de...6d50be )

ResponseFieldsTrait::getDataItem() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like