PurchaseResponse - Code Metrics - Inspection of "Removed unused elements from readme" - leonardjke/omnipay-yoomoney - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — main ( 9e586c...e73d1c )

by Leonard

created 2021-02-14 12:08 UTC

PurchaseResponse A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

80%

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	1
dl	0
loc	28
ccs	8
cts	10
cp	0.8
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	isSuccessful()	4	1
A	isRedirect()	4	1
A	getRedirectUrl()	4	1
A	getRedirectMethod()	4	1
A	getRedirectData()	4	1

<?php

namespace Omnipay\Yoomoney\Message;

use Omnipay\Common\Message\AbstractResponse;
use Omnipay\Common\Message\RedirectResponseInterface;

class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
{

    public function isSuccessful()
    {
        return false;
    }

    public function isRedirect()
    {
        return true;
    }

    public function getRedirectUrl()
    {
        return $this->getRequest()->getEndpoint();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getRedirectMethod()
    {
        return 'GET';
    }

    public function getRedirectData()
    {
        return $this->data;
    }
}


1		<?php
2
3		namespace Omnipay\Yoomoney\Message;
4
5		use Omnipay\Common\Message\AbstractResponse;
6		use Omnipay\Common\Message\RedirectResponseInterface;
7
8		class PurchaseResponse extends AbstractResponse implements RedirectResponseInterface
9		{
10
11	3	public function isSuccessful()
12		{
13	3	return false;
14		}
15
16	3	public function isRedirect()
17		{
18	3	return true;
19		}
20
21	3	public function getRedirectUrl()
22		{
23	3	return $this->getRequest()->getEndpoint();
		0 ignored issues – show Bug introduced 2021-02-14 12:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Omnipay\Common\Message\RequestInterface` as the method `getEndpoint()` does only exist in the following implementations of said interface: `Omnipay\Yoomoney\Message\AbstractRequest`, `Omnipay\Yoomoney\Message\CompletePurchaseRequest`, `Omnipay\Yoomoney\Message\PurchaseRequest`, `Omnipay\Yoomoney\Message\ServerNotifyRequest`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
24		}
25
26	3	public function getRedirectMethod()
27		{
28	3	return 'GET';
29		}
30
31		public function getRedirectData()
32		{
33		return $this->data;
34		}
35		}
36

leonardjke / omnipay-yoomoney

Push — main ( 9e586c...e73d1c )

PurchaseResponse A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like