TagBuilderTest::testRenderMetaMultipleAsSingleTag() - Code Metrics - Inspection of "Suggested changes" - leogout/SeoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#8)

unknown

created 2018-10-08 00:21 UTC

testRenderMetaMultipleAsSingleTag() A

↳ Parent: TagBuilderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Leogout\Bundle\SeoBundle\Tests\Builder;

use Leogout\Bundle\SeoBundle\Builder\TagBuilder;
use Leogout\Bundle\SeoBundle\Factory\TagFactory;
use Leogout\Bundle\SeoBundle\Model\MetaTag;
use Leogout\Bundle\SeoBundle\Tests\TestCase;

/**
 * Description of TagBuilderTest.
 *
 * @author: leogout
 */
class TagBuilderTest extends TestCase
{
    /**
     * @var TagBuilder
     */
    protected $tagBuilder;

    protected function setUp()
    {
        $this->tagBuilder = new TagBuilder(new TagFactory());
    }

    public function testRenderAll()
    {
        $this->tagBuilder->setTitle('Awesonme | Site');
        $this->tagBuilder->addMeta('keywords', MetaTag::NAME_TYPE, 'keywords', 'your, tags');
        $this->tagBuilder->addLink('rss',
            'http://symfony.com/blog',
            'alternate',
            'application/rss+xml',
            'RSS'
        );

        $this->assertEquals(
            "<title>Awesonme | Site</title>\n".
            "<meta name=\"keywords\" content=\"your, tags\" />\n".
            "<link href=\"http://symfony.com/blog\" rel=\"alternate\" type=\"application/rss+xml\" title=\"RSS\" />",
            $this->tagBuilder->render()
        );
    }

    public function testRenderTitle()
    {
        $this->tagBuilder->setTitle('Awesonme | Site');

        $this->assertEquals(
            '<title>Awesonme | Site</title>',
            $this->tagBuilder->render()
        );
    }

    public function testRenderMeta()
    {
        $this->tagBuilder->addMeta('keywords', MetaTag::NAME_TYPE, 'title', 'Hello World');

        $this->assertEquals(
            '<meta name="title" content="Hello World" />',
            $this->tagBuilder->render()
        );
    }

    public function testRenderMetaMultipleAsSingleTag()

    {
        $this->tagBuilder->addMeta('keywords', MetaTag::NAME_TYPE, 'keywords',  ['foo', 'bar'], false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals(
            '<meta name="keywords" content="foo, bar" />',
            $this->tagBuilder->render()
        );
    }

    public function testRenderMetaMultipleAsSeparateTags()

    {
        $this->tagBuilder->addMeta('keywords', MetaTag::NAME_TYPE, 'lang',  ['en', 'nl']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals(
            '<meta name="lang" content="en" /><meta name="lang" content="nl" />',
            $this->tagBuilder->render()
        );
    }

    public function testRenderLink()
    {
        $this->tagBuilder->addLink('rss',
            'http://symfony.com/blog',
            'alternate',
            'application/rss+xml',
            'RSS'
        );

        $this->assertEquals(
            '<link href="http://symfony.com/blog" rel="alternate" type="application/rss+xml" title="RSS" />',
            $this->tagBuilder->render()
        );
    }

    public function testRenderNothing()
    {
        $this->assertEquals(
            '',
            $this->tagBuilder->render()
        );
    }
}


1		<?php
2
3		namespace Leogout\Bundle\SeoBundle\Tests\Builder;
4
5		use Leogout\Bundle\SeoBundle\Builder\TagBuilder;
6		use Leogout\Bundle\SeoBundle\Factory\TagFactory;
7		use Leogout\Bundle\SeoBundle\Model\MetaTag;
8		use Leogout\Bundle\SeoBundle\Tests\TestCase;
9
10		/**
11		* Description of TagBuilderTest.
12		*
13		* @author: leogout
14		*/
15		class TagBuilderTest extends TestCase
16		{
17		/**
18		* @var TagBuilder
19		*/
20		protected $tagBuilder;
21
22		protected function setUp()
23		{
24		$this->tagBuilder = new TagBuilder(new TagFactory());
25		}
26
27		public function testRenderAll()
28		{
29		$this->tagBuilder->setTitle('Awesonme \| Site');
30		$this->tagBuilder->addMeta('keywords', MetaTag::NAME_TYPE, 'keywords', 'your, tags');
31		$this->tagBuilder->addLink('rss',
32		'http://symfony.com/blog',
33		'alternate',
34		'application/rss+xml',
35		'RSS'
36		);
37
38		$this->assertEquals(
39		"<title>Awesonme \| Site</title>\n".
40		"<meta name=\"keywords\" content=\"your, tags\" />\n".
41		"<link href=\"http://symfony.com/blog\" rel=\"alternate\" type=\"application/rss+xml\" title=\"RSS\" />",
42		$this->tagBuilder->render()
43		);
44		}
45
46		public function testRenderTitle()
47		{
48		$this->tagBuilder->setTitle('Awesonme \| Site');
49
50		$this->assertEquals(
51		'<title>Awesonme \| Site</title>',
52		$this->tagBuilder->render()
53		);
54		}
55
56		public function testRenderMeta()
57		{
58		$this->tagBuilder->addMeta('keywords', MetaTag::NAME_TYPE, 'title', 'Hello World');
59
60		$this->assertEquals(
61		'<meta name="title" content="Hello World" />',
62		$this->tagBuilder->render()
63		);
64		}
65
66	View Code Duplication	public function testRenderMetaMultipleAsSingleTag()
		0 ignored issues – show Duplication introduced 2018-10-08 00:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		{
68		$this->tagBuilder->addMeta('keywords', MetaTag::NAME_TYPE, 'keywords', ['foo', 'bar'], false);
		0 ignored issues – show Documentation introduced 2018-10-08 00:29 UTC by Report Bug Copy Issue Report `array('foo', 'bar')` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
69
70		$this->assertEquals(
71		'<meta name="keywords" content="foo, bar" />',
72		$this->tagBuilder->render()
73		);
74		}
75
76	View Code Duplication	public function testRenderMetaMultipleAsSeparateTags()
		0 ignored issues – show Duplication introduced 2018-10-08 00:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		{
78		$this->tagBuilder->addMeta('keywords', MetaTag::NAME_TYPE, 'lang', ['en', 'nl']);
		0 ignored issues – show Documentation introduced 2018-10-08 00:29 UTC by Report Bug Copy Issue Report `array('en', 'nl')` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
79
80		$this->assertEquals(
81		'<meta name="lang" content="en" /><meta name="lang" content="nl" />',
82		$this->tagBuilder->render()
83		);
84		}
85
86		public function testRenderLink()
87		{
88		$this->tagBuilder->addLink('rss',
89		'http://symfony.com/blog',
90		'alternate',
91		'application/rss+xml',
92		'RSS'
93		);
94
95		$this->assertEquals(
96		'<link href="http://symfony.com/blog" rel="alternate" type="application/rss+xml" title="RSS" />',
97		$this->tagBuilder->render()
98		);
99		}
100
101		public function testRenderNothing()
102		{
103		$this->assertEquals(
104		'',
105		$this->tagBuilder->render()
106		);
107		}
108		}
109

leogout / SeoBundle

Pull Request — develop (#8)

testRenderMetaMultipleAsSingleTag() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like