TwitterSeoConfigurator::configure() - Code Metrics - Inspection of "New configuration" - leogout/SeoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#2)

by Léo

created 2017-05-21 10:11 UTC

TwitterSeoConfigurator::configure() B

↳ Parent: TwitterSeoConfigurator

Complexity

Conditions	6
Paths	32

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	8.8571
c	0
b	0
f	0
cc	6
eloc	11
nc	32
nop	1

<?php

namespace Leogout\Bundle\SeoBundle\Seo\Twitter;

use Leogout\Bundle\SeoBundle\Seo\AbstractSeoConfigurator;
use Leogout\Bundle\SeoBundle\Seo\AbstractSeoGenerator;

/**
 * Description of TwitterSeoConfigurator.
 *
 * @author: leogout
 */
class TwitterSeoConfigurator extends AbstractSeoConfigurator
{
    /**
     * @param AbstractSeoGenerator $generator
     */
    public function configure(AbstractSeoGenerator $generator)
    {
        if (null !== $title = $this->getConfig('title')) {
            $generator->setTitle($title);
        }
        if (null !== $description = $this->getConfig('description')) {
            $generator->setDescription($description);
        }
        if (null !== $image = $this->getConfig('image')) {
            $generator->setImage($image);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
        if (null !== $card = $this->getConfig('card')) {
            $generator->setCard($card);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
        if (null !== $site = $this->getConfig('site')) {
            $generator->setSite($site);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
    }
}


Pull Request — develop (#2)

TwitterSeoConfigurator::configure() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Leogout\Bundle\SeoBundle\Seo\Twitter;
4
5			use Leogout\Bundle\SeoBundle\Seo\AbstractSeoConfigurator;
6			use Leogout\Bundle\SeoBundle\Seo\AbstractSeoGenerator;
7
8			/**
9			* Description of TwitterSeoConfigurator.
10			*
11			* @author: leogout
12			*/
13			class TwitterSeoConfigurator extends AbstractSeoConfigurator
14			{
15			/**
16			* @param AbstractSeoGenerator $generator
17			*/
18			public function configure(AbstractSeoGenerator $generator)
19			{
20			if (null !== $title = $this->getConfig('title')) {
21			$generator->setTitle($title);
22			}
23			if (null !== $description = $this->getConfig('description')) {
24			$generator->setDescription($description);
25			}
26			if (null !== $image = $this->getConfig('image')) {
27			$generator->setImage($image);
			0 ignored issues – show Bug introduced 2017-05-21 10:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Leogout\Bundle\SeoBundle\Seo\AbstractSeoGenerator` as the method `setImage()` does only exist in the following sub-classes of `Leogout\Bundle\SeoBundle\Seo\AbstractSeoGenerator`: `Leogout\Bundle\SeoBundle\Seo\Og\OgSeoGenerator`, `Leogout\Bundle\SeoBundle...ter\TwitterSeoGenerator`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
28			}
29			if (null !== $card = $this->getConfig('card')) {
30			$generator->setCard($card);
			0 ignored issues – show Bug introduced 2017-05-21 10:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Leogout\Bundle\SeoBundle\Seo\AbstractSeoGenerator` as the method `setCard()` does only exist in the following sub-classes of `Leogout\Bundle\SeoBundle\Seo\AbstractSeoGenerator`: `Leogout\Bundle\SeoBundle...ter\TwitterSeoGenerator`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
31			}
32			if (null !== $site = $this->getConfig('site')) {
33			$generator->setSite($site);
			0 ignored issues – show Bug introduced 2017-05-21 10:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Leogout\Bundle\SeoBundle\Seo\AbstractSeoGenerator` as the method `setSite()` does only exist in the following sub-classes of `Leogout\Bundle\SeoBundle\Seo\AbstractSeoGenerator`: `Leogout\Bundle\SeoBundle...ter\TwitterSeoGenerator`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
34			}
35			}
36			}
37

leogout / SeoBundle

Pull Request — develop (#2)

TwitterSeoConfigurator::configure() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like