SwooleTableAdapter - Code Metrics - Inspection of "Merge pull request #12 from leocarmo/feature/custo..." - leocarmo/circuit-breaker-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0ade69...1ab37d )

by Leonardo

created 2021-12-28 17:37 UTC

SwooleTableAdapter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	157
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
wmc	17
eloc	54
c	2
b	1
f	1
dl	0
loc	157
rs	10

11 Methods

Rating	Name	Size	Complexity
A	reachRateLimit()	16	3
A	__construct()	4	1
A	createTable()	7	1
A	checkExtensionLoaded()	4	2
A	setSuccess()	5	1
A	incrementFailure()	13	2
A	isHalfOpen()	12	2
A	setOpenCircuit()	12	1
A	setHalfOpenCircuit()	14	1
A	isOpen()	12	2
A	getFailuresCounter()	5	1

<?php declare(strict_types=1);

namespace LeoCarmo\CircuitBreaker\Adapters;

use Swoole\Table;

class SwooleTableAdapter implements AdapterInterface
{
    protected Table $table;

    public function __construct()
    {
        $this->checkExtensionLoaded();
        $this->table = $this->createTable();
    }

    protected function createTable()
    {
        $table = new Table(12);
        $table->column('count', Table::TYPE_INT, 4);
        $table->column('until_date', Table::TYPE_INT, 4);
        $table->create();
        return $table;
    }

    protected function checkExtensionLoaded()
    {
        if (! extension_loaded('swoole')) {
            throw new \RuntimeException('Extension swoole is required to use SwooleTableAdapter.');
        }
    }

    /**
     * @param string $service
     * @param int $timeWindow
     * @return bool
     */
    public function incrementFailure(string $service, int $timeWindow): bool
    {
        $key = "{$service}-failures";

        if ($this->table->exist($key)) {
            return is_integer($this->table->incr($key, 'count'));
        }

        $date = (new \DateTime("+{$timeWindow} seconds"));

        return $this->table->set($key, [
            'count' => 1,
            'until_date' => $date->getTimestamp(),
        ]);
    }

    public function reachRateLimit(string $service, int $failureRateThreshold): bool
    {
        $key = "{$service}-failures";

        if (! $this->table->exist($key)) {
            return false;
        }

        $failures = $this->table->get($key);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        if ((new \DateTime('now'))->getTimestamp() > $failures['until_date']) {
            $this->table->delete("{$service}-failures");
            return false;
        }

        return ($failures['count'] >= $failureRateThreshold);
    }

    /**
     * @param string $service
     */
    public function setSuccess(string $service): void
    {
        $this->table->delete("{$service}-failures");
        $this->table->delete("{$service}-open");
        $this->table->delete("{$service}-half_open");
    }

    /**
     * @param string $service
     * @return bool
     */
    public function isOpen(string $service): bool
    {
        $key = "{$service}-open";

        if (! $this->table->exists($key)) {
            return false;
        }

        $open = $this->table->get($key, 'until_date');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        return (
            (new \DateTime('now'))->getTimestamp() < $open
        );
    }

    /**
     * @param string $service
     * @return bool|string
     */
    public function isHalfOpen(string $service): bool
    {
        $key = "{$service}-half_open";

        if (! $this->table->exists($key)) {
            return false;
        }

        $halfOpen = $this->table->get($key, 'until_date');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        return (
            (new \DateTime('now'))->getTimestamp() < $halfOpen
        );
    }

    /**
     * @param string $service
     * @param int $timeWindow
     */
    public function setOpenCircuit(string $service, int $timeWindow): void
    {
        $date = (new \DateTime("+{$timeWindow} seconds"));

        $this->table->set(
            "{$service}-open",
            [
                'until_date' => $date->getTimestamp(),
            ]
        );

        $this->table->delete("{$service}-failures");
    }

    /**
     * @param string $service
     * @param int $timeWindow
     * @param int $intervalToHalfOpen
     */
    public function setHalfOpenCircuit(string $service, int $timeWindow, int $intervalToHalfOpen): void
    {
        $seconds = ($timeWindow + $intervalToHalfOpen);

        $date = (new \DateTime("+{$seconds} seconds"));

        $this->table->set(
            "{$service}-half_open",
            [
                'until_date' => $date->getTimestamp(),
            ]
        );

        $this->table->delete("{$service}-failures");
    }

    public function getFailuresCounter(string $service): int
    {
        $failures = $this->table->get("{$service}-failures");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        return (int) ($failures['count'] ?? 0);
    }
}


1			<?php declare(strict_types=1);
2
3			namespace LeoCarmo\CircuitBreaker\Adapters;
4
5			use Swoole\Table;
6
7			class SwooleTableAdapter implements AdapterInterface
8			{
9			protected Table $table;
10
11			public function __construct()
12			{
13			$this->checkExtensionLoaded();
14			$this->table = $this->createTable();
15			}
16
17			protected function createTable()
18			{
19			$table = new Table(12);
20			$table->column('count', Table::TYPE_INT, 4);
21			$table->column('until_date', Table::TYPE_INT, 4);
22			$table->create();
23			return $table;
24			}
25
26			protected function checkExtensionLoaded()
27			{
28			if (! extension_loaded('swoole')) {
29			throw new \RuntimeException('Extension swoole is required to use SwooleTableAdapter.');
30			}
31			}
32
33			/**
34			* @param string $service
35			* @param int $timeWindow
36			* @return bool
37			*/
38			public function incrementFailure(string $service, int $timeWindow): bool
39			{
40			$key = "{$service}-failures";
41
42			if ($this->table->exist($key)) {
43			return is_integer($this->table->incr($key, 'count'));
44			}
45
46			$date = (new \DateTime("+{$timeWindow} seconds"));
47
48			return $this->table->set($key, [
49			'count' => 1,
50			'until_date' => $date->getTimestamp(),
51			]);
52			}
53
54			public function reachRateLimit(string $service, int $failureRateThreshold): bool
55			{
56			$key = "{$service}-failures";
57
58			if (! $this->table->exist($key)) {
59			return false;
60			}
61
62			$failures = $this->table->get($key);
			0 ignored issues – show Bug introduced 2021-11-23 18:10 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$failures` is correct as `$this->table->get($key)` targeting `Swoole\Table::get()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
63
64			if ((new \DateTime('now'))->getTimestamp() > $failures['until_date']) {
65			$this->table->delete("{$service}-failures");
66			return false;
67			}
68
69			return ($failures['count'] >= $failureRateThreshold);
70			}
71
72			/**
73			* @param string $service
74			*/
75			public function setSuccess(string $service): void
76			{
77			$this->table->delete("{$service}-failures");
78			$this->table->delete("{$service}-open");
79			$this->table->delete("{$service}-half_open");
80			}
81
82			/**
83			* @param string $service
84			* @return bool
85			*/
86			public function isOpen(string $service): bool
87			{
88			$key = "{$service}-open";
89
90			if (! $this->table->exists($key)) {
91			return false;
92			}
93
94			$open = $this->table->get($key, 'until_date');
			0 ignored issues – show Bug introduced 2021-11-23 18:10 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$open` is correct as `$this->table->get($key, 'until_date')` targeting `Swoole\Table::get()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
95
96			return (
97			(new \DateTime('now'))->getTimestamp() < $open
98			);
99			}
100
101			/**
102			* @param string $service
103			* @return bool\|string
104			*/
105			public function isHalfOpen(string $service): bool
106			{
107			$key = "{$service}-half_open";
108
109			if (! $this->table->exists($key)) {
110			return false;
111			}
112
113			$halfOpen = $this->table->get($key, 'until_date');
			0 ignored issues – show Bug introduced 2021-11-23 18:10 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$halfOpen` is correct as `$this->table->get($key, 'until_date')` targeting `Swoole\Table::get()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
114
115			return (
116			(new \DateTime('now'))->getTimestamp() < $halfOpen
117			);
118			}
119
120			/**
121			* @param string $service
122			* @param int $timeWindow
123			*/
124			public function setOpenCircuit(string $service, int $timeWindow): void
125			{
126			$date = (new \DateTime("+{$timeWindow} seconds"));
127
128			$this->table->set(
129			"{$service}-open",
130			[
131			'until_date' => $date->getTimestamp(),
132			]
133			);
134
135			$this->table->delete("{$service}-failures");
136			}
137
138			/**
139			* @param string $service
140			* @param int $timeWindow
141			* @param int $intervalToHalfOpen
142			*/
143			public function setHalfOpenCircuit(string $service, int $timeWindow, int $intervalToHalfOpen): void
144			{
145			$seconds = ($timeWindow + $intervalToHalfOpen);
146
147			$date = (new \DateTime("+{$seconds} seconds"));
148
149			$this->table->set(
150			"{$service}-half_open",
151			[
152			'until_date' => $date->getTimestamp(),
153			]
154			);
155
156			$this->table->delete("{$service}-failures");
157			}
158
159			public function getFailuresCounter(string $service): int
160			{
161			$failures = $this->table->get("{$service}-failures");
			0 ignored issues – show Bug introduced 2021-12-28 17:29 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$failures` is correct as `$this->table->get($service.'-failures')` targeting `Swoole\Table::get()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
162
163			return (int) ($failures['count'] ?? 0);
164			}
165			}
166

leocarmo / circuit-breaker-php

Push — master ( 0ade69...1ab37d )

SwooleTableAdapter A

Complexity

Size/Duplication

Importance

11 Methods

Duplication Side-by-Side

Filter issues like