MetroMarkets\FFBundle\Providers\RestProvider

Complexity

Total Complexity

6

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	fetchData()	0	5	1
A	isEnabled()	0	7	2
A	__construct()	0	6	1
A	getCachedResponse()	0	13	2

<?php

namespace MetroMarkets\FFBundle\Providers;

use GuzzleHttp\Client;
use MetroMarkets\FFBundle\Contract\ProviderInterface;
use Symfony\Component\Cache\Adapter\AdapterInterface;

class RestProvider implements ProviderInterface
{
    /** @var Client */
    private $client;

    /** @var string */
    private $endpoint;

    /** @var AdapterInterface */
    private $cache;

    /** @var int */
    private $cacheTTL;

    public function __construct(string $endpoint, AdapterInterface $cache = null, int $cacheTTL = 60)
    {
        $this->client = new Client();
        $this->endpoint = $endpoint;
        $this->cache = $cache;
        $this->cacheTTL = $cacheTTL;
    }

    public function isEnabled(string $key, string $identifier = null): bool
    {
        if (!$this->cache) {
            return $this->fetchData($key);
        }

        return $this->getCachedResponse($key);

The expression return $this->getCachedResponse($key) could return the type null which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }

    private function getCachedResponse(string $key)
    {
        $cacheItem = $this->cache->getItem($key);

        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $result = $this->fetchData($key);

        $cacheItem->set($result);
        $cacheItem->expiresAfter($this->cacheTTL);
        $this->cache->save($cacheItem);

    }

    private function fetchData(string $key)
    {
        $response = $this->client->get($this->endpoint . '?key=' . $key);

        return \json_decode($response->getBody()->getContents(), true);
    }
}