Leo108\CAS\Events\CasUserLoginEvent

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

40%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	broadcastOn()	4	4	1
A	getRequest()	4	4	1
A	getUser()	4	4	1

<?php

namespace Leo108\CAS\Events;

use Illuminate\Http\Request;
use Illuminate\Queue\SerializesModels;
use Leo108\CAS\Contracts\Models\UserModel;

class CasUserLoginEvent extends Event

This class seems to be duplicated in your project.

{
    use SerializesModels;

    /**
     * @var Request
     */
    protected $request;
    /**
     * @var UserModel
     */
    protected $user;

    /**
     * CasUserLoginEvent constructor.
     * @param Request   $request
     * @param UserModel $user
     */
    public function __construct(Request $request, UserModel $user)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
        $this->user    = $user;
    }

    /**
     * Get the channels the event should be broadcast on.
     *
     * @return array
     */
    public function broadcastOn()
    {
        return [];
    }

    /**
     * @return Request
     */
    public function getRequest()
    {
        return $this->request;
    }

    /**
     * @return UserModel
     */
    public function getUser()
    {
        return $this->user;
    }
}