Conditions | 20 |
Paths | 34 |
Total Lines | 49 |
Code Lines | 31 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
94 | function data_set(&$target, $key, $value, $overwrite = true) |
||
95 | { |
||
96 | $segments = is_array($key) ? $key : explode('.', $key); |
||
97 | |||
98 | if (($segment = array_shift($segments)) === '*') { |
||
99 | if ( ! Arr::accessible($target)) { |
||
100 | $target = []; |
||
101 | } |
||
102 | |||
103 | if ($segments) { |
||
104 | foreach ($target as &$inner) { |
||
105 | data_set($inner, $segments, $value, $overwrite); |
||
106 | } |
||
107 | } elseif ($overwrite) { |
||
108 | foreach ($target as &$inner) { |
||
109 | $inner = $value; |
||
110 | } |
||
111 | } |
||
112 | } elseif (Arr::accessible($target)) { |
||
113 | if ($segments) { |
||
114 | if ( ! Arr::exists($target, $segment)) { |
||
115 | $target[$segment] = []; |
||
116 | } |
||
117 | |||
118 | data_set($target[$segment], $segments, $value, $overwrite); |
||
119 | } elseif ($overwrite || ! Arr::exists($target, $segment)) { |
||
120 | $target[$segment] = $value; |
||
121 | } |
||
122 | } elseif (is_object($target)) { |
||
123 | if ($segments) { |
||
124 | if ( ! isset($target->{$segment})) { |
||
125 | $target->{$segment} = []; |
||
126 | } |
||
127 | |||
128 | data_set($target->{$segment}, $segments, $value, $overwrite); |
||
129 | } elseif ($overwrite || ! isset($target->{$segment})) { |
||
130 | $target->{$segment} = $value; |
||
131 | } |
||
132 | } else { |
||
133 | $target = []; |
||
134 | |||
135 | if ($segments) { |
||
136 | data_set($target[$segment], $segments, $value, $overwrite); |
||
137 | } elseif ($overwrite) { |
||
138 | $target[$segment] = $value; |
||
139 | } |
||
140 | } |
||
141 | |||
142 | return $target; |
||
143 | } |
||
209 | } |