| Conditions | 1 |
| Paths | 1 |
| Total Lines | 119 |
| Code Lines | 79 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 210 | public function testMeta() |
||
| 211 | { |
||
| 212 | $meta = [ |
||
| 213 | 'TestID' => 1, |
||
| 214 | 'SomeText' => 'test', |
||
| 215 | ]; |
||
| 216 | $wrongMeta = [ |
||
| 217 | 'WrongMeta' => true |
||
| 218 | ]; |
||
| 219 | $tags = ['test-tag']; |
||
| 220 | |||
| 221 | // Meta can be set using the mandrill compat layer |
||
| 222 | $email = new Email(); |
||
| 223 | // meta is json encoded |
||
| 224 | // https://mailchimp.com/developer/transactional/docs/smtp-integration/#x-mc-metadata |
||
| 225 | $email->getHeaders()->addTextHeader('X-MC-Metadata', json_encode($meta)); |
||
| 226 | // tags are , delimited |
||
| 227 | // https://mailchimp.com/developer/transactional/docs/smtp-integration/#x-mc-tags |
||
| 228 | $email->getHeaders()->addTextHeader('X-MC-Tags', implode(',', $tags)); |
||
| 229 | $email->setTo('dummy@localhost'); |
||
| 230 | $client = SparkPostHelper::getClient(); |
||
| 231 | $api = new SparkPostApiTransport($client); |
||
| 232 | |||
| 233 | $sender = $email->getSender()[0] ?? $email->getFrom()[0] ?? null; |
||
| 234 | $recipients = $email->getTo(); |
||
| 235 | $envelope ??= new Envelope($sender, $recipients); |
||
| 236 | $payload = $api->getPayload($email, $envelope); |
||
| 237 | |||
| 238 | $metaFromRecipients = $payload['recipients'][0]['metadata']; |
||
| 239 | $this->assertEquals($meta, $metaFromRecipients); |
||
| 240 | $tagsFromRecipients = $payload['recipients'][0]['tags']; |
||
| 241 | $this->assertEquals($tags, $tagsFromRecipients); |
||
| 242 | |||
| 243 | // Or using the smtp api |
||
| 244 | // https://developers.sparkpost.com/api/smtp/#header-using-the-x-msys-api-custom-header |
||
| 245 | $email = new Email(); |
||
| 246 | $msys = [ |
||
| 247 | 'metadata' => $meta, |
||
| 248 | // Tags are available in click/open events. Maximum number of tags is 10 per recipient, 100 system wide. |
||
| 249 | 'tags' => $tags |
||
| 250 | ]; |
||
| 251 | // It's one big json blob |
||
| 252 | $email->getHeaders()->addTextHeader('X-MSYS-API', json_encode($msys)); |
||
| 253 | $email->setTo('dummy@localhost'); |
||
| 254 | $client = SparkPostHelper::getClient(); |
||
| 255 | $api = new SparkPostApiTransport($client); |
||
| 256 | |||
| 257 | $sender = $email->getSender()[0] ?? $email->getFrom()[0] ?? null; |
||
| 258 | $recipients = $email->getTo(); |
||
| 259 | $envelope ??= new Envelope($sender, $recipients); |
||
| 260 | $payload = $api->getPayload($email, $envelope); |
||
| 261 | |||
| 262 | $metaFromRecipients = $payload['recipients'][0]['metadata']; |
||
| 263 | $this->assertEquals($meta, $metaFromRecipients); |
||
| 264 | $tagsFromRecipients = $payload['recipients'][0]['tags']; |
||
| 265 | $this->assertEquals($tags, $tagsFromRecipients); |
||
| 266 | |||
| 267 | // Beware of settings headers multiple times |
||
| 268 | |||
| 269 | $email = new Email(); |
||
| 270 | $email->getHeaders()->addTextHeader('X-MC-Metadata', json_encode($wrongMeta)); |
||
| 271 | $email->getHeaders()->addTextHeader('X-MC-Metadata', json_encode($meta)); |
||
| 272 | $email->setTo('dummy@localhost'); |
||
| 273 | $client = SparkPostHelper::getClient(); |
||
| 274 | $api = new SparkPostApiTransport($client); |
||
| 275 | |||
| 276 | $stringHeaders = $email->getHeaders()->toString(); |
||
| 277 | // It's not a unique header, it appears twice |
||
| 278 | $this->assertEquals(2, substr_count($stringHeaders, 'X-MC-Metadata')); |
||
| 279 | |||
| 280 | $sender = $email->getSender()[0] ?? $email->getFrom()[0] ?? null; |
||
| 281 | $recipients = $email->getTo(); |
||
| 282 | $envelope ??= new Envelope($sender, $recipients); |
||
| 283 | $payload = $api->getPayload($email, $envelope); |
||
| 284 | |||
| 285 | $metaFromRecipients = $payload['recipients'][0]['metadata']; |
||
| 286 | $this->assertEquals($wrongMeta, $metaFromRecipients); |
||
| 287 | $this->assertNotEquals($meta, $metaFromRecipients); |
||
| 288 | |||
| 289 | // Instead, use SparkPostHelper::addMetaData that can merge or replace headers |
||
| 290 | |||
| 291 | $email = new Email(); |
||
| 292 | |||
| 293 | $mergedMeta = array_merge($wrongMeta, $meta); |
||
| 294 | SparkPostHelper::addMetaData($email, $wrongMeta); |
||
| 295 | SparkPostHelper::addMetaData($email, $meta); |
||
| 296 | $email->setTo('dummy@localhost'); |
||
| 297 | $client = SparkPostHelper::getClient(); |
||
| 298 | $api = new SparkPostApiTransport($client); |
||
| 299 | |||
| 300 | $stringHeaders = $email->getHeaders()->toString(); |
||
| 301 | // Only once! |
||
| 302 | $this->assertEquals(1, substr_count($stringHeaders, 'X-MC-Metadata')); |
||
| 303 | |||
| 304 | $sender = $email->getSender()[0] ?? $email->getFrom()[0] ?? null; |
||
| 305 | $recipients = $email->getTo(); |
||
| 306 | $envelope ??= new Envelope($sender, $recipients); |
||
| 307 | $payload = $api->getPayload($email, $envelope); |
||
| 308 | |||
| 309 | $metaFromRecipients = $payload['recipients'][0]['metadata']; |
||
| 310 | $this->assertEquals($mergedMeta, $metaFromRecipients); |
||
| 311 | |||
| 312 | SparkPostHelper::addMetaData($email, $wrongMeta, true); |
||
| 313 | SparkPostHelper::addMetaData($email, $meta, true); |
||
| 314 | $email->setTo('dummy@localhost'); |
||
| 315 | $client = SparkPostHelper::getClient(); |
||
| 316 | $api = new SparkPostApiTransport($client); |
||
| 317 | |||
| 318 | $stringHeaders = $email->getHeaders()->toString(); |
||
| 319 | // Only once! |
||
| 320 | $this->assertEquals(1, substr_count($stringHeaders, 'X-MC-Metadata')); |
||
| 321 | |||
| 322 | $sender = $email->getSender()[0] ?? $email->getFrom()[0] ?? null; |
||
| 323 | $recipients = $email->getTo(); |
||
| 324 | $envelope ??= new Envelope($sender, $recipients); |
||
| 325 | $payload = $api->getPayload($email, $envelope); |
||
| 326 | |||
| 327 | $metaFromRecipients = $payload['recipients'][0]['metadata']; |
||
| 328 | $this->assertEquals($meta, $metaFromRecipients); |
||
| 329 | } |
||
| 331 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths