LeKoala\PhoneNumber\CountryPhoneField

Complexity

Total Complexity

16

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Importance

Changes	4
Bugs	1	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setDataFormat()	0	4	1
A	__construct()	0	13	1
A	getDataFormat()	0	3	1
A	setValue()	0	24	5
A	getCountryField()	0	3	1
A	getPhoneField()	0	3	1
A	hasData()	0	4	1
A	dataValue()	0	20	5

<?php

namespace LeKoala\PhoneNumber;

use Exception;
use SilverStripe\Forms\FieldGroup;
use libphonenumber\PhoneNumberFormat;
use SilverStripe\Forms\DropdownField;

/**
 * A country/phone combo field
 */
class CountryPhoneField extends FieldGroup
{
    protected $dataformat = null;

    public function __construct($name, $title = null, $value = null)

The parameter $value is not used and could be removed.

    {
        $country = new DropdownField($name . "[CountryCode]", "");
        $country->setSource(PhoneHelper::getCountriesList());
        $country->setHasEmptyDefault(true);
        $country->setAttribute('style', 'max-width:166px'); // Match FieldGroup min width
        $country->setAttribute('size', 1); // fix some weird sizing issue in cms

        $number = new PhoneField($name . "[Number]", "");

        parent::__construct($title, $country, $number);

        $this->name = $name;
    }


    public function hasData()
    {
        // Turn this into a datafield
        return true;
    }

    /**
     * @return DropdownField
     */
    public function getCountryField()
    {
        return $this->fieldByName($this->name . "[CountryCode]");

Are you sure the usage of $this->fieldByName($this->name . '[CountryCode]') targeting SilverStripe\Forms\CompositeField::fieldByName() seems to always return null.

    }

    /**
     * @return PhoneField
     */
    public function getPhoneField()
    {
        return $this->fieldByName($this->name . "[Number]");

Are you sure the usage of $this->fieldByName($this->name . '[Number]') targeting SilverStripe\Forms\CompositeField::fieldByName() seems to always return null.

    }

    public function getDataFormat()
    {
        return $this->dataformat;
    }

    public function setDataFormat($v)
    {
        $this->dataformat = $v;
        return $this;
    }

    public function setValue($value, $data = null)
    {
        // An array of value to assign to sub fields
        if (is_array($value)) {
            foreach ($value as $k => $v) {
                $this->fieldByName($this->name . "[$k]")->setValue($v);

Are you sure the usage of $this->fieldByName($this->name . '['.$k.']') targeting SilverStripe\Forms\CompositeField::fieldByName() seems to always return null.

            }
            return;
        }
        // It's an international number
        if (strpos((string)$value, '+') === 0) {
            $util = PhoneHelper::getPhoneNumberUtil();
            try {
                $number = $util->parse($value);
                $regionCode = $util->getRegionCodeForNumber($number);
                $this->getCountryField()->setValue($regionCode);
                $phone = $util->format($number, PhoneNumberFormat::NATIONAL);
                $this->getPhoneField()->setValue($phone);
            } catch (Exception $ex) {
                // We were unable to parse, simply set the value as is
                $this->getPhoneField()->setValue($phone);
            }
        } else {
            $this->getPhoneField()->setValue($value);
        }
    }

    /**
     * Value in E164 format (no formatting)
     *
     * @return string
     */
    public function dataValue()
    {
        $countryValue = $this->getCountryField()->Value();
        $phoneValue = $this->getPhoneField()->Value();
        if (!$phoneValue) {
            return '';
        }
        if (!$countryValue && strpos((string)$phoneValue, '+') !== 0) {
            return $phoneValue;
        }

        $util = PhoneHelper::getPhoneNumberUtil();

        try {
            $number = $util->parse($phoneValue, $countryValue);
            $format = $this->dataformat ?? PhoneNumberFormat::E164;
            return $util->format($number, $format);
        } catch (Exception $ex) {
            // We were unable to parse, simply return the value as is
            return $phoneValue;
        }
    }
}