LeKoala\GeoTools\Fields\TimezoneDropdown

Complexity

Total Complexity

10

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	normalizedAliases()	0	15	4
A	dataValue()	0	3	1
A	__construct()	0	20	5

<?php

namespace LeKoala\GeoTools\Fields;

use ArrayAccess;
use SilverStripe\ORM\ArrayLib;
use SilverStripe\Forms\DropdownField;

/**
 * A timezone dropdown
 * @link https://www.php.net/manual/en/timezones.others.php
 * @link https://www.timeanddate.com/time/zones/
 */
class TimezoneDropdown extends DropdownField
{
    /**
     * in yml, it needs to be name/value like so
     * - name: "Gulf Standard Time (GST)"
     *   value: "Asia/Dubai"
     *
     * @var array<string,string>
     */
    private static $aliases = [
        // "Gulf Standard Time (GST)" => "Asia/Dubai",
        // "Central European Time (CET)" => "Europe/Brussels",
        // "Atlantic Standard Time (AST)" => "America/Blanc-Sablon",
        // "Eastern Standard Time (EST)" => "America/Panama",
        // "Central Standard Time (CST)" => "America/Regina",
        // "Mountain Standard Time (MST)" => "America/Phoenix",
        // "Pacific Standard Time (PST)" => "America/Los_Angeles",
    ];

    /**
     * @param string $name The field name
     * @param string $title The field title
     * @param array<string,string>|ArrayAccess<string,string> $source A map of the dropdown items
     * @param mixed $value The current value
     */
    public function __construct($name, $title = null, $source = [], $value = null)
    {
        if (empty($source)) {
            $source = ArrayLib::valuekey(timezone_identifiers_list());

Are you sure the usage of timezone_identifiers_list() is correct as it seems to always return null.

            $aliases = $this->config()->aliases ?? [];
            if (!empty($aliases)) {
                $normalizedAliases = [];
                foreach ($aliases as $k => $v) {
                    // Add a prefix to avoid clashes with regular value
                    if (is_int($k)) {
                        $normalizedAliases[$v['name']] = '_' . $v['value'];
                    } else {
                        $normalizedAliases[$k] = '_' . $v;
                    }
                }

                $source = array_flip($normalizedAliases) + $source;
            }
        }
        parent::__construct($name, $title, $source, $value);
    }

    /**
     * @return array<string,string>
     */
    public function normalizedAliases(): array
    {
        $aliases = $this->config()->aliases ?? [];
        $normalizedAliases = [];
        if (!empty($aliases)) {
            foreach ($aliases as $k => $v) {
                if (is_int($k)) {
                    $normalizedAliases[$v['name']] = $v['value'];
                } else {
                    $normalizedAliases[$k] = $v;
                }
            }
        }
        //@phpstan-ignore-next-line
        return $normalizedAliases;
    }

    public function dataValue()
    {
        return ltrim(parent::dataValue(), '_');
    }
}