Issues in TomSelectSingleField.php (master) - Issues in master - lekoala/silverstripe-form-elements - Measure and Improve Code Quality continuously with Scrutinizer

Issues (83)

src/TomSelectSingleField.php (3 issues)

Labels

Bug 2

Severity

<?php

namespace LeKoala\FormElements;

use SilverStripe\Forms\DropdownField;
use SilverStripe\ORM\DataObjectInterface;

/**
 * @link https://tom-select.js.org/
 */
class TomSelectSingleField extends DropdownField implements AjaxPoweredField, LocalizableField, TagsField
{
    use TomSelect;


    /**
     * @param DataObject|DataObjectInterface $record The record to save into
filter:
    dependency_paths: ["lib/*"]
     */
    public function saveInto(DataObjectInterface $record)
    {
        return parent::saveInto($record);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1			<?php
2
3			namespace LeKoala\FormElements;
4
5			use SilverStripe\Forms\DropdownField;
6			use SilverStripe\ORM\DataObjectInterface;
7
8			/**
9			* @link https://tom-select.js.org/
10			*/
11			class TomSelectSingleField extends DropdownField implements AjaxPoweredField, LocalizableField, TagsField
12			{
13			use TomSelect;
			0 ignored issues – show introduced 2023-06-16 16:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The trait `LeKoala\FormElements\TomSelect` requires some properties which are not provided by `LeKoala\FormElements\TomSelectSingleField`: `$ID`, `$db` Loading history...
14
15			/**
16			* @param DataObject\|DataObjectInterface $record The record to save into
			0 ignored issues – show Bug introduced 2023-06-16 16:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `LeKoala\FormElements\DataObject` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
17			*/
18			public function saveInto(DataObjectInterface $record)
19			{
20			return parent::saveInto($record);
			0 ignored issues – show Bug introduced 2023-06-16 16:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `parent::saveInto($record)` targeting `SilverStripe\Forms\FormField::saveInto()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
21			}
22			}
23

lekoala / silverstripe-form-elements

Issues (83)

src/TomSelectSingleField.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like