LeKoala\Encrypt\Test\Test_EncryptionKey

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getKeyPair()	0	10	2
A	getForMember()	0	4	1

<?php

namespace LeKoala\Encrypt\Test;

use SilverStripe\Assets\File;
use SilverStripe\Dev\TestOnly;
use ParagonIE\ConstantTime\Hex;
use SilverStripe\ORM\DataObject;

/**
 * @property string $EncryptionKey
 * @property int $MemberID
 */
class Test_EncryptionKey extends DataObject implements TestOnly
{
    private static $table_name = 'EncryptionKey';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        // A 256 bit key (32 bytes = 32*8)
        // 32 bytes = 64 chars in hex (eg using bin2hex)
        "EncryptionKey" => 'Varchar',

        // X25519 Keypair (2x 32 bytes keys)
        "SecretKey" => 'Varchar',
        "PublicKey" => 'Varchar',
    ];

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        "Member" => File::class,
    ];

    public static function getForMember($ID)
    {
        $rec = self::get()->filter('MemberID', $ID)->first();
        return $rec->EncryptionKey ?? null;
    }

    public static function getKeyPair($ID)
    {
        $rec = self::get()->filter('MemberID', $ID)->first();
        if ($rec) {
            return [
                'public' => Hex::decode($rec->PublicKey),

It seems like $rec->PublicKey can also be of type null; however, parameter $encodedString of ParagonIE\ConstantTime\Hex::decode() does only seem to accept string, maybe add an additional type check?

                'secret' => Hex::decode($rec->SecretKey),
            ];
        }
        return false;
    }
}