LeKoala\Encrypt\HasEncryption::setValue()

Complexity

Conditions	4
Paths	3

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function setValue(mixed $value, null|array|ModelData $record = null, bool $markChanged = true): static

The parameter $markChanged is not used and could be removed.

    {
        $this->setEncryptionAad($record);

It seems like $record can also be of type array; however, parameter $record of LeKoala\Encrypt\HasEncryption::setEncryptionAad() does only seem to accept SilverStripe\ORM\DataObject, maybe add an additional type check?

        // Return early if we keep encrypted value in memory
        if (!EncryptHelper::getAutomaticDecryption()) {
            $this->value = $value;

The property value does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return $this;
        }

        // $markChanged is not used
        // The value might come encrypted from the database
        if ($value && EncryptHelper::isEncrypted($value)) {
            $this->value = $this->decryptValue($value);
        } else {
            $this->value = $value;
        }
        return $this;
    }