LeKoala\DevToolkit\Tasks\ClearCacheFolderTask::run()

Complexity

Conditions	5
Paths	9

Size

Total Lines	25
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function run($request)
    {
        $this->request = $request;

The property request does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $folder = Director::baseFolder() . '/silverstripe-cache';
        $create = $_GET['create'] ?? false;
        if (!is_dir($folder)) {
            if ($create) {
                mkdir($folder, 0755);
            } else {
                throw new Exception("silverstripe-cache folder does not exist in root");
            }
        }

        $result = FileHelper::rmDir($folder);
        if ($result) {
            $this->message("Removed $folder");

The method message() does not exist on LeKoala\DevToolkit\Tasks\ClearCacheFolderTask. Since you implemented __call, consider adding a @method annotation.

        } else {
            $this->message("Failed to remove $folder", "error");
        }
        $result = mkdir($folder, 0755);
        if ($result) {
            $this->message("A new folder has been created at $folder");
        } else {
            $this->message("Failed to create a new folder at $folder", "error");
        }