LeKoala\DevToolkit\Tasks\TestCacheSupportTask

Complexity

Total Complexity

11

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testRedis()	0	8	1
A	run()	0	7	1
A	testOpcache()	0	15	3
B	testMemcache()	0	37	6

<?php

namespace LeKoala\DevToolkit\Tasks;

use stdClass;
use Predis\Client;

The type Predis\Client was not found. Maybe you did not declare it correctly or list all dependencies?

use Predis\Command\ServerInfo;

The type Predis\Command\ServerInfo was not found. Maybe you did not declare it correctly or list all dependencies?

use SilverStripe\Dev\BuildTask;
use LeKoala\DevToolkit\BuildTaskTools;
use SilverStripe\Core\Injector\Injector;
use LeKoala\Base\Cache\RedisCacheFactory;

The type LeKoala\Base\Cache\RedisCacheFactory was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 */
class TestCacheSupportTask extends BuildTask
{
    use BuildTaskTools;

    protected $title = "Test Cache Support";
    protected $description = 'Check what cache backends are available and working.';
    private static $segment = 'TestCacheSupportTask';

The private property $segment is not used, and could be removed.

    public function run($request)
    {
        $this->request = $request;

        $this->testMemcache();
        $this->testOpcache();
        $this->testRedis();
    }

    protected function testRedis()
    {
        $predis = new Client('tcp://127.0.0.1:6379');
        $this->message($predis->executeCommand(new ServerInfo));

        $args = [];
        $redisCache = Injector::inst()->createWithArgs(RedisCacheFactory::class, $args);
        $this->message($redisCache);
    }

    protected function testOpcache()
    {
        if (!function_exists('opcache_get_status')) {
            $this->msg("opcache_get_status function is not defined");

The method msg() does not exist on LeKoala\DevToolkit\Tasks\TestCacheSupportTask. Since you implemented __call, consider adding a @method annotation.

        }

        $result = opcache_get_status();
        if ($result) {

The expression $result of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->msg("Opcache is active");

            echo '<pre>';
            print_r($result);
            echo '</pre>';
        } else {
            $this->msg("Opcache is disabled. It should be enabled to ensure optimal performances", "error");
        }
    }
    protected function testMemcache()
    {
        if (!class_exists('Memcache')) {
            $this->msg("Memcache class does not exist. Make sure that the Memcache extension is installed");
        }

        $host = defined('MEMCACHE_HOST') ? MEMCACHE_HOST : 'localhost';

The constant LeKoala\DevToolkit\Tasks\MEMCACHE_HOST was not found. Maybe you did not declare it correctly or list all dependencies?

        $port = defined('MEMCACHE_PORT') ? MEMCACHE_PORT : 11211;

The constant LeKoala\DevToolkit\Tasks\MEMCACHE_PORT was not found. Maybe you did not declare it correctly or list all dependencies?

        $memcache = new \Memcache;
        $connected = $memcache->connect($host, $port);

        if ($connected) {
            $this->msg("Server's version: " . $memcache->getVersion());

            $result = $memcache->get("key");

            if ($result) {
                $this->msg("Data found in cache");
            } else {
                $this->msg("Data not found in cache");
                $tmp_object = new stdClass;
                $tmp_object->str_attr = "test";
                $tmp_object->int_attr = 123;
                $tmp_object->time = time();
                $tmp_object->date = date('Y-m-d H:i:s');
                $tmp_object->arr = array(1, 2, 3);
                $memcache->set("key", $tmp_object, false, 10);

false of type false is incompatible with the type integer expected by parameter $flag of MemcachePool::set().

            }

            $this->msg("Store data in the cache (data will expire in 10 seconds)");
            $this->msg("Data from the cache:");
            echo '<pre>';
            var_dump($memcache->get("key"));

var_dump($memcache->get('key')) looks like debug code. Are you sure you do not want to remove it?

            echo '</pre>';
        } else {
            $this->msg("Failed to connect");
        }
    }
}