lekoala / silverstripe-debugbar

tests/Collector/TimeDataCollectorTest.php

<?php

namespace LeKoala\DebugBar\Test\Collector;

use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;
use LeKoala\DebugBar\Collector\TimeDataCollector;
use LeKoala\DebugBar\DebugBar;

class TimeDataCollectorTest extends SapphireTest
{
    /**
     * @var DebugBarTimeDataCollector

The type LeKoala\DebugBar\Test\Collector\DebugBarTimeDataCollector was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    protected $collector;

    public function setUp(): void
    {
        parent::setUp();
        $this->collector = new TimeDataCollector(microtime(true));

It seems like new LeKoala\DebugBar\Collector\TimeDataCollector(microtime(true)) of type LeKoala\DebugBar\Collector\TimeDataCollector is incompatible with the declared type LeKoala\DebugBar\Test\Collector\DebugBarTimeDataCollector of property $collector.

It seems like microtime(true) can also be of type string; however, parameter $requestStartTime of LeKoala\DebugBar\Collector\TimeDataCollector::__construct() does only seem to accept double, maybe add an additional type check?

    }

    public function tearDown(): void
    {
        DebugBar::clearDebugBar();
        $this->collector = null;

        parent::tearDown();
    }

    public function testCollectorTooltip()
    {
        $result = $this->collector->getWidgets();
        $this->assertStringContainsString('Request duration', $result['time']['tooltip']);
    }

    /**
     * Deliberately low threshold - should return a danger result
     */
    public function testDangerOnVerySlowRequest()
    {
        Config::modify()->set(DebugBar::class, 'warn_request_time_seconds', '0.00001');
        $result = $this->collector->getWidgets();
        $this->assertSame('danger', $result['time']['warn']);
        $this->assertStringContainsString('>', $result['time']['tooltip']);
    }

    /**
     * Deliberately high threshold and low ratio - should return a warning result
     */
    public function testWarningOnSlowRequest()
    {
        Config::modify()->set(DebugBar::class, 'warn_request_time_seconds', '100');
        Config::modify()->set(DebugBar::class, 'warn_warning_ratio', '0.000000001');
        $result = $this->collector->getWidgets();
        $this->assertSame('warning', $result['time']['warn']);
        $this->assertStringContainsString('>', $result['time']['tooltip']);
    }

    /**
     * Deliberately high threshold and high ratio - should return an "ok" result
     */
    public function testOkOnNormalRequest()
    {
        Config::modify()->set(DebugBar::class, 'warn_request_time_seconds', '100');
        Config::modify()->set(DebugBar::class, 'warn_warning_ratio', '1');
        $result = $this->collector->getWidgets();
        $this->assertSame('ok', $result['time']['warn']);
        $this->assertStringContainsString('<', $result['time']['tooltip']);
    }

    public function testWarningCanBeDisabled()
    {
        Config::modify()->set(DebugBar::class, 'warn_request_time_seconds', false);
        $result = $this->collector->getWidgets();
        $this->assertArrayNotHasKey('warn', $result['time']);
    }
}